diff options
author | Noel Grandin <noel@peralex.com> | 2015-07-03 11:31:14 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2015-07-06 07:04:50 +0000 |
commit | e9c3583c2cc27fc88ee81047c236ec99dd51e8de (patch) | |
tree | b3e8394ca1ec402a31b227339366fc790124c1f8 /sc/source/ui/miscdlgs | |
parent | 89c77994d4638c86635c70535fab6508e2f3d900 (diff) |
improve the returnbyref loplugin
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb
Reviewed-on: https://gerrit.libreoffice.org/16731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sc/source/ui/miscdlgs')
-rw-r--r-- | sc/source/ui/miscdlgs/solveroptions.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sc/source/ui/miscdlgs/solveroptions.cxx b/sc/source/ui/miscdlgs/solveroptions.cxx index 4c38e68a9948..579c08c6055a 100644 --- a/sc/source/ui/miscdlgs/solveroptions.cxx +++ b/sc/source/ui/miscdlgs/solveroptions.cxx @@ -190,8 +190,8 @@ const uno::Sequence<beans::PropertyValue>& ScSolverOptionsDialog::GetProperties( sal_uInt16 nItemCount = pEntry->ItemCount(); for (sal_uInt16 nItemPos=0; nItemPos<nItemCount && !bHasData; ++nItemPos) { - SvLBoxItem* pItem = pEntry->GetItem( nItemPos ); - ScSolverOptionsString* pStringItem = dynamic_cast<ScSolverOptionsString*>(pItem); + SvLBoxItem& rItem = pEntry->GetItem( nItemPos ); + ScSolverOptionsString* pStringItem = dynamic_cast<ScSolverOptionsString*>(&rItem); if ( pStringItem ) { if ( pStringItem->IsDouble() ) @@ -313,8 +313,8 @@ void ScSolverOptionsDialog::EditOption() sal_uInt16 nItemCount = pEntry->ItemCount(); for (sal_uInt16 nPos=0; nPos<nItemCount; ++nPos) { - SvLBoxItem* pItem = pEntry->GetItem( nPos ); - ScSolverOptionsString* pStringItem = dynamic_cast<ScSolverOptionsString*>(pItem); + SvLBoxItem& rItem = pEntry->GetItem( nPos ); + ScSolverOptionsString* pStringItem = dynamic_cast<ScSolverOptionsString*>(&rItem); if ( pStringItem ) { if ( pStringItem->IsDouble() ) |