loplugin:constantparam in sc

Change-Id: I437367b8c6960db730a69c020ba82792a9170d01

5 files changed, 10 insertions, 11 deletions

diff --git a/sc/source/ui/undo/undobase.cxx b/sc/source/ui/undo/undobase.cxx
index 753f8dbac39a..dfdd563ec162 100644
--- a/sc/source/ui/undo/undobase.cxx
+++ b/sc/source/ui/undo/undobase.cxx
@@ -305,10 +305,10 @@ void ScBlockUndo::ShowBlock()
 }
 
 ScMultiBlockUndo::ScMultiBlockUndo(
-    ScDocShell* pDocSh, const ScRangeList& rRanges, ScBlockUndoMode eBlockMode) :
+    ScDocShell* pDocSh, const ScRangeList& rRanges) :
     ScSimpleUndo(pDocSh),
     maBlockRanges(rRanges),
-    meMode(eBlockMode)
+    meMode(SC_UNDO_SIMPLE)
 {
     mpDrawUndo = GetSdrUndoAction( &pDocShell->GetDocument() );
 }
diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx
index d86d6694de8b..270830de340d 100644
--- a/sc/source/ui/undo/undoblk.cxx
+++ b/sc/source/ui/undo/undoblk.cxx
@@ -830,7 +830,7 @@ ScUndoPaste::ScUndoPaste( ScDocShell* pNewDocShell, const ScRangeList& rRanges,
                 InsertDeleteFlags nNewFlags,
                 ScRefUndoData* pRefData,
                 bool bRedoIsFilled, const ScUndoPasteOptions* pOptions ) :
-    ScMultiBlockUndo( pNewDocShell, rRanges, SC_UNDO_SIMPLE ),
+    ScMultiBlockUndo( pNewDocShell, rRanges ),
     aMarkData( rMark ),
     pUndoDoc( pNewUndoDoc ),
     pRedoDoc( pNewRedoDoc ),
diff --git a/sc/source/ui/undo/undoblk2.cxx b/sc/source/ui/undo/undoblk2.cxx
index 65012a67f17f..e4319494f534 100644
--- a/sc/source/ui/undo/undoblk2.cxx
+++ b/sc/source/ui/undo/undoblk2.cxx
@@ -150,7 +150,7 @@ void ScUndoWidthOrHeight::Redo()
 
         // SetWidthOrHeight changes current sheet!
         pViewShell->SetWidthOrHeight(
-            bWidth, maRanges, eMode, nNewSize, false, true, &aMarkData);
+            bWidth, maRanges, eMode, nNewSize, false, &aMarkData);
     }
 
     // paint grid if selection was changed directly at the MarkData
diff --git a/sc/source/ui/undo/undocell.cxx b/sc/source/ui/undo/undocell.cxx
index bacb10db6dee..2dbdb4da0ac0 100644
--- a/sc/source/ui/undo/undocell.cxx
+++ b/sc/source/ui/undo/undocell.cxx
@@ -70,14 +70,14 @@ namespace HelperNotifyChanges
 ScUndoCursorAttr::ScUndoCursorAttr( ScDocShell* pNewDocShell,
             SCCOL nNewCol, SCROW nNewRow, SCTAB nNewTab,
             const ScPatternAttr* pOldPat, const ScPatternAttr* pNewPat,
-            const ScPatternAttr* pApplyPat, bool bAutomatic ) :
+            const ScPatternAttr* pApplyPat ) :
     ScSimpleUndo( pNewDocShell ),
     nCol( nNewCol ),
     nRow( nNewRow ),
     nTab( nNewTab ),
     pOldEditData( static_cast<EditTextObject*>(nullptr) ),
     pNewEditData( static_cast<EditTextObject*>(nullptr) ),
-    bIsAutomatic( bAutomatic )
+    bIsAutomatic( false )
 {
     ScDocumentPool* pPool = pDocShell->GetDocument().GetPool();
     pNewPattern = const_cast<ScPatternAttr*>(static_cast<const ScPatternAttr*>( &pPool->Put( *pNewPat ) ));
@@ -111,7 +111,7 @@ void ScUndoCursorAttr::DoChange( const ScPatternAttr* pWhichPattern, const share
 {
     ScDocument& rDoc = pDocShell->GetDocument();
     ScAddress aPos(nCol, nRow, nTab);
-    rDoc.SetPattern( nCol, nRow, nTab, *pWhichPattern, true );
+    rDoc.SetPattern( nCol, nRow, nTab, *pWhichPattern );
 
     if (rDoc.GetCellType(aPos) == CELLTYPE_EDIT && pEditData)
         rDoc.SetEditText(aPos, *pEditData, nullptr);
@@ -255,7 +255,7 @@ void ScUndoEnterData::Undo()
         {
             ScPatternAttr aPattern(*rDoc.GetPattern(maPos.Col(), maPos.Row(), rVal.mnTab));
             aPattern.GetItemSet().ClearItem( ATTR_VALUE_FORMAT );
-            rDoc.SetPattern(maPos.Col(), maPos.Row(), rVal.mnTab, aPattern, true);
+            rDoc.SetPattern(maPos.Col(), maPos.Row(), rVal.mnTab, aPattern);
         }
         pDocShell->PostPaintCell(maPos.Col(), maPos.Row(), rVal.mnTab);
     }
diff --git a/sc/source/ui/undo/undodat.cxx b/sc/source/ui/undo/undodat.cxx
index 59c839e36f8e..ad4f4aeeb40d 100644
--- a/sc/source/ui/undo/undodat.cxx
+++ b/sc/source/ui/undo/undodat.cxx
@@ -1791,8 +1791,7 @@ ScUndoDataForm::ScUndoDataForm( ScDocShell* pNewDocShell,
                                 ScDocument* pNewUndoDoc, ScDocument* pNewRedoDoc,
                                 InsertDeleteFlags nNewFlags,
                                 ScRefUndoData* pRefData,
-                                void* /*pFill1*/, void* /*pFill2*/, void* /*pFill3*/,
-                                bool bRedoIsFilled ) :
+                                void* /*pFill1*/, void* /*pFill2*/, void* /*pFill3*/ ) :
         ScBlockUndo( pNewDocShell, ScRange( nStartX, nStartY, nStartZ, nEndX, nEndY, nEndZ ), SC_UNDO_SIMPLE ),
         mpMarkData(new ScMarkData(rMark)),
         pUndoDoc( pNewUndoDoc ),
@@ -1800,7 +1799,7 @@ ScUndoDataForm::ScUndoDataForm( ScDocShell* pNewDocShell,
         nFlags( nNewFlags ),
         pRefUndoData( pRefData ),
         pRefRedoData( nullptr ),
-        bRedoFilled( bRedoIsFilled )
+        bRedoFilled( false )
 {
         //      pFill1,pFill2,pFill3 are there so the ctor calls for simple paste (without cutting)
         //      don't have to be changed and branched for 641.