diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-30 15:19:16 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-06-09 09:45:53 +0200 |
| commit | b79fa59df33da81daf119a61d6dffdae232baf82 (patch) | |
| tree | 70fbbb63d55beefd017abf13c7714f4964114bb0 /sc/source/ui/unoobj | |
| parent | 081d7b92ce503fa77043332728d056af7ead1604 (diff) | |
remove cargo cult OSL_ENSURE(pFact, "ScAbstractFactory create fail!"(
Possibly this was useful once upon a time, but now it's just noise.
If it failed, we're going to crash on the next line when we call a
method on that pointer anyway.
Change-Id: Ic601f0c3344f6895f8a6ffb3bc6f8bcb45d00a92
Reviewed-on: https://gerrit.libreoffice.org/55082
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/ui/unoobj')
| -rw-r--r-- | sc/source/ui/unoobj/filtuno.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sc/source/ui/unoobj/filtuno.cxx b/sc/source/ui/unoobj/filtuno.cxx index 26c45ecfbfc3..d15425eb92ad 100644 --- a/sc/source/ui/unoobj/filtuno.cxx +++ b/sc/source/ui/unoobj/filtuno.cxx @@ -179,7 +179,6 @@ sal_Int16 SAL_CALL ScFilterOptionsObj::execute() OUString aFilterString( aFilterName ); ScAbstractDialogFactory* pFact = ScAbstractDialogFactory::Create(); - OSL_ENSURE(pFact, "ScAbstractFactory create fail!"); if ( !bExport && aFilterString == ScDocShell::GetAsciiFilterName() ) { @@ -192,7 +191,6 @@ sal_Int16 SAL_CALL ScFilterOptionsObj::execute() pInStream.reset(utl::UcbStreamHelper::CreateStream( xInputStream )); ScopedVclPtr<AbstractScImportAsciiDlg> pDlg(pFact->CreateScImportAsciiDlg(nullptr, aPrivDatName, pInStream.get(), SC_IMPORTFILE)); - OSL_ENSURE(pDlg, "Dialog create fail!"); if ( pDlg->Execute() == RET_OK ) { ScAsciiOptions aOptions; @@ -320,7 +318,6 @@ sal_Int16 SAL_CALL ScFilterOptionsObj::execute() ScopedVclPtr<AbstractScImportOptionsDlg> pDlg(pFact->CreateScImportOptionsDlg( bAscii, &aOptions, &aTitle, bDBEnc, !bExport)); - OSL_ENSURE(pDlg, "Dialog create fail!"); if ( pDlg->Execute() == RET_OK ) { pDlg->SaveImportOptions(); |