Change OUStringLiteral from char[] to char16_t[]

This is a prerequisite for making conversion from OUStringLiteral to OUString
more efficient at least for C++20 (by replacing its internals with a constexpr-
generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount,
conditionally for C++20 for now).

For a configure-wise bare-bones build on Linux, size reported by `du -bs
instdir` grew by 118792 bytes from 1155636636 to 1155755428.

In most places just a u"..." string literal prefix had to be added.  In some
places

char const a[] = "...";

variables have been changed to char16_t, and a few places required even further
changes to code (which prompted the addition of include/o3tl/string_view.hxx
helper function o3tl::equalsIgnoreAsciiCase and the additional
OUString::createFromAscii overload).

For all uses of macros expanding to string literals, the relevant uses have been
rewritten as

u"" MACRO

instead of changing the macro definitions.  It should be possible to change at
least some of those macro definitions (and drop the u"" from their call sites)
in follow-up commits.

Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 16 insertions, 16 deletions

diff --git a/sc/source/ui/vba/vbachart.cxx b/sc/source/ui/vba/vbachart.cxx
index cd96b0a9312f..29aedba2e8fb 100644
--- a/sc/source/ui/vba/vbachart.cxx
+++ b/sc/source/ui/vba/vbachart.cxx
@@ -48,23 +48,23 @@ using namespace ::ooo::vba::excel::XlRowCol;
 using namespace ::ooo::vba::excel::XlAxisType;
 using namespace ::ooo::vba::excel::XlAxisGroup;
 
-const OUStringLiteral CHART_NAME("Name");
+const OUStringLiteral CHART_NAME(u"Name");
 // #TODO move this constant to vbaseries.[ch]xx ( when it exists )
-const OUStringLiteral DEFAULTSERIESPREFIX("Series");
-const OUStringLiteral DATAROWSOURCE("DataRowSource");
-const OUStringLiteral UPDOWN("UpDown");
-const OUStringLiteral VOLUME("Volume");
-const OUStringLiteral LINES("Lines");
-const OUStringLiteral SPLINETYPE("SplineType");
-const OUStringLiteral SYMBOLTYPE("SymbolType");
-const OUStringLiteral DEEP("Deep");
-const OUStringLiteral SOLIDTYPE("SolidType");
-const OUStringLiteral VERTICAL("Vertical");
-const OUStringLiteral PERCENT("Percent");
-const OUStringLiteral STACKED("Stacked");
-const OUStringLiteral DIM3D("Dim3D");
-const OUStringLiteral HASMAINTITLE("HasMainTitle");
-const OUStringLiteral HASLEGEND("HasLegend");
+const OUStringLiteral DEFAULTSERIESPREFIX(u"Series");
+const OUStringLiteral DATAROWSOURCE(u"DataRowSource");
+const OUStringLiteral UPDOWN(u"UpDown");
+const OUStringLiteral VOLUME(u"Volume");
+const OUStringLiteral LINES(u"Lines");
+const OUStringLiteral SPLINETYPE(u"SplineType");
+const OUStringLiteral SYMBOLTYPE(u"SymbolType");
+const OUStringLiteral DEEP(u"Deep");
+const OUStringLiteral SOLIDTYPE(u"SolidType");
+const OUStringLiteral VERTICAL(u"Vertical");
+const OUStringLiteral PERCENT(u"Percent");
+const OUStringLiteral STACKED(u"Stacked");
+const OUStringLiteral DIM3D(u"Dim3D");
+const OUStringLiteral HASMAINTITLE(u"HasMainTitle");
+const OUStringLiteral HASLEGEND(u"HasLegend");
 
 ScVbaChart::ScVbaChart( const css::uno::Reference< ov::XHelperInterface >& _xParent, const css::uno::Reference< css::uno::XComponentContext >& _xContext, const css::uno::Reference< css::lang::XComponent >& _xChartComponent, const css::uno::Reference< css::table::XTableChart >& _xTableChart ) : ChartImpl_BASE( _xParent, _xContext ), mxTableChart( _xTableChart )
 {