diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2023-02-16 10:42:06 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2023-02-16 15:13:21 +0000 |
| commit | 0908c7c1184ab7acb7b6f6740a82c2f12c296fae (patch) | |
| tree | 7bfe09dce871f6f2bc59a81b689d7ab5a3a6f3ea /sc/source/ui/vba/vbawindow.cxx | |
| parent | e71080e19365aa074c56d1136dad2b09783949a2 (diff) | |
SfxViewShell::GetViewFrame never returns null, change to a reference
various null checks can be seen to be redundant and removed
Change-Id: Icf49c1de4b0302795d2769a370af3abceaad0221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147147
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc/source/ui/vba/vbawindow.cxx')
| -rw-r--r-- | sc/source/ui/vba/vbawindow.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sc/source/ui/vba/vbawindow.cxx b/sc/source/ui/vba/vbawindow.cxx index 6885f9b18ca1..9bc913dcc2b2 100644 --- a/sc/source/ui/vba/vbawindow.cxx +++ b/sc/source/ui/vba/vbawindow.cxx @@ -381,8 +381,8 @@ ScVbaWindow::getWindowState() sal_Int32 nwindowState = xlNormal; // !! TODO !! get view shell from controller ScTabViewShell* pViewShell = excel::getBestViewShell( m_xModel ); - SfxViewFrame* pViewFrame = pViewShell -> GetViewFrame(); - WorkWindow* pWork = static_cast<WorkWindow*>( pViewFrame->GetFrame().GetSystemWindow() ); + SfxViewFrame& rViewFrame = pViewShell->GetViewFrame(); + WorkWindow* pWork = static_cast<WorkWindow*>( rViewFrame.GetFrame().GetSystemWindow() ); if ( pWork ) { if ( pWork -> IsMaximized()) @@ -400,8 +400,8 @@ ScVbaWindow::setWindowState( const uno::Any& _windowstate ) _windowstate >>= nwindowState; // !! TODO !! get view shell from controller ScTabViewShell* pViewShell = excel::getBestViewShell( m_xModel ); - SfxViewFrame* pViewFrame = pViewShell -> GetViewFrame(); - WorkWindow* pWork = static_cast<WorkWindow*>( pViewFrame->GetFrame().GetSystemWindow() ); + SfxViewFrame& rViewFrame = pViewShell->GetViewFrame(); + WorkWindow* pWork = static_cast<WorkWindow*>( rViewFrame.GetFrame().GetSystemWindow() ); if ( pWork ) { if ( nwindowState == xlMaximized) |