diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-04-18 15:13:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-04-19 13:19:31 +0200 |
| commit | 1a5b12aa5da2c718848d3cc5d9bce7bfcdeacf54 (patch) | |
| tree | 25044edc2afb99073ba6bef8d181dadbb6a53467 /sc/source/ui/view/dbfunc3.cxx | |
| parent | eaaaad0e21edb27edaa865eee03696f007cd8010 (diff) | |
optimise find/insert pattern
if we're doing a find/insert on a set or a map, it is better to just do
a conditional insert/emplace operation than triggering two lookups.
Change-Id: I80da5097f5a89fe30fa348ce5b6e747c34287a8d
Reviewed-on: https://gerrit.libreoffice.org/70937
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/ui/view/dbfunc3.cxx')
| -rw-r--r-- | sc/source/ui/view/dbfunc3.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx index f88001337b7e..40bd881535f0 100644 --- a/sc/source/ui/view/dbfunc3.cxx +++ b/sc/source/ui/view/dbfunc3.cxx @@ -1793,9 +1793,8 @@ bool ScDBFunc::DataPilotMove( const ScRange& rSource, const ScAddress& rDest ) pDPObj->GetHeaderPositionData( ScAddress( nCol, nRow, rSource.aStart.Tab() ), aSourceData ); if ( aSourceData.Dimension == aDestData.Dimension && !aSourceData.MemberName.isEmpty() ) { - if ( aMembersSet.find( aSourceData.MemberName ) == aMembersSet.end() ) + if ( aMembersSet.insert( aSourceData.MemberName ).second ) { - aMembersSet.insert( aSourceData.MemberName ); aMembersVector.push_back( aSourceData.MemberName ); } // duplicates are ignored |