diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-24 13:55:32 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-24 15:57:08 +0200 |
commit | 588333c9438bfd97c027c2cd0d4936f5b4cbf25a (patch) | |
tree | aa7424402a1e5ab36dcf28ada26faa531cc3e800 /sc/source/ui/view/dbfunc3.cxx | |
parent | b5ee452d403b0c94cc0d7548117e9c96d1d45c67 (diff) |
loplugin:useuniqueptr for ScOutlineTable in the undo code
fixing what looks like a couple of leaks on some paths
Change-Id: Idc851b8ffca8e5ed1bd54c9195442709ed310d40
Reviewed-on: https://gerrit.libreoffice.org/59558
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/ui/view/dbfunc3.cxx')
-rw-r--r-- | sc/source/ui/view/dbfunc3.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx index f5b1e6b9d670..b00359412132 100644 --- a/sc/source/ui/view/dbfunc3.cxx +++ b/sc/source/ui/view/dbfunc3.cxx @@ -438,7 +438,7 @@ void ScDBFunc::DoSubTotals( const ScSubTotalParam& rParam, bool bRecord, ScSubTotalParam aNewParam( rParam ); // change end of range ScDocument* pUndoDoc = nullptr; - ScOutlineTable* pUndoTab = nullptr; + std::unique_ptr<ScOutlineTable> pUndoTab; ScRangeName* pUndoRange = nullptr; ScDBCollection* pUndoDB = nullptr; @@ -450,7 +450,7 @@ void ScDBFunc::DoSubTotals( const ScSubTotalParam& rParam, bool bRecord, ScOutlineTable* pTable = rDoc.GetOutlineTable( nTab ); if (pTable) { - pUndoTab = new ScOutlineTable( *pTable ); + pUndoTab.reset(new ScOutlineTable( *pTable )); SCCOLROW nOutStartCol; // row/column status SCCOLROW nOutStartRow; @@ -526,7 +526,7 @@ void ScDBFunc::DoSubTotals( const ScSubTotalParam& rParam, bool bRecord, pDocSh->GetUndoManager()->AddUndoAction( new ScUndoSubTotals( pDocSh, nTab, rParam, aNewParam.nRow2, - pUndoDoc, pUndoTab, // pUndoDBData, + pUndoDoc, std::move(pUndoTab), // pUndoDBData, pUndoRange, pUndoDB ) ); } |