diff options
author | Xisco Fauli <xiscofauli@libreoffice.org> | 2025-04-29 17:29:26 +0200 |
---|---|---|
committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2025-04-29 21:02:16 +0200 |
commit | 0096200a4bdffd052aeb43b40e5d538d20e9c044 (patch) | |
tree | 8191b5a24029de5c2413b152ffb2356d6918b3a9 /sc/source/ui/view/tabvwshc.cxx | |
parent | 8b0a1ff82e4916825a5401ceefeac69ceb657433 (diff) |
ScQueryItem: no need to store a ScViewData pointer
it can be passed by reference, like the other dialogs do
Change-Id: I79abd717835012af8bcf8d4e135bd7e79f36ac35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184783
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Diffstat (limited to 'sc/source/ui/view/tabvwshc.cxx')
-rw-r--r-- | sc/source/ui/view/tabvwshc.cxx | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx index e95fa932178d..2ce3f1826a83 100644 --- a/sc/source/ui/view/tabvwshc.cxx +++ b/sc/source/ui/view/tabvwshc.cxx @@ -345,14 +345,12 @@ std::shared_ptr<SfxModelessDialogController> ScTabViewShell::CreateRefDialogCont pDBData->GetArea(aArea); MarkRange(aArea, false); - aArgSet.Put( ScQueryItem( SCITEM_QUERYDATA, - &GetViewData(), - &aQueryParam ) ); + aArgSet.Put( ScQueryItem( SCITEM_QUERYDATA, &aQueryParam ) ); // mark current sheet (due to RefInput in dialog) GetViewData().SetRefTabNo( GetViewData().GetTabNo() ); - xResult = std::make_shared<ScFilterDlg>(pB, pCW, pParent, aArgSet); + xResult = std::make_shared<ScFilterDlg>(pB, pCW, pParent, GetViewData(), aArgSet); break; } case SID_SPECIAL_FILTER: @@ -369,7 +367,7 @@ std::shared_ptr<SfxModelessDialogController> ScTabViewShell::CreateRefDialogCont pDBData->GetArea(aArea); MarkRange(aArea, false); - ScQueryItem aItem( SCITEM_QUERYDATA, &GetViewData(), &aQueryParam ); + ScQueryItem aItem( SCITEM_QUERYDATA, &aQueryParam ); ScRange aAdvSource; if (pDBData->GetAdvancedQuerySource(aAdvSource)) aItem.SetAdvancedQuerySource( &aAdvSource ); @@ -379,7 +377,7 @@ std::shared_ptr<SfxModelessDialogController> ScTabViewShell::CreateRefDialogCont // mark current sheet (due to RefInput in dialog) GetViewData().SetRefTabNo( GetViewData().GetTabNo() ); - xResult = std::make_shared<ScSpecialFilterDlg>(pB, pCW, pParent, aArgSet); + xResult = std::make_shared<ScSpecialFilterDlg>(pB, pCW, pParent, GetViewData(), aArgSet); break; } case SID_OPENDLG_OPTSOLVER: |