diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-21 11:49:48 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-25 14:19:10 +0200 |
| commit | 2c3cac855cf65a75d7e73e4cba10b757d5ab1940 (patch) | |
| tree | fda2f91478ee9ded8ad21e4b6ea5d57f87cad414 /sc/source/ui/view/viewutil.cxx | |
| parent | 8a258e8f9bbf766e0527bc19ff351c1d89bcfa67 (diff) | |
loplugin:unusedfields in sc
The *chart* fields in ScTabViewShell in sc/source/ui/inc/tabvwsh.hxx
are unused since:
commit 5021f298418f6efa7bb7b6540113b712599778fe
Author: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Date: Mon Jul 28 12:11:08 2014 -0300
Remove some unused code
The bEveryoneButMe field in ScChangeViewSettings is unused since
commit 90e8ad7ab779740c7381d26ffe7d08acc3a9ff96
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jul 21 15:39:17 2015 +0200
loplugin:unusedmethods scripting,sc
Change-Id: Ie9fbdf8f5e9177449316aaeb40ca3bd26df78a95
Reviewed-on: https://gerrit.libreoffice.org/40264
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source/ui/view/viewutil.cxx')
| -rw-r--r-- | sc/source/ui/view/viewutil.cxx | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/sc/source/ui/view/viewutil.cxx b/sc/source/ui/view/viewutil.cxx index c5bca8dec8c2..144176759fb4 100644 --- a/sc/source/ui/view/viewutil.cxx +++ b/sc/source/ui/view/viewutil.cxx @@ -147,18 +147,8 @@ bool ScViewUtil::IsActionShown( const ScChangeAction& rAction, if ( !rSettings.IsShowAccepted() && rAction.IsAccepted() && !rAction.IsRejecting() ) return false; - if ( rSettings.HasAuthor() ) - { - if ( rSettings.IsEveryoneButMe() ) - { - // GetUser() at ChangeTrack is the current user - ScChangeTrack* pTrack = rDocument.GetChangeTrack(); - if ( !pTrack || rAction.GetUser() == pTrack->GetUser() ) - return false; - } - else if ( rAction.GetUser() != rSettings.GetTheAuthorToShow() ) - return false; - } + if ( rSettings.HasAuthor() && rAction.GetUser() != rSettings.GetTheAuthorToShow() ) + return false; if ( rSettings.HasComment() ) { |