diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-12 16:39:03 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-18 07:37:31 +0000 |
commit | 789055bc2acb4c71483fd60ea258d158bd5aec10 (patch) | |
tree | 7849de841a71f667a30b2a971ad0c3d406110396 /sc/source/ui/view | |
parent | 150ac9cf05ed9da6a2af5bc3f820280fd853e519 (diff) |
clang-tidy performance-unnecessary-copy-initialization
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sc/source/ui/view')
-rw-r--r-- | sc/source/ui/view/viewdata.cxx | 5 | ||||
-rw-r--r-- | sc/source/ui/view/viewfun2.cxx | 3 |
2 files changed, 3 insertions, 5 deletions
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx index c7b7b2e39843..4bfa4e76b620 100644 --- a/sc/source/ui/view/viewdata.cxx +++ b/sc/source/ui/view/viewdata.cxx @@ -2775,10 +2775,9 @@ void ScViewData::ReadUserDataSequence(const uno::Sequence <beans::PropertyValue> } else if (sName == SC_ACTIVETABLE) { - OUString sValue; - if(rSettings[i].Value >>= sValue) + OUString sTabName; + if(rSettings[i].Value >>= sTabName) { - OUString sTabName(sValue); SCTAB nTab(0); if (GetDocument()->GetTable(sTabName, nTab)) nTabNo = nTab; diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx index fb47310614bd..18cccbf4123d 100644 --- a/sc/source/ui/view/viewfun2.cxx +++ b/sc/source/ui/view/viewfun2.cxx @@ -2380,8 +2380,7 @@ void ScViewFunc::InsertTableLink( const OUString& rFile, { OUString aFilterName = rFilter; OUString aOpt = rOptions; - OUString aURL = rFile; - ScDocumentLoader aLoader( aURL, aFilterName, aOpt ); + ScDocumentLoader aLoader( rFile, aFilterName, aOpt ); if (!aLoader.IsError()) { ScDocShell* pSrcSh = aLoader.GetDocShell(); |