diff options
| author | Gökay Şatır <gokaysatir@collabora.com> | 2024-12-12 19:28:47 +0300 |
|---|---|---|
| committer | Miklos Vajna <vmiklos@collabora.com> | 2025-01-03 12:05:04 +0100 |
| commit | 223a8291a649ab462fad23b682ec9a014cf8d6ed (patch) | |
| tree | 63cff3bbdc8e93e89f60f191a98463fc314517d3 /sc/source/ui/view | |
| parent | b4d1dff8835a2c52f2adf767596a367695a9e1a5 (diff) | |
cool#10794 Don't open validity dropdown in readOnly mode.
Issue: In readonly mode, validity dropdown is still usable.
Since the action is not performed via an uno command but event handling (function name is also: HandleMouseButtonDown), we need to add a guard to event handler.
This issue is online only. Desktop view doesn't have the issue.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ic0883d610f484cbc2b777200333e6ae5d14f52d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178378
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/179696
Tested-by: Jenkins
Diffstat (limited to 'sc/source/ui/view')
| -rw-r--r-- | sc/source/ui/view/gridwin.cxx | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index 2a73bc1857fa..eb7cbb2e27a7 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -2127,6 +2127,10 @@ void ScGridWindow::HandleMouseButtonDown( const MouseEvent& rMEvt, MouseEventSta if (!bWasMouseCaptured && IsMouseCaptured()) ReleaseMouse(); + const bool lokReadOnly = comphelper::LibreOfficeKit::isActive() && pViewSh->IsLokReadOnlyView(); + if (lokReadOnly) + return; // Return as if the action was performed, so the flow is not affected. + LaunchDataSelectMenu( aListValPos.Col(), aListValPos.Row() ); nMouseStatus = SC_GM_FILTER; // not set in DoAutoFilterMenue for bDataSelect |