diff options
author | Mike Kaganski <mike.kaganski@collabora.com> | 2024-11-15 13:04:58 +0500 |
---|---|---|
committer | Mike Kaganski <mike.kaganski@collabora.com> | 2024-11-23 16:05:36 +0100 |
commit | fa706421c9a981df11814cd845fe901181c49974 (patch) | |
tree | 0e7882a332313e187f10c84cb503fc260f454b81 /sc/source/ui/view | |
parent | ee331d51c84b0d6fcbd65810843ab6c836d9dea9 (diff) |
Avoid new string allocations, when only checking if empty
Change-Id: I35a44dedd27b5c3470ed035e64ec0461d8d0cbdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177074
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'sc/source/ui/view')
-rw-r--r-- | sc/source/ui/view/editsh.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/sc/source/ui/view/editsh.cxx b/sc/source/ui/view/editsh.cxx index ce39cd33d9a9..3fa202c29a3f 100644 --- a/sc/source/ui/view/editsh.cxx +++ b/sc/source/ui/view/editsh.cxx @@ -347,10 +347,9 @@ void ScEditShell::Execute( SfxRequest& rReq ) EditView* pActiveView = pHdl->GetActiveView(); if( pActiveView ) { - OUString sInput = rEngine.GetText(); ESelection aSel( pActiveView->GetSelection() ); - if( aSel.HasRange() ) - sInput = pActiveView->GetSelected(); + OUString sInput(aSel.HasRange() ? pActiveView->GetSelected() + : rEngine.GetText()); if( aSel.nStartPos > aSel.nEndPos ) aSel.nEndPos = aSel.nStartPos; |