summaryrefslogtreecommitdiff
path: root/sc/source/ui
diff options
context:
space:
mode:
authorLuboš Luňák <l.lunak@collabora.com>2022-01-31 20:27:54 +0100
committerLuboš Luňák <l.lunak@collabora.com>2022-02-01 11:16:43 +0100
commitddaebfb270c4b52ddebaf678a9352312c75247fa (patch)
treee64bb9ecbcece35a7cd4adb4b8c66bfead2ddc0b /sc/source/ui
parentde5aa409353c839483df21d47254fd2a508ab7d9 (diff)
fix the orientation combobox in the print dialog
Changing the orientation value to anything else than 'Automatic' didn't do anything by default. This was because by default neither isPaperSizeFromUser() nor getPapersizeFromSetup() were set, so PrintDialog::setPaperOrientation() did nothing. It looks to me like 8cbdc6a068ad88fc43a98bd0f88 that introduced it was rather broken (not just this bug, but also e.g. the ugly modifying of the paper sizes by non-const reference from a const function). In fact this whole stuff still looks broken to me, why does it change paper size instead of just setting the orientation? It seems like the orientation gets reset, or maybe the setting was just a band-aid. I don't know how to fix that all though. Change-Id: If5fdf4c47e06f2b0797d27126d21b3451b8334cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129239 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'sc/source/ui')
0 files changed, 0 insertions, 0 deletions