improve loplugin:unusedvarsglobal

to find any global variable, was checking the wrong property of
VarDecl

Change-Id: I454b4e0c1701bb0771768a1ee10cd738c4ab0726
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102278
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 0 insertions, 16 deletions

diff --git a/sc/source/ui/inc/content.hxx b/sc/source/ui/inc/content.hxx
index 7e02078129e7..53f234fdd145 100644
--- a/sc/source/ui/inc/content.hxx
+++ b/sc/source/ui/inc/content.hxx
@@ -60,8 +60,6 @@ class ScContentTree
 
     o3tl::enumarray<ScContentId, sal_uInt16> pPosList;     // for the sequence
 
-    static bool bIsInDrag;      // static, if the Navigator is deleted in ExecuteDrag
-
     ScDocShell* GetManualOrCurrent();
 
     void    InitRoot(ScContentId nType);
diff --git a/sc/source/ui/inc/viewfunc.hxx b/sc/source/ui/inc/viewfunc.hxx
index a8d4a25985c6..d23215c84088 100644
--- a/sc/source/ui/inc/viewfunc.hxx
+++ b/sc/source/ui/inc/viewfunc.hxx
@@ -373,7 +373,6 @@ private:
                                        SCCOL nEndCol, SCROW nEndRow, sal_uLong nCount );
 };
 
-extern bool bPasteIsDrop;
 extern bool bPasteIsMove;
 
 #endif
diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx
index b10cbcc7d615..6d45aed39a95 100644
--- a/sc/source/ui/navipi/content.cxx
+++ b/sc/source/ui/navipi/content.cxx
@@ -83,8 +83,6 @@ const OUStringLiteral aContentBmps[]=
     u"" RID_BMP_CONTENT_DRAWING
 };
 
-bool ScContentTree::bIsInDrag = false;
-
 ScDocShell* ScContentTree::GetManualOrCurrent()
 {
     ScDocShell* pSh = nullptr;
@@ -1232,7 +1230,6 @@ IMPL_LINK(ScContentTree, DragBeginHdl, bool&, rUnsetDragIcon, bool)
     bool bDisallow = true;
 
     std::unique_ptr<ScDocumentLoader> pDocLoader;
-    bIsInDrag = true;
 
     ScModule* pScMod = SC_MOD();
 
@@ -1376,8 +1373,6 @@ IMPL_LINK(ScContentTree, DragBeginHdl, bool&, rUnsetDragIcon, bool)
         }
     }
 
-    bIsInDrag = false;              // static member
-
     return bDisallow;
 }
 
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 9b30f3513a80..ddf50551b635 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -4477,10 +4477,8 @@ sal_Int8 ScGridWindow::ExecuteDrop( const ExecuteDropEvent& rEvt )
     if ( nFormatId != SotClipboardFormatId::NONE )
     {
         pScMod->SetInExecuteDrop( true );   // #i28468# prevent error messages from PasteDataFormat
-        bPasteIsDrop = true;
         bDone = pViewData->GetView()->PasteDataFormat(
                     nFormatId, rEvt.maDropEvent.Transferable, nPosX, nPosY, &aLogicPos, bIsLink );
-        bPasteIsDrop = false;
         pScMod->SetInExecuteDrop( false );
     }
 
@@ -4548,11 +4546,7 @@ void ScGridWindow::PasteSelection( const Point& rPosPixel )
         {
             SotClipboardFormatId nFormatId = lcl_GetDropFormatId( xTransferable, true );
             if ( nFormatId != SotClipboardFormatId::NONE )
-            {
-                bPasteIsDrop = true;
                 pViewData->GetView()->PasteDataFormat( nFormatId, xTransferable, nPosX, nPosY, &aLogicPos );
-                bPasteIsDrop = false;
-            }
         }
     }
 }
diff --git a/sc/source/ui/view/viewfun4.cxx b/sc/source/ui/view/viewfun4.cxx
index ef0501afc469..270dd0081641 100644
--- a/sc/source/ui/view/viewfun4.cxx
+++ b/sc/source/ui/view/viewfun4.cxx
@@ -74,8 +74,6 @@
 
 using namespace com::sun::star;
 
-bool bPasteIsDrop = false;
-
 void ScViewFunc::PasteRTF( SCCOL nStartCol, SCROW nStartRow,
                                 const css::uno::Reference< css::datatransfer::XTransferable >& rxTransferable )
 {