loplugin:passstuffbyref in sc

Change-Id: Ic3ce1406aa2567ca676bb8f431c52f590fadaec6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176198
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins

6 files changed, 24 insertions, 24 deletions

diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index 29387480a107..0d5639e8de29 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -2175,9 +2175,9 @@ OUString ScAccessibleDocument::GetCurrentCellName() const
     return sName;
 }
 
-OUString ScAccessibleDocument::GetCurrentCellDescription()
+const OUString & ScAccessibleDocument::GetCurrentCellDescription()
 {
-    return OUString();
+    return EMPTY_OUSTRING;
 }
 
 ScDocument *ScAccessibleDocument::GetDocument() const
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 7ef50cc7a8d3..4b502120e369 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -2899,32 +2899,32 @@ OUString ScDocShell::GetOwnFilterName()
     return pFilterSc50;
 }
 
-OUString ScDocShell::GetHtmlFilterName()
+const OUString & ScDocShell::GetHtmlFilterName()
 {
     return pFilterHtml;
 }
 
-OUString ScDocShell::GetWebQueryFilterName()
+const OUString & ScDocShell::GetWebQueryFilterName()
 {
     return pFilterHtmlWebQ;
 }
 
-OUString ScDocShell::GetAsciiFilterName()
+const OUString & ScDocShell::GetAsciiFilterName()
 {
     return SC_TEXT_CSV_FILTER_NAME;
 }
 
-OUString ScDocShell::GetLotusFilterName()
+const OUString & ScDocShell::GetLotusFilterName()
 {
     return pFilterLotus;
 }
 
-OUString ScDocShell::GetDBaseFilterName()
+const OUString & ScDocShell::GetDBaseFilterName()
 {
     return pFilterDBase;
 }
 
-OUString ScDocShell::GetDifFilterName()
+const OUString & ScDocShell::GetDifFilterName()
 {
     return pFilterDif;
 }
diff --git a/sc/source/ui/inc/AccessibleDocument.hxx b/sc/source/ui/inc/AccessibleDocument.hxx
index d7935dfd768e..eec10141a7bd 100644
--- a/sc/source/ui/inc/AccessibleDocument.hxx
+++ b/sc/source/ui/inc/AccessibleDocument.hxx
@@ -246,7 +246,7 @@ private:
     void RemoveChild(const css::uno::Reference<css::accessibility::XAccessible>& xAcc, bool bFireEvent);
 
     OUString GetCurrentCellName() const;
-    static OUString GetCurrentCellDescription();
+    static const OUString & GetCurrentCellDescription();
 
     tools::Rectangle GetVisibleArea_Impl() const;
 public:
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index 5b3ace8e1535..046cf75ea3a3 100644
--- a/sc/source/ui/inc/docsh.hxx
+++ b/sc/source/ui/inc/docsh.hxx
@@ -402,12 +402,12 @@ public:
 
     SAL_RET_MAYBENULL static ScDocShell* GetShellByNum( sal_uInt16 nDocNo );
     static OUString   GetOwnFilterName();
-    static OUString   GetHtmlFilterName();
-    static OUString   GetWebQueryFilterName();
-    static OUString   GetAsciiFilterName();
-    static OUString   GetLotusFilterName();
-    static OUString   GetDBaseFilterName();
-    static OUString   GetDifFilterName();
+    static const OUString & GetHtmlFilterName();
+    static const OUString & GetWebQueryFilterName();
+    static const OUString & GetAsciiFilterName();
+    static const OUString & GetLotusFilterName();
+    static const OUString & GetDBaseFilterName();
+    static const OUString & GetDifFilterName();
     static bool       HasAutomaticTableName( std::u16string_view rFilter );
     static void       LOKCommentNotify(LOKCommentNotificationType nType, const ScDocument& rDocument, const ScAddress& rPos, const ScPostIt* pNote);
 
diff --git a/sc/source/ui/inc/duplicaterecordsdlg.hxx b/sc/source/ui/inc/duplicaterecordsdlg.hxx
index 706ef3b18d00..c0bee041465c 100644
--- a/sc/source/ui/inc/duplicaterecordsdlg.hxx
+++ b/sc/source/ui/inc/duplicaterecordsdlg.hxx
@@ -47,7 +47,7 @@ public:
                                    ScViewData& rViewData, ScRange& aRange);
     virtual ~ScDuplicateRecordsDlg() override;
 
-    DuplicatesResponse GetDialogData() { return maResponse; };
+    const DuplicatesResponse& GetDialogData() { return maResponse; };
 
 private:
     void Init();
diff --git a/sc/source/ui/sparklines/SparklineAttributes.cxx b/sc/source/ui/sparklines/SparklineAttributes.cxx
index 8a615c1f7b00..ae8e2706b9aa 100644
--- a/sc/source/ui/sparklines/SparklineAttributes.cxx
+++ b/sc/source/ui/sparklines/SparklineAttributes.cxx
@@ -157,7 +157,7 @@ void SparklineAttributes::resetColors()
     m_aImplementation->m_aColorLow = model::ComplexColor();
 }
 
-model::ComplexColor SparklineAttributes::getColorSeries() const
+const model::ComplexColor& SparklineAttributes::getColorSeries() const
 {
     return m_aImplementation->m_aColorSeries;
 }
@@ -167,7 +167,7 @@ void SparklineAttributes::setColorSeries(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorSeries = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorNegative() const
+const model::ComplexColor& SparklineAttributes::getColorNegative() const
 {
     return m_aImplementation->m_aColorNegative;
 }
@@ -177,7 +177,7 @@ void SparklineAttributes::setColorNegative(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorNegative = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorAxis() const
+const model::ComplexColor& SparklineAttributes::getColorAxis() const
 {
     return m_aImplementation->m_aColorAxis;
 }
@@ -187,7 +187,7 @@ void SparklineAttributes::setColorAxis(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorAxis = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorMarkers() const
+const model::ComplexColor& SparklineAttributes::getColorMarkers() const
 {
     return m_aImplementation->m_aColorMarkers;
 }
@@ -196,7 +196,7 @@ void SparklineAttributes::setColorMarkers(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorMarkers = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorFirst() const
+const model::ComplexColor& SparklineAttributes::getColorFirst() const
 {
     return m_aImplementation->m_aColorFirst;
 }
@@ -205,7 +205,7 @@ void SparklineAttributes::setColorFirst(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorFirst = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorLast() const
+const model::ComplexColor& SparklineAttributes::getColorLast() const
 {
     return m_aImplementation->m_aColorLast;
 }
@@ -214,7 +214,7 @@ void SparklineAttributes::setColorLast(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorLast = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorHigh() const
+const model::ComplexColor& SparklineAttributes::getColorHigh() const
 {
     return m_aImplementation->m_aColorHigh;
 }
@@ -223,7 +223,7 @@ void SparklineAttributes::setColorHigh(model::ComplexColor const& rColor)
     m_aImplementation->m_aColorHigh = rColor;
 }
 
-model::ComplexColor SparklineAttributes::getColorLow() const
+const model::ComplexColor& SparklineAttributes::getColorLow() const
 {
     return m_aImplementation->m_aColorLow;
 }