add COVERITY_NOEXCEPT_FALSE

to markup dtors that coverity warns might throw exceptions
which won't throw in practice, or where std::terminate is
an acceptable response if they do

Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4
Reviewed-on: https://gerrit.libreoffice.org/38318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

14 files changed, 16 insertions, 16 deletions

diff --git a/sc/source/core/data/colcontainer.cxx b/sc/source/core/data/colcontainer.cxx
index fa2a18feb257..cd185032ee8b 100644
--- a/sc/source/core/data/colcontainer.cxx
+++ b/sc/source/core/data/colcontainer.cxx
@@ -30,7 +30,7 @@ ScColContainer::ScColContainer( ScDocument* pDoc, const size_t nSize )
         aCols[nCol] = new ScColumn;
 }
 
-ScColContainer::~ScColContainer()
+ScColContainer::~ScColContainer() COVERITY_NOEXCEPT_FALSE
 {
     Clear();
 }
diff --git a/sc/source/core/data/colorscale.cxx b/sc/source/core/data/colorscale.cxx
index cfa93309ec63..6b9837bb4a68 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -194,7 +194,7 @@ ScColorScaleEntry::ScColorScaleEntry(ScDocument* pDoc, const ScColorScaleEntry&
     }
 }
 
-ScColorScaleEntry::~ScColorScaleEntry()
+ScColorScaleEntry::~ScColorScaleEntry() COVERITY_NOEXCEPT_FALSE
 {
     if(mpCell)
         mpCell->EndListeningTo(mpCell->GetDocument());
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index f0735c5a7948..17974f0aa46a 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -97,7 +97,7 @@ ScColumn::ScColumn() :
     maCells.resize(MAXROWCOUNT);
 }
 
-ScColumn::~ScColumn()
+ScColumn::~ScColumn() COVERITY_NOEXCEPT_FALSE
 {
     FreeAll();
     delete pAttrArray;
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 16e4909ab5ff..a3f81f202d2b 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -483,7 +483,7 @@ public:
         mpStylePool->SetSearchMask(SfxStyleFamily::Page);
     }
 
-    ~IdleCalcTextWidthScope()
+    ~IdleCalcTextWidthScope() COVERITY_NOEXCEPT_FALSE
     {
         SfxPrinter* pDev = mrDoc.GetPrinter();
         if (pDev)
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index e527bb82ec5e..fe7b88966374 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -330,7 +330,7 @@ ScTable::ScTable( ScDocument* pDoc, SCTAB nNewTab, const OUString& rNewName,
         aCol[k].Init( k, nTab, pDocument, true );
 }
 
-ScTable::~ScTable()
+ScTable::~ScTable() COVERITY_NOEXCEPT_FALSE
 {
     if (!pDocument->IsInDtorClear())
     {
diff --git a/sc/source/core/inc/bcaslot.hxx b/sc/source/core/inc/bcaslot.hxx
index abffcb51a042..ce5f33384124 100644
--- a/sc/source/core/inc/bcaslot.hxx
+++ b/sc/source/core/inc/bcaslot.hxx
@@ -359,7 +359,7 @@ public:
         if (pBASM)
             pBASM->EnterBulkBroadcast();
     }
-    ~ScBulkBroadcast()
+    ~ScBulkBroadcast() COVERITY_NOEXCEPT_FALSE
     {
         if (pBASM)
             pBASM->LeaveBulkBroadcast( mnHintId );
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 2f603e02ff71..675c05c8881e 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -232,7 +232,7 @@ public:
 
     ScMatrixImpl( size_t nC, size_t nR, const std::vector<double>& rInitVals );
 
-    ~ScMatrixImpl();
+    ~ScMatrixImpl() COVERITY_NOEXCEPT_FALSE;
 
     void Clear();
     void Resize(SCSIZE nC, SCSIZE nR);
@@ -346,7 +346,7 @@ ScMatrixImpl::ScMatrixImpl(SCSIZE nC, SCSIZE nR, double fInitVal) :
 ScMatrixImpl::ScMatrixImpl( size_t nC, size_t nR, const std::vector<double>& rInitVals ) :
     maMat(nR, nC, rInitVals.begin(), rInitVals.end()), maMatFlag(nR, nC), pErrorInterpreter(nullptr) {}
 
-ScMatrixImpl::~ScMatrixImpl()
+ScMatrixImpl::~ScMatrixImpl() COVERITY_NOEXCEPT_FALSE
 {
     Clear();
 }
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 0ece2cf55594..8ccfffa058a9 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -3117,7 +3117,7 @@ ScDocShellModificator::ScDocShellModificator( ScDocShell& rDS )
     rDoc.EnableIdle(false);
 }
 
-ScDocShellModificator::~ScDocShellModificator()
+ScDocShellModificator::~ScDocShellModificator() COVERITY_NOEXCEPT_FALSE
 {
     ScDocument& rDoc = rDocShell.GetDocument();
     rDoc.SetAutoCalcShellDisabled( bAutoCalcShellDisabled );
diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 936fdcf0e9b3..731f1a662c48 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -177,7 +177,7 @@ ScImportExport::ScImportExport( ScDocument* p, const OUString& rPos )
         bAll = true;
 }
 
-ScImportExport::~ScImportExport()
+ScImportExport::~ScImportExport() COVERITY_NOEXCEPT_FALSE
 {
     delete pUndoDoc;
     delete pExtOptions;
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index 43204614e26d..5e2cbb8a5db2 100644
--- a/sc/source/ui/inc/docsh.hxx
+++ b/sc/source/ui/inc/docsh.hxx
@@ -444,7 +444,7 @@ class SC_DLLPUBLIC ScDocShellModificator
 
 public:
     explicit ScDocShellModificator( ScDocShell& );
-    ~ScDocShellModificator();
+    ~ScDocShellModificator() COVERITY_NOEXCEPT_FALSE;
     void            SetDocumentModified();
 };
 
diff --git a/sc/source/ui/inc/impex.hxx b/sc/source/ui/inc/impex.hxx
index 609bc3daed64..02b5349c2751 100644
--- a/sc/source/ui/inc/impex.hxx
+++ b/sc/source/ui/inc/impex.hxx
@@ -92,7 +92,7 @@ public:
     ScImportExport( ScDocument*, const OUString& );   // Range/cell input
     ScImportExport( ScDocument*, const ScAddress& );
     ScImportExport( ScDocument*, const ScRange& );
-   ~ScImportExport();
+   ~ScImportExport() COVERITY_NOEXCEPT_FALSE;
 
     void SetExtOptions( const ScAsciiOptions& rOpt );
     void SetFilterOptions( const OUString& rFilterOptions );
diff --git a/sc/source/ui/inc/viewdata.hxx b/sc/source/ui/inc/viewdata.hxx
index 0c0613526d8f..13d6514bea5c 100644
--- a/sc/source/ui/inc/viewdata.hxx
+++ b/sc/source/ui/inc/viewdata.hxx
@@ -247,7 +247,7 @@ private:
 public:
                     ScViewData( ScDocShell* pDocSh, ScTabViewShell* pViewSh );
                     ScViewData( const ScViewData& rViewData );
-                    ~ScViewData();
+                    ~ScViewData() COVERITY_NOEXCEPT_FALSE;
 
     void            InitData( ScDocument* pDocument );
 
diff --git a/sc/source/ui/unoobj/funcuno.cxx b/sc/source/ui/unoobj/funcuno.cxx
index 81e13bde7bd8..f7865ea7df76 100644
--- a/sc/source/ui/unoobj/funcuno.cxx
+++ b/sc/source/ui/unoobj/funcuno.cxx
@@ -67,7 +67,7 @@ private:
 
 public:
     explicit ScTempDocSource( ScTempDocCache& rDocCache );
-    ~ScTempDocSource();
+    ~ScTempDocSource() COVERITY_NOEXCEPT_FALSE;
 
     ScDocument*     GetDocument();
 };
@@ -93,7 +93,7 @@ ScTempDocSource::ScTempDocSource( ScTempDocCache& rDocCache ) :
     }
 }
 
-ScTempDocSource::~ScTempDocSource()
+ScTempDocSource::~ScTempDocSource() COVERITY_NOEXCEPT_FALSE
 {
     if ( pTempDoc )
         delete pTempDoc;
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index f4daf380d684..63257497cb7c 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -492,7 +492,7 @@ ScDocument* ScViewData::GetDocument() const
     return nullptr;
 }
 
-ScViewData::~ScViewData()
+ScViewData::~ScViewData() COVERITY_NOEXCEPT_FALSE
 {
     KillEditView();
     delete pOptions;