diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2016-10-04 13:11:13 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2016-10-04 16:06:23 +0000 |
| commit | 33e8582c0f34ce30e4a29228548438dc53aa8711 (patch) | |
| tree | 2365322a86a850517f21e3e61ed6024a8bad3659 /sc/source | |
| parent | 76a5c7138361d8fc6493638d6c5a882e0a891bb0 (diff) | |
coverity#1371197 the compiler defaults should be sufficient here
Change-Id: I4230d03dc58027f958d8943c0ff90f00508f7386
Reviewed-on: https://gerrit.libreoffice.org/29523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc/source')
| -rw-r--r-- | sc/source/core/data/cellvalue.cxx | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/sc/source/core/data/cellvalue.cxx b/sc/source/core/data/cellvalue.cxx index 25ed7d705726..147ad514f3fb 100644 --- a/sc/source/core/data/cellvalue.cxx +++ b/sc/source/core/data/cellvalue.cxx @@ -489,19 +489,11 @@ ScRefCellValue::ScRefCellValue( const svl::SharedString* pString ) : meType(CELL ScRefCellValue::ScRefCellValue( const EditTextObject* pEditText ) : meType(CELLTYPE_EDIT), mpEditText(pEditText) {} ScRefCellValue::ScRefCellValue( ScFormulaCell* pFormula ) : meType(CELLTYPE_FORMULA), mpFormula(pFormula) {} -// It should be enough to copy the double value, which is at least as large -// as the pointer values. -ScRefCellValue::ScRefCellValue( const ScRefCellValue& r ) : meType(r.meType), mfValue(r.mfValue) {} - ScRefCellValue::ScRefCellValue( ScDocument& rDoc, const ScAddress& rPos ) { assign( rDoc, rPos); } -ScRefCellValue::~ScRefCellValue() -{ -} - void ScRefCellValue::clear() { // Reset to empty value. @@ -589,16 +581,4 @@ bool ScRefCellValue::equalsWithoutFormat( const ScRefCellValue& r ) const return equalsWithoutFormatImpl(*this, r); } -ScRefCellValue& ScRefCellValue::operator= ( const ScRefCellValue& r ) -{ - // So we *could* have a copy-swap-idiom here for exception-safety if we had - // to slow down things.. but then implement an explicit move-ctor and pass - // r by-value instead of manually creating a temporary so the compiler can - // take advantage. And initialize - // ScRefCellValue(ScDocument&,const ScAddress&) with default ctor. - meType = r.meType; - mfValue = r.mfValue; // largest member of union - return *this; -} - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |