diff options
author | Noel Grandin <noel@peralex.com> | 2016-07-22 14:35:27 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-07-25 06:09:17 +0000 |
commit | 938821fb08e427864db6a10642f385bde9803f6c (patch) | |
tree | 759da9d0d0905a90f6dac2f0bf750721c17421c4 /sc/source | |
parent | 4d4d77a1aad1bcae18bad35dad5308d33d6b2e51 (diff) |
new loplugin overrideparam
verify that parameters on override methods have the same set of default
values for their params as their parent/super-methods do.
Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2
Reviewed-on: https://gerrit.libreoffice.org/27437
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sc/source')
-rw-r--r-- | sc/source/filter/xml/XMLTableMasterPageExport.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/docsh.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tabpages.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tabvwsh.hxx | 4 | ||||
-rw-r--r-- | sc/source/ui/inc/tpcalc.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpcompatibility.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpdefaults.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpformula.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tphf.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpprint.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpsort.hxx | 4 | ||||
-rw-r--r-- | sc/source/ui/inc/tptable.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpusrlst.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/tpview.hxx | 4 | ||||
-rw-r--r-- | sc/source/ui/inc/uiitems.hxx | 4 |
15 files changed, 19 insertions, 19 deletions
diff --git a/sc/source/filter/xml/XMLTableMasterPageExport.hxx b/sc/source/filter/xml/XMLTableMasterPageExport.hxx index 099cc40079df..d2a243cc8109 100644 --- a/sc/source/filter/xml/XMLTableMasterPageExport.hxx +++ b/sc/source/filter/xml/XMLTableMasterPageExport.hxx @@ -40,7 +40,7 @@ class XMLTableMasterPageExport : public XMLTextMasterPageExport protected: virtual void exportHeaderFooterContent( const css::uno::Reference< css::text::XText >& rText, - bool bAutoStyles, bool bProgress ) override; + bool bAutoStyles, bool bProgress = true ) override; virtual void exportMasterPageContent( const css::uno::Reference< css::beans::XPropertySet > & rPropSet, diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx index 7385a71406c8..7cb00e48d655 100644 --- a/sc/source/ui/inc/docsh.hxx +++ b/sc/source/ui/inc/docsh.hxx @@ -201,7 +201,7 @@ public: virtual void PrepareReload() override; virtual void LoadStyles( SfxObjectShell &rSource ) override; - virtual bool DoSaveCompleted( SfxMedium * pNewStor, bool bRegisterRecent ) override; // SfxObjectShell + virtual bool DoSaveCompleted( SfxMedium * pNewStor=nullptr, bool bRegisterRecent=true ) override; // SfxObjectShell virtual bool QuerySlotExecutable( sal_uInt16 nSlotId ) override; virtual void Draw( OutputDevice *, const JobSetup & rSetup, diff --git a/sc/source/ui/inc/tabpages.hxx b/sc/source/ui/inc/tabpages.hxx index b44699e1be4d..1eecb5225e7f 100644 --- a/sc/source/ui/inc/tabpages.hxx +++ b/sc/source/ui/inc/tabpages.hxx @@ -40,7 +40,7 @@ public: protected: using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet ) override; private: ScTabPageProtection( vcl::Window* pParent, diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index 6bae511512ef..a5a55981cc6f 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -198,8 +198,8 @@ protected: virtual void QueryObjAreaPixel( Rectangle& rRect ) const override; - virtual OUString GetSelectionText( bool bWholeWord ) override; - virtual bool HasSelection( bool bText ) const override; + virtual OUString GetSelectionText( bool bWholeWord = false ) override; + virtual bool HasSelection( bool bText = true ) const override; virtual void WriteUserData(OUString &, bool bBrowse = false) override; virtual void ReadUserData(const OUString &, bool bBrowse = false) override; diff --git a/sc/source/ui/inc/tpcalc.hxx b/sc/source/ui/inc/tpcalc.hxx index bb35a16c07da..fe5aaa4b57b7 100644 --- a/sc/source/ui/inc/tpcalc.hxx +++ b/sc/source/ui/inc/tpcalc.hxx @@ -38,7 +38,7 @@ public: virtual bool FillItemSet ( SfxItemSet* rCoreSet ) override; virtual void Reset ( const SfxItemSet* rCoreSet ) override; using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet ) override; private: ScTpCalcOptions( vcl::Window* pParent, diff --git a/sc/source/ui/inc/tpcompatibility.hxx b/sc/source/ui/inc/tpcompatibility.hxx index 4c0c1f14aca0..17f055f3f7f3 100644 --- a/sc/source/ui/inc/tpcompatibility.hxx +++ b/sc/source/ui/inc/tpcompatibility.hxx @@ -24,7 +24,7 @@ public: virtual bool FillItemSet(SfxItemSet* rCoreAttrs) override; virtual void Reset(const SfxItemSet* rCoreAttrs) override; - virtual DeactivateRC DeactivatePage(SfxItemSet* pSet = nullptr) override; + virtual DeactivateRC DeactivatePage(SfxItemSet* pSet ) override; virtual ~ScTpCompatOptions(); virtual void dispose() override; diff --git a/sc/source/ui/inc/tpdefaults.hxx b/sc/source/ui/inc/tpdefaults.hxx index 9b5246953b05..9664b3cf0632 100644 --- a/sc/source/ui/inc/tpdefaults.hxx +++ b/sc/source/ui/inc/tpdefaults.hxx @@ -24,7 +24,7 @@ public: virtual bool FillItemSet(SfxItemSet* rCoreSet) override; virtual void Reset(const SfxItemSet* rCoreSet) override; - virtual DeactivateRC DeactivatePage(SfxItemSet* pSet = nullptr) override; + virtual DeactivateRC DeactivatePage(SfxItemSet* pSet) override; private: explicit ScTpDefaultsOptions(vcl::Window* pParent, const SfxItemSet& rCoreSet); diff --git a/sc/source/ui/inc/tpformula.hxx b/sc/source/ui/inc/tpformula.hxx index 1a7e1ac42d92..0f5c7d90af48 100644 --- a/sc/source/ui/inc/tpformula.hxx +++ b/sc/source/ui/inc/tpformula.hxx @@ -39,7 +39,7 @@ public: virtual bool FillItemSet(SfxItemSet* rCoreSet) override; virtual void Reset( const SfxItemSet* rCoreSet ) override; - virtual DeactivateRC DeactivatePage(SfxItemSet* pSet = nullptr) override; + virtual DeactivateRC DeactivatePage(SfxItemSet* pSet ) override; private: explicit ScTpFormulaOptions(vcl::Window* pParent, const SfxItemSet& rCoreSet); diff --git a/sc/source/ui/inc/tphf.hxx b/sc/source/ui/inc/tphf.hxx index 29692363059d..e7b02579c0ca 100644 --- a/sc/source/ui/inc/tphf.hxx +++ b/sc/source/ui/inc/tphf.hxx @@ -44,7 +44,7 @@ protected: virtual void ActivatePage() override; virtual void DeactivatePage() override; virtual void ActivatePage( const SfxItemSet& rSet ) override; - virtual DeactivateRC DeactivatePage( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage( SfxItemSet* pSet ) override; private: VclPtr<PushButton> m_pBtnEdit; diff --git a/sc/source/ui/inc/tpprint.hxx b/sc/source/ui/inc/tpprint.hxx index 16b396a1bd30..c3e202f41f18 100644 --- a/sc/source/ui/inc/tpprint.hxx +++ b/sc/source/ui/inc/tpprint.hxx @@ -38,7 +38,7 @@ public: virtual bool FillItemSet( SfxItemSet* rCoreSet ) override; virtual void Reset( const SfxItemSet* rCoreSet ) override; using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage( SfxItemSet* pSet ) override; }; #endif diff --git a/sc/source/ui/inc/tpsort.hxx b/sc/source/ui/inc/tpsort.hxx index 8410250871ee..99d791eacbaa 100644 --- a/sc/source/ui/inc/tpsort.hxx +++ b/sc/source/ui/inc/tpsort.hxx @@ -64,7 +64,7 @@ protected: virtual void ActivatePage ( const SfxItemSet& rSet ) override; using SfxTabPage::ActivatePage; using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet = nullptr) override; + virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet ) override; private: OUString aStrUndefined; @@ -120,7 +120,7 @@ protected: virtual void ActivatePage ( const SfxItemSet& rSet ) override; using SfxTabPage::ActivatePage; using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet = nullptr) override; + virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet ) override; private: diff --git a/sc/source/ui/inc/tptable.hxx b/sc/source/ui/inc/tptable.hxx index c8fc966d8e19..21d75fb55a9a 100644 --- a/sc/source/ui/inc/tptable.hxx +++ b/sc/source/ui/inc/tptable.hxx @@ -36,7 +36,7 @@ public: virtual bool FillItemSet ( SfxItemSet* rCoreSet ) override; virtual void Reset ( const SfxItemSet* rCoreSet ) override; using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet ) override; virtual void DataChanged ( const DataChangedEvent& rDCEvt ) override; virtual ~ScTablePage(); diff --git a/sc/source/ui/inc/tpusrlst.hxx b/sc/source/ui/inc/tpusrlst.hxx index 982646b0b09f..a0a473415950 100644 --- a/sc/source/ui/inc/tpusrlst.hxx +++ b/sc/source/ui/inc/tpusrlst.hxx @@ -39,7 +39,7 @@ public: virtual bool FillItemSet ( SfxItemSet* rCoreAttrs ) override; virtual void Reset ( const SfxItemSet* rCoreAttrs ) override; using SfxTabPage::DeactivatePage; - virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage ( SfxItemSet* pSet ) override; private: ScTpUserLists( vcl::Window* pParent, diff --git a/sc/source/ui/inc/tpview.hxx b/sc/source/ui/inc/tpview.hxx index e415f110570c..d9c9f3317fa1 100644 --- a/sc/source/ui/inc/tpview.hxx +++ b/sc/source/ui/inc/tpview.hxx @@ -78,7 +78,7 @@ public: using SfxTabPage::ActivatePage; using SfxTabPage::DeactivatePage; virtual void ActivatePage( const SfxItemSet& ) override; - virtual DeactivateRC DeactivatePage( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage( SfxItemSet* pSet ) override; }; @@ -123,7 +123,7 @@ public: using SfxTabPage::ActivatePage; using SfxTabPage::DeactivatePage; virtual void ActivatePage( const SfxItemSet& ) override; - virtual DeactivateRC DeactivatePage( SfxItemSet* pSet = nullptr ) override; + virtual DeactivateRC DeactivatePage( SfxItemSet* pSet ) override; void SetDocument(ScDocument* pPtr){pDoc = pPtr;} diff --git a/sc/source/ui/inc/uiitems.hxx b/sc/source/ui/inc/uiitems.hxx index 4d8971960ab2..a2eaf7d9387d 100644 --- a/sc/source/ui/inc/uiitems.hxx +++ b/sc/source/ui/inc/uiitems.hxx @@ -141,7 +141,7 @@ public: virtual bool operator==( const SfxPoolItem& ) const override; virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; - virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberUd ) const override; + virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; ScViewData* GetViewData () const { return pViewData; } const ScSortParam& GetSortData () const { return theSortData; } @@ -191,7 +191,7 @@ public: virtual bool operator==( const SfxPoolItem& ) const override; virtual SfxPoolItem* Clone( SfxItemPool *pPool = nullptr ) const override; - virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberUd ) const override; + virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; ScViewData* GetViewData () const { return pViewData; } const ScSubTotalParam& GetSubTotalData() const { return theSubTotalData; } |