diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-15 20:24:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-16 07:57:45 +0200 |
| commit | 3ee177a14d8b816ef5b62500aeb54524c289e045 (patch) | |
| tree | 982b524a298c2b2f959f5c858c81be9b3420566a /sc/source | |
| parent | 820f340f285932bbb8d6739177e9bb81c23c1a5d (diff) | |
loplugin:stringadd look through a couple more known-good methods
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48
Reviewed-on: https://gerrit.libreoffice.org/80855
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc/source')
| -rw-r--r-- | sc/source/core/tool/rangeutl.cxx | 3 | ||||
| -rw-r--r-- | sc/source/filter/html/htmlpars.cxx | 8 | ||||
| -rw-r--r-- | sc/source/ui/docshell/impex.cxx | 3 |
3 files changed, 6 insertions, 8 deletions
diff --git a/sc/source/core/tool/rangeutl.cxx b/sc/source/core/tool/rangeutl.cxx index 968b2d7ddd49..ea87576d7df5 100644 --- a/sc/source/core/tool/rangeutl.cxx +++ b/sc/source/core/tool/rangeutl.cxx @@ -53,8 +53,7 @@ bool ScRangeUtil::MakeArea( const OUString& rAreaStr, if ( nColonPos == -1 && nPointPos != -1 ) { - aStrArea += ":"; - aStrArea += rAreaStr.copy( nPointPos+1 ); // do not include '.' in copy + aStrArea += ":" + rAreaStr.copy( nPointPos+1 ); // do not include '.' in copy } bSuccess = ConvertDoubleRef( pDoc, aStrArea, nTab, startPos, endPos, rDetails ); diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx index eb547482b0d9..67ff279b84bc 100644 --- a/sc/source/filter/html/htmlpars.cxx +++ b/sc/source/filter/html/htmlpars.cxx @@ -257,8 +257,8 @@ ErrCode ScHTMLLayoutParser::Read( SvStream& rStream, const OUString& rBaseURL ) const sal_Char* pCharSet = rtl_getBestMimeCharsetFromTextEncoding( RTL_TEXTENCODING_UTF8 ); if( pCharSet ) { - OUString aContentType = "text/html; charset="; - aContentType += OUString::createFromAscii( pCharSet ); + OUString aContentType = "text/html; charset=" + + OUString::createFromAscii( pCharSet ); xValues = new SvKeyValueIterator; xValues->Append( SvKeyValue( OOO_STRING_SVTOOLS_HTML_META_content_type, aContentType ) ); @@ -2772,8 +2772,8 @@ ErrCode ScHTMLQueryParser::Read( SvStream& rStrm, const OUString& rBaseURL ) const sal_Char* pCharSet = rtl_getBestMimeCharsetFromTextEncoding( RTL_TEXTENCODING_UTF8 ); if( pCharSet ) { - OUString aContentType = "text/html; charset="; - aContentType += OUString::createFromAscii( pCharSet ); + OUString aContentType = "text/html; charset=" + + OUString::createFromAscii( pCharSet ); xValues = new SvKeyValueIterator; xValues->Append( SvKeyValue( OOO_STRING_SVTOOLS_HTML_META_content_type, aContentType ) ); diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx index cc04c75b57f0..494f0548a0c7 100644 --- a/sc/source/ui/docshell/impex.cxx +++ b/sc/source/ui/docshell/impex.cxx @@ -1174,8 +1174,7 @@ static bool lcl_PutString( if (nFound > 6) { sal_Unicode cDec = '.'; - OUString aT( &cDec, 1); - aT += rStr.copy( nStart[6], nEnd[6]+1-nStart[6]); + OUString aT = OUStringLiteral1(cDec) + rStr.copy( nStart[6], nEnd[6]+1-nStart[6]); rtl_math_ConversionStatus eStatus; double fV = rtl::math::stringToDouble( aT, cDec, 0, &eStatus ); if (eStatus == rtl_math_ConversionStatus_Ok) |