diff options
| author | Tor Lillqvist <tml@collabora.com> | 2017-04-05 13:02:49 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2017-04-05 13:03:42 +0300 |
| commit | 5a7a23539c072b18059714e12c1d3fd8af7e7200 (patch) | |
| tree | 13df3d35243a9eefe824257893409b7abbdc2b1a /sc/source | |
| parent | d1f330cf55a54ccf9b2329798fe7650eb9ee02c3 (diff) | |
Add another FIXME
Change-Id: I60a3978454fb4e6c39b3c35705fd5d503c75860c
Diffstat (limited to 'sc/source')
| -rw-r--r-- | sc/source/core/opencl/formulagroupcl.cxx | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx index 3024f4dc172d..e74ace0f196d 100644 --- a/sc/source/core/opencl/formulagroupcl.cxx +++ b/sc/source/core/opencl/formulagroupcl.cxx @@ -215,6 +215,12 @@ size_t VectorRef::Marshal( cl_kernel k, int argno, int, cl_program ) /// Currently, only the hash is passed. /// TBD(IJSUNG): pass also length and the actual string if there is a /// hash function collision + +/// FIXME: This idea of passing of hashes of uppercased strings into OpenCL code is fairly potent +/// crack. It is hopefully not used at all any more, but noticing that there are string arguments +/// automatically disables use of OpenCL for a formula group. If at some point there are resources +/// to drain the OpenCL swamp, this should go away. + class ConstStringArgument : public DynamicKernelArgument { public: |