diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2019-02-07 12:20:14 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2019-02-11 07:07:55 +0100 |
| commit | 774cc7e0930f223fded1a774e0b71e6b68d48f5f (patch) | |
| tree | afb62a2cec867d44e32f33fe0549ab1cef36d169 /sc/source | |
| parent | 121182bddbce8f14cccdf7db9af8c08867a0912f (diff) | |
tdf#120703 PVS: The check must be before assignment
V560 A part of conditional expression is always false:
nType != m_nDialogType.
Change-Id: I9182ec170aa41516208f97bb8543d348990f046d
Reviewed-on: https://gerrit.libreoffice.org/67488
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sc/source')
| -rw-r--r-- | sc/source/ui/vba/vbaapplication.cxx | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sc/source/ui/vba/vbaapplication.cxx b/sc/source/ui/vba/vbaapplication.cxx index e58b643a076d..9a139117454c 100644 --- a/sc/source/ui/vba/vbaapplication.cxx +++ b/sc/source/ui/vba/vbaapplication.cxx @@ -373,9 +373,11 @@ ScVbaApplication::FileDialog( const uno::Any& DialogType ) sal_Int32 nType = 0; DialogType >>= nType; - m_nDialogType = nType; if( !m_xFileDialog || nType != m_nDialogType ) + { + m_nDialogType = nType; m_xFileDialog = uno::Reference<excel::XFileDialog> ( new ScVbaFileDialog( this, mxContext, nType )); + } return uno::Any( m_xFileDialog ); } |