diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2019-04-16 16:11:39 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2019-05-03 13:46:25 +0200 |
commit | 9a7aa3326d087c79879e435179e359dd76aa5e0a (patch) | |
tree | 444364cd0af0a8741b2ec206e29a8cb5cda1ef57 /sc/source | |
parent | c0038f61aff45595c962911f16dfdef93f41924e (diff) |
The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...
...with latest Clang trunk towards Clang 9. All the no-longer necessary hacks
are made conditional on new NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is
still set for UBSan builds with older Clang on Linux (but which should
eventually be purged).
Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, as building
with UBSan instrumentation can generate references to RTTI symbols from
additional places like outside a dynamic library that used to hide those symbols
by default (but used to not hide them for old UBSan builds thanks to the
-fvisibility-ms-compat hack).
The odr-violation suppressions in solenv/sanitizers/asan-suppressions (which is
not referenced from anywhere in the code base, but meant to be included in an
ASan/UBSan build's ASAN_OPTIONS env var) are also no longer needed when
NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false.
Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a
Reviewed-on: https://gerrit.libreoffice.org/70829
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'sc/source')
-rw-r--r-- | sc/source/ui/inc/dbfunc.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/gridwin.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/preview.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/transobj.hxx | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/sc/source/ui/inc/dbfunc.hxx b/sc/source/ui/inc/dbfunc.hxx index 7e807d9a5ad0..e4db4d500cb0 100644 --- a/sc/source/ui/inc/dbfunc.hxx +++ b/sc/source/ui/inc/dbfunc.hxx @@ -35,7 +35,7 @@ class ScDPSaveData; struct ScDPNumGroupInfo; struct ScSubTotalParam; -class ScDBFunc : public ScViewFunc +class SAL_DLLPUBLIC_RTTI ScDBFunc : public ScViewFunc { private: void GetSelectedMemberList(ScDPUniqueStringSet& rEntries, long& rDimension); diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx index ca2a4ce8308d..cdbd9b83f7a0 100644 --- a/sc/source/ui/inc/gridwin.hxx +++ b/sc/source/ui/inc/gridwin.hxx @@ -82,7 +82,7 @@ struct SpellCallbackInfo; // predefines namespace sdr { namespace overlay { class OverlayObjectList; }} -class ScGridWindow : public vcl::Window, public DropTargetHelper, public DragSourceHelper +class SAL_DLLPUBLIC_RTTI ScGridWindow : public vcl::Window, public DropTargetHelper, public DragSourceHelper { // ScFilterListBox is always used for selection list friend class ScFilterListBox; diff --git a/sc/source/ui/inc/preview.hxx b/sc/source/ui/inc/preview.hxx index f3595722398c..69133b9e9c1b 100644 --- a/sc/source/ui/inc/preview.hxx +++ b/sc/source/ui/inc/preview.hxx @@ -29,7 +29,7 @@ class ScDocShell; class ScPreviewShell; class FmFormView; -class ScPreview : public vcl::Window +class SAL_DLLPUBLIC_RTTI ScPreview : public vcl::Window { private: ScMarkData::MarkedTabsType maSelectedTabs; diff --git a/sc/source/ui/inc/transobj.hxx b/sc/source/ui/inc/transobj.hxx index 211fa8fc7ef2..5b7f405fb55e 100644 --- a/sc/source/ui/inc/transobj.hxx +++ b/sc/source/ui/inc/transobj.hxx @@ -36,7 +36,7 @@ namespace com { namespace sun { namespace star { } }}} -class ScTransferObj : public TransferableHelper +class SAL_DLLPUBLIC_RTTI ScTransferObj : public TransferableHelper { private: ScDocumentUniquePtr m_pDoc; |