diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-11-24 12:58:51 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-11-24 13:51:10 +0100 |
| commit | 3de6d4d3c7b733fde0feef3d77aeb7c4c48724d0 (patch) | |
| tree | d3ab5c4bcde3d67fc40670c03492b33adc5ccaec /sc | |
| parent | da5377c88a26b167e94c030e8c8ac5251497e43b (diff) | |
loplugin:unusedfields make some fields private
this is one of the secondary analyses this plugin performs
Change-Id: I022b9eda994acbd25714025b666194266e896640
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143215
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/inc/autoform.hxx | 3 | ||||
| -rw-r--r-- | sc/inc/chgtrack.hxx | 2 | ||||
| -rw-r--r-- | sc/source/filter/inc/xihelper.hxx | 2 | ||||
| -rw-r--r-- | sc/source/ui/inc/tpsubt.hxx | 29 |
4 files changed, 17 insertions, 19 deletions
diff --git a/sc/inc/autoform.hxx b/sc/inc/autoform.hxx index ee57b435f090..b6facd437e12 100644 --- a/sc/inc/autoform.hxx +++ b/sc/inc/autoform.hxx @@ -72,9 +72,10 @@ struct AutoFormatSwBlob /// Struct with version numbers of the Items struct ScAfVersions : public AutoFormatVersions { -public: +private: AutoFormatSwBlob swVersions; +public: ScAfVersions(); void Load( SvStream& rStream, sal_uInt16 nVer ); diff --git a/sc/inc/chgtrack.hxx b/sc/inc/chgtrack.hxx index dde6beb837f6..24e4f653b165 100644 --- a/sc/inc/chgtrack.hxx +++ b/sc/inc/chgtrack.hxx @@ -104,8 +104,6 @@ class ScChangeActionLinkEntry ScChangeActionLinkEntry( const ScChangeActionLinkEntry& ) = delete; ScChangeActionLinkEntry& operator=( const ScChangeActionLinkEntry& ) = delete; -protected: - ScChangeActionLinkEntry* pNext; ScChangeActionLinkEntry** ppPrev; ScChangeAction* pAction; diff --git a/sc/source/filter/inc/xihelper.hxx b/sc/source/filter/inc/xihelper.hxx index d887df2cd4da..746259e844e4 100644 --- a/sc/source/filter/inc/xihelper.hxx +++ b/sc/source/filter/inc/xihelper.hxx @@ -319,7 +319,7 @@ public: /** Returns the cached Calc error code, if this value has Error type, else 0. */ FormulaError GetScError() const; -protected: +private: typedef ::std::unique_ptr< const ScTokenArray > ScTokenArrayPtr; OUString maStr; /// Cached value is a string. diff --git a/sc/source/ui/inc/tpsubt.hxx b/sc/source/ui/inc/tpsubt.hxx index a6dfc3cb5a02..ecfa2ec18522 100644 --- a/sc/source/ui/inc/tpsubt.hxx +++ b/sc/source/ui/inc/tpsubt.hxx @@ -39,7 +39,20 @@ public: const SfxItemSet& rArgSet ); bool DoFillItemSet ( sal_uInt16 nGroupNo, SfxItemSet& rArgSet ); -protected: +private: + void Init (); + void FillListBoxes (); + static ScSubTotalFunc LbPosToFunc ( sal_uInt16 nPos ); + static sal_uInt16 FuncToLbPos ( ScSubTotalFunc eFunc ); + sal_uInt16 GetFieldSelPos ( SCCOL nField ); + + // Handler ------------------------ + DECL_LINK( SelectListBoxHdl, weld::ComboBox&, void ); + DECL_LINK( SelectTreeListBoxHdl, weld::TreeView&, void ); + DECL_LINK(CheckHdl, const weld::TreeView::iter_col&, void); + DECL_LINK(CheckBoxHdl, weld::Toggleable&, void); + void SelectHdl(const weld::Widget*); + const OUString aStrNone; const OUString aStrColumn; @@ -55,20 +68,6 @@ protected: std::unique_ptr<weld::TreeView> mxLbColumns; std::unique_ptr<weld::TreeView> mxLbFunctions; std::unique_ptr<weld::CheckButton> mxLbSelectAllColumns; - -private: - void Init (); - void FillListBoxes (); - static ScSubTotalFunc LbPosToFunc ( sal_uInt16 nPos ); - static sal_uInt16 FuncToLbPos ( ScSubTotalFunc eFunc ); - sal_uInt16 GetFieldSelPos ( SCCOL nField ); - - // Handler ------------------------ - DECL_LINK( SelectListBoxHdl, weld::ComboBox&, void ); - DECL_LINK( SelectTreeListBoxHdl, weld::TreeView&, void ); - DECL_LINK(CheckHdl, const weld::TreeView::iter_col&, void); - DECL_LINK(CheckBoxHdl, weld::Toggleable&, void); - void SelectHdl(const weld::Widget*); }; class ScTpSubTotalGroup1 final : public ScTpSubTotalGroup |