diff options
author | Caolán McNamara <caolanm@redhat.com> | 2021-04-10 19:52:18 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2021-04-10 21:45:17 +0200 |
commit | 3748fe3e4fc22a400b3120010192b75754e38b17 (patch) | |
tree | 0a7082bae4be7e37601655486d180162ec62029a /sc | |
parent | 5ebccaa07589383653dbd65e58204a82dd3cde09 (diff) |
Related: cid#1474351 Untrusted loop bound
we read 6 bytes per loop but the guard is for 2 bytes available
(which is the correct amount for for the ImportExcel::Mulblank case
but presumably should be 6 for ImportExcel::Mulrk)
Change-Id: Iba9c59c042c6fdd9794107e95c024f1763337186
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113928
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc')
-rw-r--r-- | sc/source/filter/excel/impop.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/filter/excel/impop.cxx b/sc/source/filter/excel/impop.cxx index 91a3605199ad..b461642a13cd 100644 --- a/sc/source/filter/excel/impop.cxx +++ b/sc/source/filter/excel/impop.cxx @@ -861,7 +861,7 @@ void ImportExcel::Mulrk() XclAddress aXclPos; aIn >> aXclPos; - for( XclAddress aCurrXclPos( aXclPos ); (aXclPos.mnCol <= aCurrXclPos.mnCol) && (aIn.GetRecLeft() > 2); ++aCurrXclPos.mnCol ) + for( XclAddress aCurrXclPos( aXclPos ); (aXclPos.mnCol <= aCurrXclPos.mnCol) && (aIn.GetRecLeft() > 6); ++aCurrXclPos.mnCol ) { sal_uInt16 nXF = aIn.ReaduInt16(); sal_Int32 nRkNum = aIn.ReadInt32(); |