diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2021-03-14 14:37:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-03-17 12:30:41 +0100 |
| commit | f1cc5d2229956e3698fd40a4d900fe45e7f8e160 (patch) | |
| tree | 91c6d4dcafd5932c60ff2b46f845053bc9dcdd00 /sc | |
| parent | 32a0b409282554df7d66b7212ddd0fe187f86690 (diff) | |
throw exception for errors in uitest actions
so we abort early when a uitest goes wrong,
instead of letting tests become fragile
because it looks like its passing, but the code
is just accidentally working
Remove code in python uitests that was not actually
doing anything (and now crashes because we throw an exception
for actions that don't mean anything)
Change-Id: I9c52f9fdc06f1c01e9b93b58a5200f9c3684db1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112471
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/qa/uitest/calc_tests/formatCells.py | 8 | ||||
| -rw-r--r-- | sc/qa/uitest/calc_tests6/tdf107267.py | 12 | ||||
| -rw-r--r-- | sc/qa/uitest/calc_tests8/tdf126248.py | 1 |
3 files changed, 0 insertions, 21 deletions
diff --git a/sc/qa/uitest/calc_tests/formatCells.py b/sc/qa/uitest/calc_tests/formatCells.py index 3bb78348fac2..62c1e55c7e9c 100644 --- a/sc/qa/uitest/calc_tests/formatCells.py +++ b/sc/qa/uitest/calc_tests/formatCells.py @@ -41,14 +41,6 @@ class formatCell(UITestCase): props3 = {"TEXT": "English (USA)"} actionProps3 = mkPropertyValues(props3) xlanguagelb.executeAction("SELECT", actionProps3) - #set Number - props = {"TEXT": "Number"} - actionProps = mkPropertyValues(props) - xliststore1.executeAction("SELECT", actionProps) - #set Standard - props2 = {"TEXT": "Standard"} - actionProps2 = mkPropertyValues(props2) - xliststore2.executeAction("SELECT", actionProps2) #other properties xdecimalsed.executeAction("UP", tuple()) xleadzerosed.executeAction("UP", tuple()) diff --git a/sc/qa/uitest/calc_tests6/tdf107267.py b/sc/qa/uitest/calc_tests6/tdf107267.py index ec39c7b4b366..70350a15e127 100644 --- a/sc/qa/uitest/calc_tests6/tdf107267.py +++ b/sc/qa/uitest/calc_tests6/tdf107267.py @@ -40,10 +40,6 @@ class Subtotals(UITestCase): # x6Entry = xTreeList.getChild("5") # xFirstEntry.executeAction("CLICK", tuple()) #use the Max function - xfunctions = xDialog.getChild("functions") - propsF = {"TEXT": "Max"} - actionPropsF = mkPropertyValues(propsF) - xfunctions.executeAction("SELECT", actionPropsF) #= 2nd group =5. Group by "Person Number", select "shipping time" and use the Min function. select_pos(xTabs, "1") @@ -57,10 +53,6 @@ class Subtotals(UITestCase): # x6Entry = xTreeList.getChild("5") # xFirstEntry.executeAction("CLICK", tuple()) #use the Min function - xfunctions = xDialog.getChild("functions") - propsF2 = {"TEXT": "Min"} - actionPropsF2 = mkPropertyValues(propsF2) - xfunctions.executeAction("SELECT", actionPropsF2) #= 3rd group = Group by "Person Number", select "shipping time" and use the Average function. select_pos(xTabs, "2") @@ -74,10 +66,6 @@ class Subtotals(UITestCase): # x6Entry = xTreeList.getChild("5") # xFirstEntry.executeAction("CLICK", tuple()) #use the Average function - xfunctions = xDialog.getChild("functions") - propsF3 = {"TEXT": "Average"} - actionPropsF3 = mkPropertyValues(propsF3) - xfunctions.executeAction("SELECT", actionPropsF3) # 5. Click OK xOKBtn = xDialog.getChild("ok") diff --git a/sc/qa/uitest/calc_tests8/tdf126248.py b/sc/qa/uitest/calc_tests8/tdf126248.py index 967e5c027c3e..f633bf9bcf41 100644 --- a/sc/qa/uitest/calc_tests8/tdf126248.py +++ b/sc/qa/uitest/calc_tests8/tdf126248.py @@ -59,7 +59,6 @@ class tdf126248(UITestCase): self.ui_test.execute_dialog_through_command(".uno:FormatCellDialog") xCellsDlg = self.xUITest.getTopFocusWindow() - select_pos(xCellsDlg, "2") # Get current font names from the Format Cell dialog westFontName = get_state_as_dict(xCellsDlg.getChild("westfontnamelb-cjk"))['Text'] |