diff options
| author | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2018-02-14 02:25:32 +0100 |
|---|---|---|
| committer | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2018-02-14 08:44:44 +0100 |
| commit | 2fd7c18f42710bdaaf3262f4be9f1a706b33d38d (patch) | |
| tree | bfd20a0086cbc6f160f4cb24ae655a0c1cb1e538 /sc | |
| parent | 418dc19266519067ef8f3a2290ae9cb515677d43 (diff) | |
it does not make sense to check for nullptr and then access anyway
Seems to be related to the crashreports with the signatures:
http://crashreport.libreoffice.org/stats/signature/ScTabViewShell::~ScTabViewShell()
http://crashreport.libreoffice.org/stats/signature/ScInputHandler::EnterHandler(ScEnterMode)
Change-Id: Iff22db3988687a52a7596f01facd5bdd12ce4140
Reviewed-on: https://gerrit.libreoffice.org/49694
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/view/tabvwsh4.cxx | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx index 5c0b1e8ab594..55caac70a18f 100644 --- a/sc/source/ui/view/tabvwsh4.cxx +++ b/sc/source/ui/view/tabvwsh4.cxx @@ -1774,10 +1774,12 @@ ScTabViewShell::~ScTabViewShell() // all to NULL, in case the TabView-dtor tries to access them //! (should not really! ??!?!) if (mpInputHandler) + { mpInputHandler->SetDocumentDisposing(true); - // We end edit mode, before destroying the input handler and the edit engine - // and before end listening (in order to call ScTabViewShell::KillEditView()) - mpInputHandler->EnterHandler(); + // We end edit mode, before destroying the input handler and the edit engine + // and before end listening (in order to call ScTabViewShell::KillEditView()) + mpInputHandler->EnterHandler(); + } ScDocShell* pDocSh = GetViewData().GetDocShell(); EndListening(*pDocSh); |