diff options
| author | Eike Rathke <erack@redhat.com> | 2021-10-26 20:48:00 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2021-10-26 21:57:46 +0200 |
| commit | 0f4756601982da8898c9305d6d03f1dc3fa9264a (patch) | |
| tree | 30b149017c43dd9344718c4729b095b7b0ba1236 /sc | |
| parent | 370c9d725a8b026fa6454b7ffb43dc58c868594c (diff) | |
Restore original lcl_ScAddress_Parse_OOo() behaviour detecting external
It's quite unclear why exactly this would even be necessary, but
commit 296baa2fb6dd4150a7855114093a9703cdc18b09
CommitDate: Tue Oct 5 18:14:37 2010 -0400
Ported calc-extref-interpreter-rework-*.diff from ooo-build.
introduced a heuristic whether a reference could be a so far
unrecognized external reference and used String.Erase(n) to strip
a detected possible filename extension starting from the '.' dot
to form a sheet name.
commit 6f93499b881416140c57bc86acdac0ae6e01c314
CommitDate: Tue Oct 8 10:03:08 2013 +0200
convert sc/inc/address.hxx from String to OUString
then changed the String.Erase(n) to OUString::replaceAt(n, 1, "")
which of course does not the same but just removes the '.' dot
character. In that commit this was the only replacement doing
that, others already used a correct OUString::copy().
Just restore the original intention, whyever..
Change-Id: Icc46115f9f25eaf1ed727c233fb1c69942c4b1af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124238
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/core/tool/address.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx index 283f45ee8d0a..b43c9bdfe6f0 100644 --- a/sc/source/core/tool/address.cxx +++ b/sc/source/core/tool/address.cxx @@ -1237,7 +1237,7 @@ static ScRefFlags lcl_ScAddress_Parse_OOo( const sal_Unicode* p, const ScDocumen if (n > 0) { // Extension found. Strip it. - aTab = aTab.replaceAt(n, 1, ""); + aTab = aTab.copy(0, n); bExtDoc = true; } else |