summaryrefslogtreecommitdiff
path: root/sc
diff options
context:
space:
mode:
authorKohei Yoshida <kohei.yoshida@gmail.com>2012-04-27 17:06:46 -0400
committerKohei Yoshida <kohei.yoshida@gmail.com>2012-04-28 00:24:48 -0400
commite3c7b1a0bebb96e51b7c7927367a243c0a2f8402 (patch)
treecdaea3cc177971582b16fa63512e851aa44a0d97 /sc
parentd0af33e87db753d6d171548f75c2e242cde00497 (diff)
Oops I should return empty strings on fail.
Change-Id: I9f04ef448055e14c3d003c977a3c83421838a88b
Diffstat (limited to 'sc')
-rw-r--r--sc/source/ui/unoobj/fielduno.cxx9
1 files changed, 5 insertions, 4 deletions
diff --git a/sc/source/ui/unoobj/fielduno.cxx b/sc/source/ui/unoobj/fielduno.cxx
index 2753fa66a4ef..6bef71a3092c 100644
--- a/sc/source/ui/unoobj/fielduno.cxx
+++ b/sc/source/ui/unoobj/fielduno.cxx
@@ -965,7 +965,7 @@ rtl::OUString SAL_CALL ScEditFieldObj::getPresentation( sal_Bool bShowCommand )
SolarMutexGuard aGuard;
if (!mpEditSource)
- return rtl::OUString("no edit source!!!");
+ return rtl::OUString();
//! Feld-Funktionen muessen an den Forwarder !!!
ScEditEngineDefaulter* pEditEngine = mpEditSource->GetEditEngine();
@@ -975,14 +975,15 @@ rtl::OUString SAL_CALL ScEditFieldObj::getPresentation( sal_Bool bShowCommand )
const SvxFieldData* pField = aTempEngine.FindByPos( aSelection.nStartPara, aSelection.nStartPos, 0 );
OSL_ENSURE(pField,"getPresentation: Feld nicht gefunden");
if (!pField)
- return rtl::OUString("not inserted yet");
+ return rtl::OUString();
switch (meType)
{
case URL:
{
if (pField->GetClassId() != SVX_URLFIELD)
- return rtl::OUString("not url field but url expected");
+ // Not an URL field, but URL is expected.
+ throw uno::RuntimeException();
const SvxURLField* pURL = static_cast<const SvxURLField*>(pField);
return bShowCommand ? pURL->GetURL() : pURL->GetRepresentation();
@@ -991,7 +992,7 @@ rtl::OUString SAL_CALL ScEditFieldObj::getPresentation( sal_Bool bShowCommand )
default:
;
}
- return rtl::OUString("total fail");
+ return rtl::OUString();
}
// XTextContent