replace ODFDefaultVersion usage with ODFSaneDefaultVersion

Compare with ODFSVER_012 mostly works the same, except for places where
namespaces are defined where the ODFSVER_EXTENDED bit should be checked.

Conflicts:
sc/source/filter/xml/XMLExportDataPilot.cxx
xmloff/source/chart/SchXMLExport.cxx

Change-Id: I86469b763bc2f903632976bc9d6ec04d543d705e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108107
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

2 files changed, 25 insertions, 25 deletions

diff --git a/sc/source/filter/xml/XMLExportDataPilot.cxx b/sc/source/filter/xml/XMLExportDataPilot.cxx
index fa88b9bd1966..48be7c33d907 100644
--- a/sc/source/filter/xml/XMLExportDataPilot.cxx
+++ b/sc/source/filter/xml/XMLExportDataPilot.cxx
@@ -432,7 +432,7 @@ void ScXMLExportDataPilot::WriteSubTotals(const ScDPSaveDimension* pDim)
 {
     sal_Int32 nSubTotalCount = pDim->GetSubTotalsCount();
     boost::optional<OUString> pLayoutName;
-    if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+    if (rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
         // Export display names only for 1.2 extended or later.
         pLayoutName = pDim->GetSubtotalName();
 
@@ -464,7 +464,7 @@ void ScXMLExportDataPilot::WriteMembers(const ScDPSaveDimension* pDim)
         {
             rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_NAME, rpMember->GetName());
 
-            if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+            if (rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
             {
                 // Export display names only for ODF 1.2 extended or later.
                 const boost::optional<OUString> & pLayoutName = rpMember->GetLayoutName();
@@ -492,7 +492,7 @@ void ScXMLExportDataPilot::WriteLevels(const ScDPSaveDimension* pDim)
         ::sax::Converter::convertBool(sBuffer, pDim->GetShowEmpty());
         rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SHOW_EMPTY, sBuffer.makeStringAndClear());
     }
-    if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+    if (rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
     {
         OUStringBuffer sBuffer;
         ::sax::Converter::convertBool(sBuffer, pDim->GetRepeatItemLabels());
@@ -675,7 +675,7 @@ void ScXMLExportDataPilot::WriteDimension(const ScDPSaveDimension* pDim, const S
 {
     OUString aSrcDimName = ScDPUtil::getSourceDimensionName(pDim->GetName());
     rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME, aSrcDimName);
-    if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+    if (rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
     {
         // Export display names only for ODF 1.2 extended or later.
         const boost::optional<OUString> & pLayoutName = pDim->GetLayoutName();
@@ -700,7 +700,7 @@ void ScXMLExportDataPilot::WriteDimension(const ScDPSaveDimension* pDim, const S
 
     if (eOrientation == sheet::DataPilotFieldOrientation_PAGE)
     {
-        if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+        if (rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
         {
             rExport.AddAttribute(XML_NAMESPACE_LO_EXT, XML_IGNORE_SELECTED_PAGE, "true");
         }
@@ -813,7 +813,7 @@ void ScXMLExportDataPilot::WriteDataPilots()
         // grand total elements.
 
         const boost::optional<OUString> & pGrandTotalName = pDPSave->GetGrandTotalName();
-        if (pGrandTotalName && rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+        if (pGrandTotalName && rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
         {
             // Use the new data-pilot-grand-total element.
             if (bRowGrand && bColumnGrand)
@@ -832,7 +832,7 @@ void ScXMLExportDataPilot::WriteDataPilots()
         {
             const ScSheetSourceDesc* pSheetSource = (*pDPs)[i].GetSheetDesc();
 
-            if (rExport.getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+            if (rExport.getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
             {
                 if (pSheetSource->HasRangeName())
                     rExport.AddAttribute(
diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx
index 2d16318bac7e..70ddf4de6e2d 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -1697,13 +1697,13 @@ void ScXMLExport::SetBodyAttributes()
         if (!aBuffer.isEmpty())
         {
             AddAttribute(XML_NAMESPACE_TABLE, XML_PROTECTION_KEY, aBuffer.makeStringAndClear());
-            if ( getDefaultVersion() >= SvtSaveOptions::ODFVER_012 )
+            if (getSaneDefaultVersion() >= SvtSaveOptions::ODFSVER_012)
             {
                 if (eHashUsed == PASSHASH_XL)
                 {
                     AddAttribute(XML_NAMESPACE_TABLE, XML_PROTECTION_KEY_DIGEST_ALGORITHM,
                                  ScPassHashHelper::getHashURI(PASSHASH_XL));
-                    if (getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+                    if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                         AddAttribute(XML_NAMESPACE_LO_EXT, XML_PROTECTION_KEY_DIGEST_ALGORITHM_2,
                                 ScPassHashHelper::getHashURI(PASSHASH_SHA1));
                 }
@@ -2820,13 +2820,13 @@ void ScXMLExport::WriteTable(sal_Int32 nTable, const uno::Reference<sheet::XSpre
                 if (!aBuffer.isEmpty())
                 {
                     AddAttribute(XML_NAMESPACE_TABLE, XML_PROTECTION_KEY, aBuffer.makeStringAndClear());
-                    if ( getDefaultVersion() >= SvtSaveOptions::ODFVER_012 )
+                    if (getSaneDefaultVersion() >= SvtSaveOptions::ODFSVER_012)
                     {
                         if (eHashUsed == PASSHASH_XL)
                         {
                             AddAttribute(XML_NAMESPACE_TABLE, XML_PROTECTION_KEY_DIGEST_ALGORITHM,
                                          ScPassHashHelper::getHashURI(PASSHASH_XL));
-                            if (getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+                            if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                                 AddAttribute(XML_NAMESPACE_LO_EXT, XML_PROTECTION_KEY_DIGEST_ALGORITHM_2,
                                         ScPassHashHelper::getHashURI(PASSHASH_SHA1));
                         }
@@ -2855,7 +2855,7 @@ void ScXMLExport::WriteTable(sal_Int32 nTable, const uno::Reference<sheet::XSpre
         AddAttribute( XML_NAMESPACE_TABLE, XML_PRINT, XML_FALSE);
     SvXMLElementExport aElemT(*this, sElemTab, true, true);
 
-    if (pProtect && pProtect->isProtected() && getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+    if (pProtect && pProtect->isProtected() && getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
     {
         if (pProtect->isOptionEnabled(ScTableProtection::SELECT_LOCKED_CELLS))
             AddAttribute(XML_NAMESPACE_LO_EXT, XML_SELECT_PROTECTED_CELLS, XML_TRUE);
@@ -2881,7 +2881,7 @@ void ScXMLExport::WriteTable(sal_Int32 nTable, const uno::Reference<sheet::XSpre
     CheckAttrList();
 
     if ( pDoc && pDoc->GetSheetEvents( static_cast<SCTAB>(nTable) ) &&
-         getDefaultVersion() >= SvtSaveOptions::ODFVER_012 )
+        getSaneDefaultVersion() >= SvtSaveOptions::ODFSVER_012)
     {
         // store sheet events
         uno::Reference<document::XEventsSupplier> xSupplier(xTable, uno::UNO_QUERY);
@@ -2977,7 +2977,7 @@ void ScXMLExport::WriteTable(sal_Int32 nTable, const uno::Reference<sheet::XSpre
             WriteNamedRange(pRangeName);
         }
 
-        if(getDefaultVersion() > SvtSaveOptions::ODFVER_012)
+        if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
         {
             //export new conditional format information
             ExportConditionalFormat(nTable);
@@ -3134,7 +3134,7 @@ void ScXMLExport::WriteCell(ScMyCell& aCell, sal_Int32 nEqualCellCount)
             {
                 GetNumberFormatAttributesExportHelper()->SetNumberFormatAttributes(
                     aCell.nNumberFormat, aCell.maBaseCell.mfValue);
-                if( getDefaultVersion() > SvtSaveOptions::ODFVER_012 )
+                if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                     GetNumberFormatAttributesExportHelper()->SetNumberFormatAttributes(
                             aCell.nNumberFormat, aCell.maBaseCell.mfValue, false, XML_NAMESPACE_CALC_EXT, false);
             }
@@ -3145,7 +3145,7 @@ void ScXMLExport::WriteCell(ScMyCell& aCell, sal_Int32 nEqualCellCount)
                 OUString sCellString = aCell.maBaseCell.getString(pDoc);
                 GetNumberFormatAttributesExportHelper()->SetNumberFormatAttributes(
                         sCellString, sFormattedString);
-                if( getDefaultVersion() > SvtSaveOptions::ODFVER_012 )
+                if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                     GetNumberFormatAttributesExportHelper()->SetNumberFormatAttributes(
                             sCellString, sFormattedString, false, XML_NAMESPACE_CALC_EXT);
             }
@@ -3181,7 +3181,7 @@ void ScXMLExport::WriteCell(ScMyCell& aCell, sal_Int32 nEqualCellCount)
                     {
                         AddAttribute(sAttrValueType, XML_STRING);
                         AddAttribute(sAttrStringValue, aCell.maBaseCell.getString(pDoc));
-                        if( getDefaultVersion() > SvtSaveOptions::ODFVER_012 )
+                        if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                         {
                             //export calcext:value-type="error"
                             AddAttribute(XML_NAMESPACE_CALC_EXT,XML_VALUE_TYPE, OUString("error"));
@@ -3196,7 +3196,7 @@ void ScXMLExport::WriteCell(ScMyCell& aCell, sal_Int32 nEqualCellCount)
                         {
                             GetNumberFormatAttributesExportHelper()->SetNumberFormatAttributes(
                                     aCell.nNumberFormat, pDoc->GetValue(aCell.maCellAddress));
-                            if( getDefaultVersion() > SvtSaveOptions::ODFVER_012 )
+                            if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                             {
                                 GetNumberFormatAttributesExportHelper()->SetNumberFormatAttributes(
                                         aCell.nNumberFormat, pDoc->GetValue(aCell.maCellAddress), false, XML_NAMESPACE_CALC_EXT, false );
@@ -3209,7 +3209,7 @@ void ScXMLExport::WriteCell(ScMyCell& aCell, sal_Int32 nEqualCellCount)
                         {
                             AddAttribute(sAttrValueType, XML_STRING);
                             AddAttribute(sAttrStringValue, aCell.maBaseCell.getString(pDoc));
-                            if( getDefaultVersion() > SvtSaveOptions::ODFVER_012 )
+                            if (getSaneDefaultVersion() > SvtSaveOptions::ODFSVER_012)
                             {
                                 AddAttribute(XML_NAMESPACE_CALC_EXT,XML_VALUE_TYPE, XML_STRING);
                             }
@@ -3994,7 +3994,7 @@ void ScXMLExport::WriteExternalDataMapping()
     if (!pDoc)
         return;
 
-    if (getDefaultVersion() <= SvtSaveOptions::ODFVER_012)
+    if (getSaneDefaultVersion() <= SvtSaveOptions::ODFSVER_012)
         // Export this only for 1.2 extended and above.
         return;
 
@@ -4327,7 +4327,7 @@ void ScXMLExport::WriteDataStream()
         // Export this only in experimental mode.
         return;
 
-    if (getDefaultVersion() <= SvtSaveOptions::ODFVER_012)
+    if (getSaneDefaultVersion() <= SvtSaveOptions::ODFSVER_012)
         // Export this only for 1.2 extended and above.
         return;
 
@@ -5242,7 +5242,7 @@ ErrCode ScXMLExport::exportDoc( enum XMLTokenEnum eClass )
 
             // sheet events use officeooo namespace
             if( (getExportFlags() & SvXMLExportFlags::CONTENT) &&
-                getDefaultVersion() >= SvtSaveOptions::ODFVER_012 )
+                getSaneDefaultVersion() >= SvtSaveOptions::ODFSVER_012)
             {
                 bool bAnySheetEvents = false;
                 SCTAB nTabCount = pDoc->GetTableCount();
@@ -5276,12 +5276,12 @@ void SAL_CALL ScXMLExport::setSourceDocument( const uno::Reference<lang::XCompon
 
     // Set the document's storage grammar corresponding to the ODF version that
     // is to be written.
-    SvtSaveOptions::ODFDefaultVersion meODFDefaultVersion = getDefaultVersion();
+    SvtSaveOptions::ODFSaneDefaultVersion meODFDefaultVersion = getSaneDefaultVersion();
     switch (meODFDefaultVersion)
     {
         // ODF 1.0 and 1.1 use GRAM_PODF, everything later or unspecified GRAM_ODFF
-        case SvtSaveOptions::ODFVER_010:
-        case SvtSaveOptions::ODFVER_011:
+        case SvtSaveOptions::ODFSVER_010:
+        case SvtSaveOptions::ODFSVER_011:
             pDoc->SetStorageGrammar( formula::FormulaGrammar::GRAM_PODF);
             break;
         default: