summaryrefslogtreecommitdiff
path: root/sc
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2016-07-19 10:49:48 +0200
committerStephan Bergmann <sbergman@redhat.com>2016-07-19 10:49:48 +0200
commit58806ee799072776e04d49d95dcba525575f9ce7 (patch)
tree8ba475a62b15c4c8415c896151a60ffc5482d25e /sc
parenta293ff34143f90c6836591fc1f4aa419342c5e1b (diff)
clang-tidy performance-unnecessary-value-param in sc
Change-Id: I1941c050a385e3a1020c5d2495471f5805c4c180
Diffstat (limited to 'sc')
-rw-r--r--sc/inc/externalrefmgr.hxx4
-rw-r--r--sc/inc/tablink.hxx2
-rw-r--r--sc/qa/unit/filters-test.cxx4
-rw-r--r--sc/qa/unit/helper/qahelper.cxx2
-rw-r--r--sc/qa/unit/helper/qahelper.hxx2
-rw-r--r--sc/qa/unit/helper/xpath.cxx2
-rw-r--r--sc/qa/unit/helper/xpath.hxx2
-rw-r--r--sc/qa/unit/ucalc_formula.cxx2
-rw-r--r--sc/source/filter/excel/xechart.cxx6
-rw-r--r--sc/source/filter/excel/xeescher.cxx2
-rw-r--r--sc/source/filter/excel/xelink.cxx12
-rw-r--r--sc/source/filter/excel/xestream.cxx4
-rw-r--r--sc/source/filter/excel/xestyle.cxx4
-rw-r--r--sc/source/filter/excel/xetable.cxx8
-rw-r--r--sc/source/filter/excel/xichart.cxx6
-rw-r--r--sc/source/filter/excel/xiescher.cxx4
-rw-r--r--sc/source/filter/excel/xistream.cxx2
-rw-r--r--sc/source/filter/excel/xlroot.cxx4
-rw-r--r--sc/source/filter/ftools/ftools.cxx8
-rw-r--r--sc/source/filter/inc/condformatbuffer.hxx2
-rw-r--r--sc/source/filter/inc/ftools.hxx8
-rw-r--r--sc/source/filter/inc/stylesbuffer.hxx2
-rw-r--r--sc/source/filter/inc/xechart.hxx2
-rw-r--r--sc/source/filter/inc/xestream.hxx4
-rw-r--r--sc/source/filter/inc/xestyle.hxx4
-rw-r--r--sc/source/filter/inc/xetable.hxx6
-rw-r--r--sc/source/filter/inc/xichart.hxx8
-rw-r--r--sc/source/filter/inc/xiescher.hxx4
-rw-r--r--sc/source/filter/inc/xistream.hxx2
-rw-r--r--sc/source/filter/inc/xlroot.hxx4
-rw-r--r--sc/source/filter/oox/condformatbuffer.cxx2
-rw-r--r--sc/source/filter/oox/stylesbuffer.cxx2
-rw-r--r--sc/source/filter/oox/workbookfragment.cxx2
-rw-r--r--sc/source/filter/xml/xmlexprt.cxx2
-rw-r--r--sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx4
-rw-r--r--sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx2
-rw-r--r--sc/source/ui/app/inputhdl.cxx4
-rw-r--r--sc/source/ui/dbgui/csvsplits.cxx2
-rw-r--r--sc/source/ui/docshell/externalrefmgr.cxx4
-rw-r--r--sc/source/ui/docshell/tablink.cxx2
-rw-r--r--sc/source/ui/inc/StatisticsInputOutputDialog.hxx4
-rw-r--r--sc/source/ui/inc/TableFillingAndNavigationTools.hxx2
-rw-r--r--sc/source/ui/inc/csvsplits.hxx2
-rw-r--r--sc/source/ui/sidebar/CellBorderUpdater.cxx2
-rw-r--r--sc/source/ui/sidebar/CellBorderUpdater.hxx2
-rw-r--r--sc/source/ui/uitest/uiobject.cxx6
-rw-r--r--sc/source/ui/vba/vbainterior.cxx2
-rw-r--r--sc/source/ui/vba/vbainterior.hxx2
48 files changed, 87 insertions, 87 deletions
diff --git a/sc/inc/externalrefmgr.hxx b/sc/inc/externalrefmgr.hxx
index b9d1394a460a..cb1a0d8a8ff6 100644
--- a/sc/inc/externalrefmgr.hxx
+++ b/sc/inc/externalrefmgr.hxx
@@ -153,7 +153,7 @@ public:
* false _only when_ adding a range of cell
* values, for performance reasons.
*/
- SC_DLLPUBLIC void setCell(SCCOL nCol, SCROW nRow, TokenRef pToken, sal_uLong nFmtIndex = 0, bool bSetCacheRange = true);
+ SC_DLLPUBLIC void setCell(SCCOL nCol, SCROW nRow, TokenRef const & pToken, sal_uLong nFmtIndex = 0, bool bSetCacheRange = true);
SC_DLLPUBLIC TokenRef getCell(SCCOL nCol, SCROW nRow, sal_uInt32* pnFmtIndex = nullptr) const;
bool hasRow( SCROW nRow ) const;
/** Set/clear referenced status flag only if current status is not
@@ -237,7 +237,7 @@ public:
void setRangeName(sal_uInt16 nFileId, const OUString& rName);
void setCellData(sal_uInt16 nFileId, const OUString& rTabName,
- SCCOL nCol, SCROW nRow, TokenRef pToken, sal_uLong nFmtIndex);
+ SCCOL nCol, SCROW nRow, TokenRef const & pToken, sal_uLong nFmtIndex);
struct SingleRangeData
{
diff --git a/sc/inc/tablink.hxx b/sc/inc/tablink.hxx
index f50ad00765cd..31f005bb6f59 100644
--- a/sc/inc/tablink.hxx
+++ b/sc/inc/tablink.hxx
@@ -95,7 +95,7 @@ public:
/** Create SfxMedium for stream read with SfxFilter and filter options set
at the medium's SfxItemSet.
*/
- static SfxMedium* CreateMedium( const OUString& rFileName, std::shared_ptr<const SfxFilter> pFilter, const OUString& rOptions );
+ static SfxMedium* CreateMedium( const OUString& rFileName, std::shared_ptr<const SfxFilter> const & pFilter, const OUString& rOptions );
static OUString GetOptions( SfxMedium& rMedium );
diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx
index a8a6d7f47b7c..f383c681e6b3 100644
--- a/sc/qa/unit/filters-test.cxx
+++ b/sc/qa/unit/filters-test.cxx
@@ -82,7 +82,7 @@ public:
void testEnhancedProtectionXLSX();
void testSortWithSharedFormulasODS();
void testSortWithSheetExternalReferencesODS();
- void testSortWithSheetExternalReferencesODS_Impl( ScDocShellRef xDocShRef, SCROW nRow1, SCROW nRow2,
+ void testSortWithSheetExternalReferencesODS_Impl( ScDocShellRef const & xDocShRef, SCROW nRow1, SCROW nRow2,
bool bCheckRelativeInSheet );
CPPUNIT_TEST_SUITE(ScFiltersTest);
@@ -700,7 +700,7 @@ void ScFiltersTest::testSortWithSheetExternalReferencesODS()
xDocSh->DoClose();
}
-void ScFiltersTest::testSortWithSheetExternalReferencesODS_Impl( ScDocShellRef xDocSh, SCROW nRow1, SCROW nRow2,
+void ScFiltersTest::testSortWithSheetExternalReferencesODS_Impl( ScDocShellRef const & xDocSh, SCROW nRow1, SCROW nRow2,
bool bCheckRelativeInSheet )
{
ScDocument& rDoc = xDocSh->GetDocument();
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index ac61dc2f9955..e3493a18652a 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -747,7 +747,7 @@ std::string to_std_string(const OUString& rStr)
}
-void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* expected, const char* msg, CppUnit::SourceLine sourceLine)
+void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* expected, const char* msg, CppUnit::SourceLine const & sourceLine)
{
ScTokenArray* pCode = getTokens(rDoc, rPos);
if (!pCode)
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index 9929c6c800c1..dc4afd19bf53 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -249,7 +249,7 @@ public:
CPPUNIT_ASSERT_EQUAL( static_cast<type>(expected), static_cast<type>(result) );
SCQAHELPER_DLLPUBLIC void checkFormula(ScDocument& rDoc, const ScAddress& rPos,
- const char* expected, const char* msg, CppUnit::SourceLine sourceLine);
+ const char* expected, const char* msg, CppUnit::SourceLine const & sourceLine);
#define ASSERT_FORMULA_EQUAL(doc, pos, expected, msg) \
checkFormula(doc, pos, expected, msg, CPPUNIT_SOURCELINE())
diff --git a/sc/qa/unit/helper/xpath.cxx b/sc/qa/unit/helper/xpath.cxx
index 2117b749b326..2d047b60bf61 100644
--- a/sc/qa/unit/helper/xpath.cxx
+++ b/sc/qa/unit/helper/xpath.cxx
@@ -25,7 +25,7 @@ xmlDocPtr XPathHelper::parseExport(ScDocShell& rShell, uno::Reference<lang::XMul
return parseExport(pTempFile, xSFactory, rFile);
}
-xmlDocPtr XPathHelper::parseExport(std::shared_ptr<utl::TempFile> pTempFile, uno::Reference<lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile)
+xmlDocPtr XPathHelper::parseExport(std::shared_ptr<utl::TempFile> const & pTempFile, uno::Reference<lang::XMultiServiceFactory> const & xSFactory, const OUString& rFile)
{
// Read the XML stream we're interested in.
uno::Reference<packages::zip::XZipFileAccess2> xNameAccess = packages::zip::ZipFileAccess::createWithURL(comphelper::getComponentContext(xSFactory), pTempFile->GetURL());
diff --git a/sc/qa/unit/helper/xpath.hxx b/sc/qa/unit/helper/xpath.hxx
index 91a81e1253c3..86d1d279576e 100644
--- a/sc/qa/unit/helper/xpath.hxx
+++ b/sc/qa/unit/helper/xpath.hxx
@@ -53,7 +53,7 @@ namespace XPathHelper
* Should be used when the same exported file is used for testing different files in
* the same zip file.
*/
- SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr<utl::TempFile> pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory,
+ SCQAHELPER_DLLPUBLIC xmlDocPtr parseExport(std::shared_ptr<utl::TempFile> const & pTempFile, uno::Reference< lang::XMultiServiceFactory> const & xSFactory,
const OUString& rFile);
}
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 14b292933606..25f42b8d8bd4 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -7054,7 +7054,7 @@ public:
{}
void operator() ( SCCOL nColumn, const OUString& rFormula,
- std::function<double(SCROW )> lExpected ) const
+ std::function<double(SCROW )> const & lExpected ) const
{
ScDocument aClipDoc(SCDOCMODE_CLIP);
ScMarkData aMark;
diff --git a/sc/source/filter/excel/xechart.cxx b/sc/source/filter/excel/xechart.cxx
index d6eee66871c6..c2860104703b 100644
--- a/sc/source/filter/excel/xechart.cxx
+++ b/sc/source/filter/excel/xechart.cxx
@@ -126,7 +126,7 @@ XclExpStream& operator<<( XclExpStream& rStrm, const XclChRectangle& rRect )
return rStrm << rRect.mnX << rRect.mnY << rRect.mnWidth << rRect.mnHeight;
}
-inline void lclSaveRecord( XclExpStream& rStrm, XclExpRecordRef xRec )
+inline void lclSaveRecord( XclExpStream& rStrm, XclExpRecordRef const & xRec )
{
if( xRec )
xRec->Save( rStrm );
@@ -134,7 +134,7 @@ inline void lclSaveRecord( XclExpStream& rStrm, XclExpRecordRef xRec )
/** Saves the passed record (group) together with a leading value record. */
template< typename Type >
-void lclSaveRecord( XclExpStream& rStrm, XclExpRecordRef xRec, sal_uInt16 nRecId, Type nValue )
+void lclSaveRecord( XclExpStream& rStrm, XclExpRecordRef const & xRec, sal_uInt16 nRecId, Type nValue )
{
if( xRec )
{
@@ -3391,7 +3391,7 @@ void XclExpChChart::RemoveLastSeries()
maSeries.RemoveRecord( maSeries.GetSize() - 1 );
}
-void XclExpChChart::SetDataLabel( XclExpChTextRef xText )
+void XclExpChChart::SetDataLabel( XclExpChTextRef const & xText )
{
if( xText )
maLabels.AppendRecord( xText );
diff --git a/sc/source/filter/excel/xeescher.cxx b/sc/source/filter/excel/xeescher.cxx
index 47334e4751b4..b9bb3ad3455b 100644
--- a/sc/source/filter/excel/xeescher.cxx
+++ b/sc/source/filter/excel/xeescher.cxx
@@ -136,7 +136,7 @@ const char *ToVertAlign( SdrTextVertAdjust eAdjust )
}
}
-void lcl_WriteAnchorVertex( sax_fastparser::FSHelperPtr rComments, Rectangle &aRect )
+void lcl_WriteAnchorVertex( sax_fastparser::FSHelperPtr const & rComments, Rectangle &aRect )
{
rComments->startElement( FSNS( XML_xdr, XML_col ), FSEND );
rComments->writeEscaped( OUString::number( aRect.Left() ) );
diff --git a/sc/source/filter/excel/xelink.cxx b/sc/source/filter/excel/xelink.cxx
index 4b91c2a9b43b..54ae5516ce9f 100644
--- a/sc/source/filter/excel/xelink.cxx
+++ b/sc/source/filter/excel/xelink.cxx
@@ -314,7 +314,7 @@ public:
sal_uInt16 GetTabCount() const;
/** Inserts a new sheet name into the SUPBOOK and returns the SUPBOOK internal sheet index. */
- sal_uInt16 InsertTabName( const OUString& rTabName, ScExternalRefCache::TableTypeRef xCacheTable );
+ sal_uInt16 InsertTabName( const OUString& rTabName, ScExternalRefCache::TableTypeRef const & xCacheTable );
/** Finds or inserts an EXTERNNAME record for add-ins.
@return The 1-based EXTERNNAME record index; or 0, if the record list is full. */
sal_uInt16 InsertAddIn( const OUString& rName );
@@ -468,7 +468,7 @@ private:
/** Appends a new SUPBOOK to the list.
@return The list index of the SUPBOOK record. */
- sal_uInt16 Append( XclExpSupbookRef xSupbook );
+ sal_uInt16 Append( XclExpSupbookRef const & xSupbook );
private:
XclExpSupbookList maSupbookList; /// List of all SUPBOOK records.
@@ -582,7 +582,7 @@ private:
sal_uInt16 GetExtSheetCount() const;
/** Appends an internal EXTERNSHEET record and returns the one-based index. */
- sal_uInt16 AppendInternal( XclExpExtSheetRef xExtSheet );
+ sal_uInt16 AppendInternal( XclExpExtSheetRef const & xExtSheet );
/** Creates all EXTERNSHEET records for internal sheets on first call. */
void CreateInternal();
@@ -1614,7 +1614,7 @@ sal_uInt16 XclExpSupbook::GetTabCount() const
return ulimit_cast<sal_uInt16>(maXctList.GetSize());
}
-sal_uInt16 XclExpSupbook::InsertTabName( const OUString& rTabName, ScExternalRefCache::TableTypeRef xCacheTable )
+sal_uInt16 XclExpSupbook::InsertTabName( const OUString& rTabName, ScExternalRefCache::TableTypeRef const & xCacheTable )
{
OSL_ENSURE( meType == EXC_SBTYPE_EXTERN, "XclExpSupbook::InsertTabName - don't insert sheet names here" );
sal_uInt16 nSBTab = ulimit_cast< sal_uInt16 >( maXctList.GetSize() );
@@ -2160,7 +2160,7 @@ bool XclExpSupbookBuffer::GetSupbookDde( XclExpSupbookRef& rxSupbook,
return false;
}
-sal_uInt16 XclExpSupbookBuffer::Append( XclExpSupbookRef xSupbook )
+sal_uInt16 XclExpSupbookBuffer::Append( XclExpSupbookRef const & xSupbook )
{
maSupbookList.AppendRecord( xSupbook );
return ulimit_cast< sal_uInt16 >( maSupbookList.GetSize() - 1 );
@@ -2282,7 +2282,7 @@ sal_uInt16 XclExpLinkManagerImpl5::GetExtSheetCount() const
return static_cast< sal_uInt16 >( maExtSheetList.GetSize() );
}
-sal_uInt16 XclExpLinkManagerImpl5::AppendInternal( XclExpExtSheetRef xExtSheet )
+sal_uInt16 XclExpLinkManagerImpl5::AppendInternal( XclExpExtSheetRef const & xExtSheet )
{
if( GetExtSheetCount() < 0x7FFF )
{
diff --git a/sc/source/filter/excel/xestream.cxx b/sc/source/filter/excel/xestream.cxx
index 99117a8ee119..933227a116a9 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -341,7 +341,7 @@ void XclExpStream::WriteCharBuffer( const ScfUInt8Vec& rBuffer )
Write( &rBuffer[ 0 ], rBuffer.size() );
}
-void XclExpStream::SetEncrypter( XclExpEncrypterRef xEncrypter )
+void XclExpStream::SetEncrypter( XclExpEncrypterRef const & xEncrypter )
{
mxEncrypter = xEncrypter;
}
@@ -942,7 +942,7 @@ sax_fastparser::FSHelperPtr& XclExpXmlStream::GetCurrentStream()
return maStreams.top();
}
-void XclExpXmlStream::PushStream( sax_fastparser::FSHelperPtr aStream )
+void XclExpXmlStream::PushStream( sax_fastparser::FSHelperPtr const & aStream )
{
maStreams.push( aStream );
}
diff --git a/sc/source/filter/excel/xestyle.cxx b/sc/source/filter/excel/xestyle.cxx
index 9ad0988d8d7a..a301abdc43dc 100644
--- a/sc/source/filter/excel/xestyle.cxx
+++ b/sc/source/filter/excel/xestyle.cxx
@@ -2847,7 +2847,7 @@ void XclExpXFBuffer::InsertUserStyles()
InsertStyleXF( *pStyleSheet );
}
-sal_uInt32 XclExpXFBuffer::AppendBuiltInXF( XclExpXFRef xXF, sal_uInt8 nStyleId, sal_uInt8 nLevel )
+sal_uInt32 XclExpXFBuffer::AppendBuiltInXF( XclExpXFRef const & xXF, sal_uInt8 nStyleId, sal_uInt8 nLevel )
{
sal_uInt32 nXFId = static_cast< sal_uInt32 >( maXFList.GetSize() );
maXFList.AppendRecord( xXF );
@@ -2858,7 +2858,7 @@ sal_uInt32 XclExpXFBuffer::AppendBuiltInXF( XclExpXFRef xXF, sal_uInt8 nStyleId,
return nXFId;
}
-sal_uInt32 XclExpXFBuffer::AppendBuiltInXFWithStyle( XclExpXFRef xXF, sal_uInt8 nStyleId, sal_uInt8 nLevel )
+sal_uInt32 XclExpXFBuffer::AppendBuiltInXFWithStyle( XclExpXFRef const & xXF, sal_uInt8 nStyleId, sal_uInt8 nLevel )
{
sal_uInt32 nXFId = AppendBuiltInXF( xXF, nStyleId, nLevel );
maStyleList.AppendNewRecord( new XclExpStyle( nXFId, nStyleId, nLevel ) );
diff --git a/sc/source/filter/excel/xetable.cxx b/sc/source/filter/excel/xetable.cxx
index f7cba244e577..b88021fb089a 100644
--- a/sc/source/filter/excel/xetable.cxx
+++ b/sc/source/filter/excel/xetable.cxx
@@ -717,7 +717,7 @@ bool XclExpLabelCell::IsMultiLineText() const
}
void XclExpLabelCell::Init( const XclExpRoot& rRoot,
- const ScPatternAttr* pPattern, XclExpStringRef xText )
+ const ScPatternAttr* pPattern, XclExpStringRef const & xText )
{
OSL_ENSURE( xText && xText->Len(), "XclExpLabelCell::XclExpLabelCell - empty string passed" );
mxText = xText;
@@ -1842,7 +1842,7 @@ XclExpRow::XclExpRow( const XclExpRoot& rRoot, sal_uInt32 nXclRow,
rProgress.Progress();
}
-void XclExpRow::AppendCell( XclExpCellRef xCell, bool bIsMergedBase )
+void XclExpRow::AppendCell( XclExpCellRef const & xCell, bool bIsMergedBase )
{
OSL_ENSURE( !mbAlwaysEmpty, "XclExpRow::AppendCell - row is marked to be always empty" );
// try to merge with last existing cell
@@ -2098,7 +2098,7 @@ XclExpRowBuffer::XclExpRowBuffer( const XclExpRoot& rRoot ) :
{
}
-void XclExpRowBuffer::AppendCell( XclExpCellRef xCell, bool bIsMergedBase )
+void XclExpRowBuffer::AppendCell( XclExpCellRef const & xCell, bool bIsMergedBase )
{
OSL_ENSURE( xCell, "XclExpRowBuffer::AppendCell - missing cell" );
GetOrCreateRow( xCell->GetXclRow(), false ).AppendCell( xCell, bIsMergedBase );
@@ -2116,7 +2116,7 @@ class RowFinalizeTask : public comphelper::ThreadTask
const ScfUInt16Vec& mrColXFIndexes;
std::vector< XclExpRow * > maRows;
public:
- RowFinalizeTask( const std::shared_ptr<comphelper::ThreadTaskTag> pTag,
+ RowFinalizeTask( const std::shared_ptr<comphelper::ThreadTaskTag> & pTag,
const ScfUInt16Vec& rColXFIndexes,
bool bProgress ) :
comphelper::ThreadTask( pTag ),
diff --git a/sc/source/filter/excel/xichart.cxx b/sc/source/filter/excel/xichart.cxx
index d463b4f85bb8..f160e2b2e490 100644
--- a/sc/source/filter/excel/xichart.cxx
+++ b/sc/source/filter/excel/xichart.cxx
@@ -1678,7 +1678,7 @@ void XclImpChSerErrorBar::ReadChSerErrorBar( XclImpStream& rStrm )
maData.mnValueCount = rStrm.ReaduInt16();
}
-void XclImpChSerErrorBar::SetSeriesData( XclImpChSourceLinkRef xValueLink, XclImpChDataFormatRef xDataFmt )
+void XclImpChSerErrorBar::SetSeriesData( XclImpChSourceLinkRef const & xValueLink, XclImpChDataFormatRef const & xDataFmt )
{
mxValueLink = xValueLink;
mxDataFmt = xDataFmt;
@@ -2699,7 +2699,7 @@ void XclImpChTypeGroup::Finalize()
mxGroupFmt->UpdateGroupFormat( maTypeInfo );
}
-void XclImpChTypeGroup::AddSeries( XclImpChSeriesRef xSeries )
+void XclImpChTypeGroup::AddSeries( XclImpChSeriesRef const & xSeries )
{
if( xSeries )
maSeries.push_back( xSeries );
@@ -3723,7 +3723,7 @@ Reference< XCoordinateSystem > XclImpChAxesSet::CreateCoordSystem( Reference< XD
}
void XclImpChAxesSet::ConvertAxis(
- XclImpChAxisRef xChAxis, XclImpChTextRef xChAxisTitle,
+ XclImpChAxisRef const & xChAxis, XclImpChTextRef const & xChAxisTitle,
Reference< XCoordinateSystem > const & xCoordSystem, const XclImpChAxis* pCrossingAxis ) const
{
if( xChAxis )
diff --git a/sc/source/filter/excel/xiescher.cxx b/sc/source/filter/excel/xiescher.cxx
index aa32a829c74f..52a5ab558153 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -943,7 +943,7 @@ void XclImpDrawObjBase::ImplReadObj8( XclImpStream& rStrm )
}
}
-void XclImpDrawObjVector::InsertGrouped( XclImpDrawObjRef xDrawObj )
+void XclImpDrawObjVector::InsertGrouped( XclImpDrawObjRef const & xDrawObj )
{
if( !mObjs.empty() )
if( XclImpGroupObj* pGroupObj = dynamic_cast< XclImpGroupObj* >( mObjs.back().get() ) )
@@ -972,7 +972,7 @@ XclImpGroupObj::XclImpGroupObj( const XclImpRoot& rRoot ) :
{
}
-bool XclImpGroupObj::TryInsert( XclImpDrawObjRef xDrawObj )
+bool XclImpGroupObj::TryInsert( XclImpDrawObjRef const & xDrawObj )
{
if( xDrawObj->GetObjId() == mnFirstUngrouped )
return false;
diff --git a/sc/source/filter/excel/xistream.cxx b/sc/source/filter/excel/xistream.cxx
index 51802a9fe091..a2be5dadf7c4 100644
--- a/sc/source/filter/excel/xistream.cxx
+++ b/sc/source/filter/excel/xistream.cxx
@@ -475,7 +475,7 @@ void XclImpStream::RewindRecord()
mbValid = mbValidRec = false;
}
-void XclImpStream::SetDecrypter( XclImpDecrypterRef xDecrypter )
+void XclImpStream::SetDecrypter( XclImpDecrypterRef const & xDecrypter )
{
mxDecrypter = xDecrypter;
EnableDecryption();
diff --git a/sc/source/filter/excel/xlroot.cxx b/sc/source/filter/excel/xlroot.cxx
index 80a9a63f033c..55998aae9b2d 100644
--- a/sc/source/filter/excel/xlroot.cxx
+++ b/sc/source/filter/excel/xlroot.cxx
@@ -238,7 +238,7 @@ bool XclRoot::HasVbaStorage() const
return xRootStrg.Is() && xRootStrg->IsContained( EXC_STORAGE_VBA_PROJECT );
}
-tools::SvRef<SotStorage> XclRoot::OpenStorage( tools::SvRef<SotStorage> xStrg, const OUString& rStrgName ) const
+tools::SvRef<SotStorage> XclRoot::OpenStorage( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrgName ) const
{
return mrData.mbExport ?
ScfTools::OpenStorageWrite( xStrg, rStrgName ) :
@@ -250,7 +250,7 @@ tools::SvRef<SotStorage> XclRoot::OpenStorage( const OUString& rStrgName ) const
return OpenStorage( GetRootStorage(), rStrgName );
}
-tools::SvRef<SotStorageStream> XclRoot::OpenStream( tools::SvRef<SotStorage> xStrg, const OUString& rStrmName ) const
+tools::SvRef<SotStorageStream> XclRoot::OpenStream( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrmName ) const
{
return mrData.mbExport ?
ScfTools::OpenStorageStreamWrite( xStrg, rStrmName ) :
diff --git a/sc/source/filter/ftools/ftools.cxx b/sc/source/filter/ftools/ftools.cxx
index 4a2aafd38a4c..d17e48a09d36 100644
--- a/sc/source/filter/ftools/ftools.cxx
+++ b/sc/source/filter/ftools/ftools.cxx
@@ -165,7 +165,7 @@ OUString ScfTools::ConvertToScDefinedName(const OUString& rName )
// *** streams and storages *** -----------------------------------------------
-tools::SvRef<SotStorage> ScfTools::OpenStorageRead( tools::SvRef<SotStorage> xStrg, const OUString& rStrgName )
+tools::SvRef<SotStorage> ScfTools::OpenStorageRead( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrgName )
{
tools::SvRef<SotStorage> xSubStrg;
if( xStrg.Is() && xStrg->IsContained( rStrgName ) )
@@ -173,7 +173,7 @@ tools::SvRef<SotStorage> ScfTools::OpenStorageRead( tools::SvRef<SotStorage> xSt
return xSubStrg;
}
-tools::SvRef<SotStorage> ScfTools::OpenStorageWrite( tools::SvRef<SotStorage> xStrg, const OUString& rStrgName )
+tools::SvRef<SotStorage> ScfTools::OpenStorageWrite( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrgName )
{
tools::SvRef<SotStorage> xSubStrg;
if( xStrg.Is() )
@@ -181,7 +181,7 @@ tools::SvRef<SotStorage> ScfTools::OpenStorageWrite( tools::SvRef<SotStorage> xS
return xSubStrg;
}
-tools::SvRef<SotStorageStream> ScfTools::OpenStorageStreamRead( tools::SvRef<SotStorage> xStrg, const OUString& rStrmName )
+tools::SvRef<SotStorageStream> ScfTools::OpenStorageStreamRead( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrmName )
{
tools::SvRef<SotStorageStream> xStrm;
if( xStrg.Is() && xStrg->IsContained( rStrmName ) && xStrg->IsStream( rStrmName ) )
@@ -189,7 +189,7 @@ tools::SvRef<SotStorageStream> ScfTools::OpenStorageStreamRead( tools::SvRef<Sot
return xStrm;
}
-tools::SvRef<SotStorageStream> ScfTools::OpenStorageStreamWrite( tools::SvRef<SotStorage> xStrg, const OUString& rStrmName )
+tools::SvRef<SotStorageStream> ScfTools::OpenStorageStreamWrite( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrmName )
{
OSL_ENSURE( !xStrg || !xStrg->IsContained( rStrmName ), "ScfTools::OpenStorageStreamWrite - stream exists already" );
tools::SvRef<SotStorageStream> xStrm;
diff --git a/sc/source/filter/inc/condformatbuffer.hxx b/sc/source/filter/inc/condformatbuffer.hxx
index ccb498c11c76..3ff9ad359b98 100644
--- a/sc/source/filter/inc/condformatbuffer.hxx
+++ b/sc/source/filter/inc/condformatbuffer.hxx
@@ -215,7 +215,7 @@ public:
void setReadyForFinalize() { mbReadyForFinalize = true; }
private:
CondFormatRuleRef createRule();
- void insertRule( CondFormatRuleRef xRule );
+ void insertRule( CondFormatRuleRef const & xRule );
private:
typedef RefMap< sal_Int32, CondFormatRule > CondFormatRuleMap;
diff --git a/sc/source/filter/inc/ftools.hxx b/sc/source/filter/inc/ftools.hxx
index 85ed6b1ab9af..5a7d872445e9 100644
--- a/sc/source/filter/inc/ftools.hxx
+++ b/sc/source/filter/inc/ftools.hxx
@@ -156,14 +156,14 @@ public:
// *** streams and storages *** -----------------------------------------------
/** Tries to open an existing storage with the specified name in the passed storage (read-only). */
- static tools::SvRef<SotStorage> OpenStorageRead( tools::SvRef<SotStorage> xStrg, const OUString& rStrgName );
+ static tools::SvRef<SotStorage> OpenStorageRead( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrgName );
/** Creates and opens a storage with the specified name in the passed storage (read/write). */
- static tools::SvRef<SotStorage> OpenStorageWrite( tools::SvRef<SotStorage> xStrg, const OUString& rStrgName );
+ static tools::SvRef<SotStorage> OpenStorageWrite( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrgName );
/** Tries to open an existing stream with the specified name in the passed storage (read-only). */
- static tools::SvRef<SotStorageStream> OpenStorageStreamRead( tools::SvRef<SotStorage> xStrg, const OUString& rStrmName );
+ static tools::SvRef<SotStorageStream> OpenStorageStreamRead( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrmName );
/** Creates and opens a stream with the specified name in the passed storage (read/write). */
- static tools::SvRef<SotStorageStream> OpenStorageStreamWrite( tools::SvRef<SotStorage> xStrg, const OUString& rStrmName );
+ static tools::SvRef<SotStorageStream> OpenStorageStreamWrite( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrmName );
// *** item handling *** ------------------------------------------------------
diff --git a/sc/source/filter/inc/stylesbuffer.hxx b/sc/source/filter/inc/stylesbuffer.hxx
index 83f6d12385d3..020ddd9d0b07 100644
--- a/sc/source/filter/inc/stylesbuffer.hxx
+++ b/sc/source/filter/inc/stylesbuffer.hxx
@@ -779,7 +779,7 @@ public:
private:
/** Inserts the passed cell style object into the internal maps. */
- void insertCellStyle( CellStyleRef xCellStyle );
+ void insertCellStyle( CellStyleRef const & xCellStyle );
/** Creates the style sheet described by the passed cell style object. */
static OUString createCellStyle( const CellStyleRef& rxCellStyle );
static ::ScStyleSheet* getCellStyleSheet( const CellStyleRef& rxCellStyle );
diff --git a/sc/source/filter/inc/xechart.hxx b/sc/source/filter/inc/xechart.hxx
index 8baa58360796..94b98e7c1a9d 100644
--- a/sc/source/filter/inc/xechart.hxx
+++ b/sc/source/filter/inc/xechart.hxx
@@ -1134,7 +1134,7 @@ public:
/** Removes the last created data series object from the series list. */
void RemoveLastSeries();
/** Stores a CHTEXT group that describes a data point label. */
- void SetDataLabel( XclExpChTextRef xText );
+ void SetDataLabel( XclExpChTextRef const & xText );
/** Sets the plot area position and size to manual mode. */
void SetManualPlotArea();
diff --git a/sc/source/filter/inc/xestream.hxx b/sc/source/filter/inc/xestream.hxx
index 0d14f363f9f3..fa845f34496e 100644
--- a/sc/source/filter/inc/xestream.hxx
+++ b/sc/source/filter/inc/xestream.hxx
@@ -139,7 +139,7 @@ public:
/** Returns the absolute position of the system stream. */
inline sal_uInt64 GetSvStreamPos() const { return mrStrm.Tell(); }
- void SetEncrypter( XclExpEncrypterRef xEncrypter );
+ void SetEncrypter( XclExpEncrypterRef const & xEncrypter );
bool HasValidEncrypter() const;
@@ -298,7 +298,7 @@ public:
inline const XclExpRoot& GetRoot() const { return *mpRoot; }
sax_fastparser::FSHelperPtr& GetCurrentStream();
- void PushStream( sax_fastparser::FSHelperPtr aStream );
+ void PushStream( sax_fastparser::FSHelperPtr const & aStream );
void PopStream();
sax_fastparser::FSHelperPtr GetStreamForPath( const OUString& rPath );
diff --git a/sc/source/filter/inc/xestyle.hxx b/sc/source/filter/inc/xestyle.hxx
index 632577dfb034..f934f40c5059 100644
--- a/sc/source/filter/inc/xestyle.hxx
+++ b/sc/source/filter/inc/xestyle.hxx
@@ -664,11 +664,11 @@ private:
/** Inserts a built-in XF record without a STYLE record and returns the XF ID.
@param bCreateStyleRec true = Creates the related STYLE record. */
- sal_uInt32 AppendBuiltInXF( XclExpXFRef xXF,
+ sal_uInt32 AppendBuiltInXF( XclExpXFRef const & xXF,
sal_uInt8 nStyleId, sal_uInt8 nLevel = EXC_STYLE_NOLEVEL );
/** Inserts a built-in XF and STYLE record and returns the XF ID.
@param bCreateStyleRec true = Creates the related STYLE record. */
- sal_uInt32 AppendBuiltInXFWithStyle( XclExpXFRef xXF,
+ sal_uInt32 AppendBuiltInXFWithStyle( XclExpXFRef const & xXF,
sal_uInt8 nStyleId, sal_uInt8 nLevel = EXC_STYLE_NOLEVEL );
/** Inserts all default XF and STYLE records. */
diff --git a/sc/source/filter/inc/xetable.hxx b/sc/source/filter/inc/xetable.hxx
index 71c1ed99aff3..e0f236af95d2 100644
--- a/sc/source/filter/inc/xetable.hxx
+++ b/sc/source/filter/inc/xetable.hxx
@@ -425,7 +425,7 @@ public:
private:
/** Initializes the record contents. Called from constructors. */
void Init( const XclExpRoot& rRoot,
- const ScPatternAttr* pPattern, XclExpStringRef xText );
+ const ScPatternAttr* pPattern, XclExpStringRef const & xText );
virtual void WriteContents( XclExpStream& rStrm ) override;
@@ -848,7 +848,7 @@ public:
inline bool IsEnabled() const { return mbEnabled; }
/** Appends the passed cell object to this row. */
- void AppendCell( XclExpCellRef xCell, bool bIsMergedBase );
+ void AppendCell( XclExpCellRef const & xCell, bool bIsMergedBase );
/** Converts all XF identifiers into the Excel XF indexes. */
void Finalize( const ScfUInt16Vec& rColXFIndexes,
@@ -915,7 +915,7 @@ public:
explicit XclExpRowBuffer( const XclExpRoot& rRoot );
/** Appends the passed cell object to the row that the cell specifies. */
- void AppendCell( XclExpCellRef xCell, bool bIsMergedBase );
+ void AppendCell( XclExpCellRef const & xCell, bool bIsMergedBase );
/** Forces insertion of all ROW records before the passed row. */
void CreateRows( SCROW nFirstFreeScRow );
diff --git a/sc/source/filter/inc/xichart.hxx b/sc/source/filter/inc/xichart.hxx
index 9d3d9a0f194d..f5a838ddff7c 100644
--- a/sc/source/filter/inc/xichart.hxx
+++ b/sc/source/filter/inc/xichart.hxx
@@ -724,8 +724,8 @@ public:
void ReadChSerErrorBar( XclImpStream& rStrm );
/** Sets link and formatting information for the error bars. */
void SetSeriesData(
- XclImpChSourceLinkRef xValueLink,
- XclImpChDataFormatRef xDataFmt );
+ XclImpChSourceLinkRef const & xValueLink,
+ XclImpChDataFormatRef const & xDataFmt );
/** Returns the type of this error bar (X/Y, plus/minus). */
inline sal_uInt8 GetBarType() const { return maData.mnBarType; }
@@ -967,7 +967,7 @@ public:
void Finalize();
/** Inserts a series attached to this chart type group.*/
- void AddSeries( XclImpChSeriesRef xSeries );
+ void AddSeries( XclImpChSeriesRef const & xSeries );
/** Marks the passed format index as used. PopUnusedFormatIndex() will not return this index. */
void SetUsedFormatIndex( sal_uInt16 nFormatIdx );
/** Returns the next unused format index and marks it as used. */
@@ -1242,7 +1242,7 @@ private:
css::uno::Reference< css::chart2::XCoordinateSystem >
CreateCoordSystem( css::uno::Reference< css::chart2::XDiagram > const & xDiagram ) const;
/** Creates and inserts an axis into the container and registers the coordinate system. */
- void ConvertAxis( XclImpChAxisRef xChAxis, XclImpChTextRef xChAxisTitle,
+ void ConvertAxis( XclImpChAxisRef const & xChAxis, XclImpChTextRef const & xChAxisTitle,
css::uno::Reference< css::chart2::XCoordinateSystem > const & xCoordSystem,
const XclImpChAxis* pCrossingAxis ) const;
/** Creates and returns an API axis object. */
diff --git a/sc/source/filter/inc/xiescher.hxx b/sc/source/filter/inc/xiescher.hxx
index 7cee401000cc..afa74785da56 100644
--- a/sc/source/filter/inc/xiescher.hxx
+++ b/sc/source/filter/inc/xiescher.hxx
@@ -222,7 +222,7 @@ public:
void push_back(const XclImpDrawObjRef& rObj) { mObjs.push_back(rObj); }
/** Tries to insert the passed object into the last group or appends it. */
- void InsertGrouped( XclImpDrawObjRef xDrawObj );
+ void InsertGrouped( XclImpDrawObjRef const & xDrawObj );
/** Returns the needed size on the progress bar for all contained objects. */
sal_Size GetProgressSize() const;
@@ -242,7 +242,7 @@ public:
explicit XclImpGroupObj( const XclImpRoot& rRoot );
/** Tries to insert the drawing object into this or a nested group. */
- bool TryInsert( XclImpDrawObjRef xDrawObj );
+ bool TryInsert( XclImpDrawObjRef const & xDrawObj );
protected:
/** Reads the contents of the a BIFF3 OBJ record from the passed stream. */
diff --git a/sc/source/filter/inc/xistream.hxx b/sc/source/filter/inc/xistream.hxx
index 4fa50b0a9fde..179dbbdcd3d0 100644
--- a/sc/source/filter/inc/xistream.hxx
+++ b/sc/source/filter/inc/xistream.hxx
@@ -279,7 +279,7 @@ public:
void RewindRecord();
/** Enables decryption of record contents for the rest of the stream. */
- void SetDecrypter( XclImpDecrypterRef xDecrypter );
+ void SetDecrypter( XclImpDecrypterRef const & xDecrypter );
/** Sets decrypter from another stream. */
void CopyDecrypterFrom( const XclImpStream& rStrm );
/** Returns true, if a valid decrypter is set at the stream. */
diff --git a/sc/source/filter/inc/xlroot.hxx b/sc/source/filter/inc/xlroot.hxx
index 50829231bef8..3e8f1ce5a2f9 100644
--- a/sc/source/filter/inc/xlroot.hxx
+++ b/sc/source/filter/inc/xlroot.hxx
@@ -190,11 +190,11 @@ public:
bool HasVbaStorage() const;
/** Tries to open a storage as child of the specified storage for reading or writing. */
- tools::SvRef<SotStorage> OpenStorage( tools::SvRef<SotStorage> xStrg, const OUString& rStrgName ) const;
+ tools::SvRef<SotStorage> OpenStorage( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrgName ) const;
/** Tries to open a storage as child of the root storage for reading or writing. */
tools::SvRef<SotStorage> OpenStorage( const OUString& rStrgName ) const;
/** Tries to open a new stream in the specified storage for reading or writing. */
- tools::SvRef<SotStorageStream> OpenStream( tools::SvRef<SotStorage> xStrg, const OUString& rStrmName ) const;
+ tools::SvRef<SotStorageStream> OpenStream( tools::SvRef<SotStorage> const & xStrg, const OUString& rStrmName ) const;
/** Tries to open a new stream in the root storage for reading or writing. */
tools::SvRef<SotStorageStream> OpenStream( const OUString& rStrmName ) const;
diff --git a/sc/source/filter/oox/condformatbuffer.cxx b/sc/source/filter/oox/condformatbuffer.cxx
index 1c1eadd88518..1ff1d7a25e67 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -1080,7 +1080,7 @@ CondFormatRuleRef CondFormat::createRule()
return std::make_shared<CondFormatRule>( *this, mpFormat );
}
-void CondFormat::insertRule( CondFormatRuleRef xRule )
+void CondFormat::insertRule( CondFormatRuleRef const & xRule )
{
if( xRule.get() && (xRule->getPriority() > 0) )
{
diff --git a/sc/source/filter/oox/stylesbuffer.cxx b/sc/source/filter/oox/stylesbuffer.cxx
index e11df2148a8d..2e03ef8801a1 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -2663,7 +2663,7 @@ OUString CellStyleBuffer::createCellStyle( sal_Int32 nXfId ) const
// private --------------------------------------------------------------------
-void CellStyleBuffer::insertCellStyle( CellStyleRef xCellStyle )
+void CellStyleBuffer::insertCellStyle( CellStyleRef const & xCellStyle )
{
const CellStyleModel& rModel = xCellStyle->getModel();
if( rModel.mnXfId >= 0 )
diff --git a/sc/source/filter/oox/workbookfragment.cxx b/sc/source/filter/oox/workbookfragment.cxx
index 88f694853e0a..23fd2155643b 100644
--- a/sc/source/filter/oox/workbookfragment.cxx
+++ b/sc/source/filter/oox/workbookfragment.cxx
@@ -225,7 +225,7 @@ class WorkerThread : public comphelper::ThreadTask
rtl::Reference<FragmentHandler> mxHandler;
public:
- WorkerThread( const std::shared_ptr<comphelper::ThreadTaskTag> pTag,
+ WorkerThread( const std::shared_ptr<comphelper::ThreadTaskTag> & pTag,
WorkbookFragment& rWorkbookHandler,
const rtl::Reference<FragmentHandler>& xHandler,
sal_Int32 &rSheetsLeft ) :
diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx
index 6cb41f5171fc..5a119358973d 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -3042,7 +3042,7 @@ void flushParagraph(
ScXMLExport& rExport, const OUString& rParaText,
rtl::Reference<XMLPropertySetMapper> const & xMapper, rtl::Reference<SvXMLAutoStylePoolP> const & xStylePool,
const ScXMLEditAttributeMap& rAttrMap,
- std::vector<editeng::Section>::const_iterator it, std::vector<editeng::Section>::const_iterator itEnd )
+ std::vector<editeng::Section>::const_iterator it, std::vector<editeng::Section>::const_iterator const & itEnd )
{
OUString aElemName = rExport.GetNamespaceMap().GetQNameByKey(
XML_NAMESPACE_TEXT, GetXMLToken(XML_P));
diff --git a/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx b/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx
index 0ca3a93e242d..69f819cf4d1e 100644
--- a/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/StatisticsInputOutputDialog.cxx
@@ -25,7 +25,7 @@
#include "StatisticsInputOutputDialog.hxx"
-ScRangeList ScStatisticsInputOutputDialog::MakeColumnRangeList(SCTAB aTab, ScAddress aStart, ScAddress aEnd)
+ScRangeList ScStatisticsInputOutputDialog::MakeColumnRangeList(SCTAB aTab, ScAddress const & aStart, ScAddress const & aEnd)
{
ScRangeList aRangeList;
for (SCCOL inCol = aStart.Col(); inCol <= aEnd.Col(); inCol++)
@@ -39,7 +39,7 @@ ScRangeList ScStatisticsInputOutputDialog::MakeColumnRangeList(SCTAB aTab, ScAdd
return aRangeList;
}
-ScRangeList ScStatisticsInputOutputDialog::MakeRowRangeList(SCTAB aTab, ScAddress aStart, ScAddress aEnd)
+ScRangeList ScStatisticsInputOutputDialog::MakeRowRangeList(SCTAB aTab, ScAddress const & aStart, ScAddress const & aEnd)
{
ScRangeList aRangeList;
for (SCROW inRow = aStart.Row(); inRow <= aEnd.Row(); inRow++)
diff --git a/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx b/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx
index 8622dcf3d0ea..91a886423b2d 100644
--- a/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx
+++ b/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx
@@ -53,7 +53,7 @@ void FormulaTemplate::autoReplaceRange(const OUString& aVariable, const ScRange&
mRangeReplacementMap[aVariable] = rRange;
}
-void FormulaTemplate::autoReplaceAddress(const OUString& aVariable, ScAddress aAddress)
+void FormulaTemplate::autoReplaceAddress(const OUString& aVariable, ScAddress const & aAddress)
{
mAddressReplacementMap[aVariable] = aAddress;
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index c94bfbade5ef..c90742524c3c 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -107,7 +107,7 @@ sal_Unicode lcl_getSheetSeparator(ScDocument* pDoc)
}
ScTypedCaseStrSet::const_iterator findText(
- const ScTypedCaseStrSet& rDataSet, ScTypedCaseStrSet::const_iterator itPos,
+ const ScTypedCaseStrSet& rDataSet, ScTypedCaseStrSet::const_iterator const & itPos,
const OUString& rStart, OUString& rResult, bool bBack)
{
if (bBack) // Backwards
@@ -182,7 +182,7 @@ OUString getExactMatch(const ScTypedCaseStrSet& rDataSet, const OUString& rStrin
}
ScTypedCaseStrSet::const_iterator findTextAll(
- const ScTypedCaseStrSet& rDataSet, ScTypedCaseStrSet::const_iterator itPos,
+ const ScTypedCaseStrSet& rDataSet, ScTypedCaseStrSet::const_iterator const & itPos,
const OUString& rStart, ::std::vector< OUString > &rResultVec, bool bBack)
{
rResultVec.clear(); // clear contents
diff --git a/sc/source/ui/dbgui/csvsplits.cxx b/sc/source/ui/dbgui/csvsplits.cxx
index aa53a88c3f64..ccf87b2b781d 100644
--- a/sc/source/ui/dbgui/csvsplits.cxx
+++ b/sc/source/ui/dbgui/csvsplits.cxx
@@ -94,7 +94,7 @@ sal_Int32 ScCsvSplits::GetPos( sal_uInt32 nIndex ) const
return (nIndex < Count()) ? maVec[ nIndex ] : CSV_POS_INVALID;
}
-sal_uInt32 ScCsvSplits::GetIterIndex( const_iterator aIter ) const
+sal_uInt32 ScCsvSplits::GetIterIndex( const_iterator const & aIter ) const
{
return (aIter == maVec.end()) ? CSV_VEC_NOTFOUND : (aIter - maVec.begin());
}
diff --git a/sc/source/ui/docshell/externalrefmgr.cxx b/sc/source/ui/docshell/externalrefmgr.cxx
index d97d54705263..0126f9cecca1 100644
--- a/sc/source/ui/docshell/externalrefmgr.cxx
+++ b/sc/source/ui/docshell/externalrefmgr.cxx
@@ -278,7 +278,7 @@ bool ScExternalRefCache::Table::isReferenced() const
return meReferenced != UNREFERENCED;
}
-void ScExternalRefCache::Table::setCell(SCCOL nCol, SCROW nRow, TokenRef pToken, sal_uLong nFmtIndex, bool bSetCacheRange)
+void ScExternalRefCache::Table::setCell(SCCOL nCol, SCROW nRow, TokenRef const & pToken, sal_uLong nFmtIndex, bool bSetCacheRange)
{
using ::std::pair;
RowsDataType::iterator itrRow = maRows.find(nRow);
@@ -787,7 +787,7 @@ void ScExternalRefCache::setRangeName(sal_uInt16 nFileId, const OUString& rName)
}
void ScExternalRefCache::setCellData(sal_uInt16 nFileId, const OUString& rTabName, SCCOL nCol, SCROW nRow,
- TokenRef pToken, sal_uLong nFmtIndex)
+ TokenRef const & pToken, sal_uLong nFmtIndex)
{
if (!isDocInitialized(nFileId))
return;
diff --git a/sc/source/ui/docshell/tablink.cxx b/sc/source/ui/docshell/tablink.cxx
index 2e062f501782..fab2af5c16eb 100644
--- a/sc/source/ui/docshell/tablink.cxx
+++ b/sc/source/ui/docshell/tablink.cxx
@@ -489,7 +489,7 @@ void ScDocumentLoader::RemoveAppPrefix( OUString& rFilterName )
rFilterName = rFilterName.copy( aAppPrefix.getLength());
}
-SfxMedium* ScDocumentLoader::CreateMedium( const OUString& rFileName, std::shared_ptr<const SfxFilter> pFilter,
+SfxMedium* ScDocumentLoader::CreateMedium( const OUString& rFileName, std::shared_ptr<const SfxFilter> const & pFilter,
const OUString& rOptions )
{
// Always create SfxItemSet so ScDocShell can set options.
diff --git a/sc/source/ui/inc/StatisticsInputOutputDialog.hxx b/sc/source/ui/inc/StatisticsInputOutputDialog.hxx
index 874358abcb1e..5fedfdd39f83 100644
--- a/sc/source/ui/inc/StatisticsInputOutputDialog.hxx
+++ b/sc/source/ui/inc/StatisticsInputOutputDialog.hxx
@@ -65,8 +65,8 @@ protected:
ScAddress mOutputAddress;
GroupedBy mGroupedBy;
- static ScRangeList MakeColumnRangeList(SCTAB aTab, ScAddress aStart, ScAddress aEnd);
- static ScRangeList MakeRowRangeList(SCTAB aTab, ScAddress aStart, ScAddress aEnd);
+ static ScRangeList MakeColumnRangeList(SCTAB aTab, ScAddress const & aStart, ScAddress const & aEnd);
+ static ScRangeList MakeRowRangeList(SCTAB aTab, ScAddress const & aStart, ScAddress const & aEnd);
private:
// Widgets
diff --git a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
index 8d0bbfe23fea..0ba02ab5f085 100644
--- a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
+++ b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
@@ -42,7 +42,7 @@ public:
const OUString& getTemplate();
void autoReplaceRange(const OUString& aVariable, const ScRange& rRange);
- void autoReplaceAddress(const OUString& aVariable, ScAddress aAddress);
+ void autoReplaceAddress(const OUString& aVariable, ScAddress const & aAddress);
void autoReplaceUses3D(bool bUse3D = true) { mbUse3D = bUse3D; }
void applyRange(const OUString& aVariable, const ScRange& aRange, bool b3D = true);
diff --git a/sc/source/ui/inc/csvsplits.hxx b/sc/source/ui/inc/csvsplits.hxx
index 7ab80e34a76f..93aa22b991ae 100644
--- a/sc/source/ui/inc/csvsplits.hxx
+++ b/sc/source/ui/inc/csvsplits.hxx
@@ -77,7 +77,7 @@ public:
private:
/** Returns the vector index of an iterator. */
- sal_uInt32 GetIterIndex( const_iterator aIter ) const;
+ sal_uInt32 GetIterIndex( const_iterator const & aIter ) const;
};
#endif
diff --git a/sc/source/ui/sidebar/CellBorderUpdater.cxx b/sc/source/ui/sidebar/CellBorderUpdater.cxx
index 12a87773182e..64912d6f3898 100644
--- a/sc/source/ui/sidebar/CellBorderUpdater.cxx
+++ b/sc/source/ui/sidebar/CellBorderUpdater.cxx
@@ -36,7 +36,7 @@ CellBorderUpdater::~CellBorderUpdater()
{
}
-void CellBorderUpdater::UpdateCellBorder(bool bTop, bool bBot, bool bLeft, bool bRight, Image aImg, bool bVer, bool bHor)
+void CellBorderUpdater::UpdateCellBorder(bool bTop, bool bBot, bool bLeft, bool bRight, Image const & aImg, bool bVer, bool bHor)
{
BitmapEx aBmpEx( aImg.GetBitmapEx() );
Bitmap aBmp( aBmpEx.GetBitmap() );
diff --git a/sc/source/ui/sidebar/CellBorderUpdater.hxx b/sc/source/ui/sidebar/CellBorderUpdater.hxx
index e144537564f4..7f48af9ae435 100644
--- a/sc/source/ui/sidebar/CellBorderUpdater.hxx
+++ b/sc/source/ui/sidebar/CellBorderUpdater.hxx
@@ -33,7 +33,7 @@ public:
CellBorderUpdater(sal_uInt16 nTbxBtnId, ToolBox& rTbx);
~CellBorderUpdater();
- void UpdateCellBorder(bool bTop, bool bBot, bool bLeft, bool bRight, Image aImg, bool bVer, bool bHor);
+ void UpdateCellBorder(bool bTop, bool bBot, bool bLeft, bool bRight, Image const & aImg, bool bVer, bool bHor);
};
} } // end of namespace svx::sidebar
diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 298acf0f40fc..8e2044baec9f 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -174,19 +174,19 @@ void ScGridWinUIObject::execute(const OUString& rAction,
namespace {
-ScDrawLayer* get_draw_layer(VclPtr<ScGridWindow> xGridWindow)
+ScDrawLayer* get_draw_layer(VclPtr<ScGridWindow> const & xGridWindow)
{
return xGridWindow->getViewData()->GetDocument()->GetDrawLayer();
}
-SdrPage* get_draw_page(VclPtr<ScGridWindow> xGridWindow, SCTAB nTab)
+SdrPage* get_draw_page(VclPtr<ScGridWindow> const & xGridWindow, SCTAB nTab)
{
ScDrawLayer* pDrawLayer = get_draw_layer(xGridWindow);
return pDrawLayer->GetPage(nTab);
}
-std::set<OUString> collect_charts(VclPtr<ScGridWindow> xGridWindow)
+std::set<OUString> collect_charts(VclPtr<ScGridWindow> const & xGridWindow)
{
SCTAB nTab = xGridWindow->getViewData()->GetTabNo();
SdrPage* pPage = get_draw_page(xGridWindow, nTab);
diff --git a/sc/source/ui/vba/vbainterior.cxx b/sc/source/ui/vba/vbainterior.cxx
index 0b9d1a8c3a87..2b1a7d114e39 100644
--- a/sc/source/ui/vba/vbainterior.cxx
+++ b/sc/source/ui/vba/vbainterior.cxx
@@ -252,7 +252,7 @@ ScVbaInterior::GetAttributeContainer()
return uno::Reference < container::XNameContainer > ( m_xProps->getPropertyValue("UserDefinedAttributes"), uno::UNO_QUERY_THROW );
}
sal_Int32
-ScVbaInterior::GetAttributeData( uno::Any aValue )
+ScVbaInterior::GetAttributeData( uno::Any const & aValue )
{
xml::AttributeData aDataValue;
if( aValue >>= aDataValue )
diff --git a/sc/source/ui/vba/vbainterior.hxx b/sc/source/ui/vba/vbainterior.hxx
index 02bbeaf5bfd5..683e002faa66 100644
--- a/sc/source/ui/vba/vbainterior.hxx
+++ b/sc/source/ui/vba/vbainterior.hxx
@@ -44,7 +44,7 @@ class ScVbaInterior : public ScVbaInterior_BASE
css::uno::Reference< css::container::XIndexAccess > getPalette();
css::uno::Reference< css::container::XNameContainer > GetAttributeContainer();
static css::uno::Any SetAttributeData( sal_Int32 nValue );
- static sal_Int32 GetAttributeData( css::uno::Any aValue );
+ static sal_Int32 GetAttributeData( css::uno::Any const & aValue );
Color GetBackColor();
protected:
static Color GetPatternColor( const Color& rPattColor, const Color& rBackColor, sal_uInt32 nXclPattern );