diff options
| author | Armin Le Grand (Allotropia) <armin.le.grand@me.com> | 2021-06-10 19:24:04 +0200 |
|---|---|---|
| committer | Armin Le Grand <Armin.Le.Grand@me.com> | 2021-06-11 09:40:45 +0200 |
| commit | 552ceeb5c6ccf2573adfd092cc4b2ce214a9c2df (patch) | |
| tree | e6f7f91789922c087ac5be9d108011b47d045f0e /sc | |
| parent | 5c3ad59612697cf0afee0f836e9ee77f0920356b (diff) | |
tdf#130428 remove unnecessary usage of SfxItemState::UNKNOWN
FontworkBar::getState does not need to check for SfxItemState::UNKNOWN
at all, actions solely depend on FontWork object being selected.
This also greatly simplifies that method. Also, the optimization
by passing in a variable to checkForSelectedFontWork and remember
if already computed can be removed - also in other places where
it had to be given, but was not re-used at all
Change-Id: I35b1f36195feb1d645619665d2dd65a84b75b118
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117014
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/view/tabvwsh4.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx index 0707b7038409..f8f22b49b7ae 100644 --- a/sc/source/ui/view/tabvwsh4.cxx +++ b/sc/source/ui/view/tabvwsh4.cxx @@ -835,9 +835,9 @@ void ScTabViewShell::SetCurSubShell(ObjectSelectionType eOST, bool bForce) pExtrusionBarShell.reset( new svx::ExtrusionBar(this) ); AddSubShell( *pExtrusionBarShell ); } - sal_uInt32 nCheckStatus = 0; + if (svx::checkForSelectedFontWork( - GetScDrawView(), nCheckStatus )) { + GetScDrawView() )) { if (pFontworkBarShell == nullptr) pFontworkBarShell.reset( new svx::FontworkBar(this) ); AddSubShell( *pFontworkBarShell ); |