diff options
| author | Justin Luth <jluth@mail.com> | 2023-06-23 10:58:54 -0400 |
|---|---|---|
| committer | Justin Luth <jluth@mail.com> | 2023-06-23 20:45:29 +0200 |
| commit | 805abacd0d1fe2d5522a2041fc3c07961a62ba5f (patch) | |
| tree | 15c45ceff1af3f313e1a6be1512ee0267945776b /sc | |
| parent | 9f5393abea012be04ab7ecb26d8031019bc50f62 (diff) | |
related tdf#68695 tdf#141136 sc: comment can't resize; avoid context change
In order to avoid having the notebookbar
constantly flipping back to the home tab,
try to avoid useless context switches.
That should also be a nice performance win.
In this case, the context change occurred because handles were enabled,
but that broke in LO 4.1, so just revert that broken OOo fix.
Back in OOo, https://bz.apache.org/ooo/show_bug.cgi?id=33764
added resize handles to a newly inserted comment,
and was added to LO as part of a huge batch.
commit 07b0c01857137de7e4bd02375e7c892d622d270e
Author: Oliver Bolte on Mon Mar 2 14:19:13 2009 +0000
CWS-TOOLING: integrate CWS dr66
But that didn't allow select and copy, so in LO 4.1
commit 54a1feb9b9bd654774b9aa60cda7ef9a1cd11064
Author: Armin Le Grand on Fri May 10 12:08:40 2013 +0100
Resolves: #i122142# use simple text hilight frames
Bug 68695 exists to complain about the inability to resize.
Change-Id: If04d718b7de9cff1038bbe9f6372d4859643d3f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153508
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/view/viewfun6.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sc/source/ui/view/viewfun6.cxx b/sc/source/ui/view/viewfun6.cxx index e8e9dbc554ed..a840670dfce2 100644 --- a/sc/source/ui/view/viewfun6.cxx +++ b/sc/source/ui/view/viewfun6.cxx @@ -541,9 +541,6 @@ void ScViewFunc::EditNote() if ( ScDrawView* pScDrawView = GetScDrawView() ) pScDrawView->SyncForGrid( pCaption ); - // #i33764# enable the resize handles before starting edit mode - if( FuPoor* pDraw = GetDrawFuncPtr() ) - static_cast< FuSelection* >( pDraw )->ActivateNoteHandles( pCaption ); // activate object (as in FuSelection::TestComment) GetViewData().GetDispatcher().Execute( SID_DRAW_NOTEEDIT, SfxCallMode::SYNCHRON | SfxCallMode::RECORD ); |