diff options
| author | Kohei Yoshida <kohei.yoshida@gmail.com> | 2013-01-11 12:51:13 -0500 |
|---|---|---|
| committer | Kohei Yoshida <kohei.yoshida@gmail.com> | 2013-01-11 12:53:22 -0500 |
| commit | d99abd61a9091426bfccd871d6a8f036d5f49479 (patch) | |
| tree | 0ea0138321f9570df39e8ba5eb49c567b3e062b7 /sc | |
| parent | feef29286f0a7c6abd512a07fce9ef48327e0a78 (diff) | |
Let's not return here to prevent memory leak.
There are several heap objects that are deleted at the end of the
method. Returning prematurely would leak those objects.
Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/docshell/dbdocfun.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx index 403ecd3a94df..d0e3ebb48d03 100644 --- a/sc/source/ui/docshell/dbdocfun.cxx +++ b/sc/source/ui/docshell/dbdocfun.cxx @@ -1320,8 +1320,7 @@ bool ScDBDocFunc::DataPilotUpdate( ScDPObject* pOldObj, const ScDPObject* pNewOb if ( pDestObj ) { pDestObj->ReloadGroupTableData(); - if (!pDestObj->SyncAllDimensionMembers()) - return false; + pDestObj->SyncAllDimensionMembers(); pDestObj->InvalidateData(); // before getting the new output area // make sure the table has a name (not set by dialog) |