loplugin: defaultparams

Change-Id: I807ce811f5988d6134b4c6f73408cd034f25a7f7

22 files changed, 39 insertions, 40 deletions

diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index 216ede66939b..65c2331eb00b 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -932,7 +932,7 @@ void ScAttrArray::MergePatternArea( SCROW nStartRow, SCROW nEndRow,
                     if (bDeep)
                         lcl_MergeDeep( *rState.pItemSet, rThisSet );
                     else
-                        rState.pItemSet->MergeValues( rThisSet, false );
+                        rState.pItemSet->MergeValues( rThisSet );
                 }
                 else
                 {
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 846a52f10072..c7d71e30a80d 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1819,7 +1819,7 @@ void ScColumn::MarkScenarioIn( ScMarkData& rDestMark ) const
         {
             aRange.aStart.SetRow( nStart );
             aRange.aEnd.SetRow( nEnd );
-            rDestMark.SetMultiMarkArea( aRange, true );
+            rDestMark.SetMultiMarkArea( aRange );
         }
 
         pPattern = aAttrIter.Next( nStart, nEnd );
@@ -2872,7 +2872,7 @@ public:
         sc::SharedFormulaUtil::unshareFormulaCell(aPos, *pCell);
         pCell->GetCode()->SetCodeError(0);
         OUString aFormula = pCell->GetFormula(mrCxt);
-        pCell->Compile(mrCxt, aFormula, false);
+        pCell->Compile(mrCxt, aFormula);
         ScColumn::JoinNewFormulaCell(aPos, *pCell);
 
         mbCompiled = true;
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 5b02cf7d4b39..bfea26f843bc 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -256,7 +256,7 @@ ScDocument::ScDocument( ScDocumentMode eMode, SfxObjectShell* pDocShell ) :
 
 sfx2::LinkManager* ScDocument::GetLinkManager()
 {
-    return GetDocLinkManager().getLinkManager(true);
+    return GetDocLinkManager().getLinkManager();
 }
 
 const sfx2::LinkManager* ScDocument::GetLinkManager() const
@@ -345,7 +345,7 @@ IMPL_LINK_NOARG_TYPED(ScDocument, TrackTimeHdl, Idle *, void)
 
         if (!pShell->IsModified())
         {
-            pShell->SetModified( true );
+            pShell->SetModified();
             SfxBindings* pBindings = GetViewBindings();
             if (pBindings)
             {
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 5e3df16ef625..5e6aa4d8566b 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -994,7 +994,7 @@ void ScDocument::UpdateReference(
         xRowNameRanges->UpdateReference( eUpdateRefMode, this, aRange, nDx, nDy, nDz );
         pDBCollection->UpdateReference( eUpdateRefMode, nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, nDx, nDy, nDz );
         if (pRangeName)
-            pRangeName->UpdateReference(rCxt, -1);
+            pRangeName->UpdateReference(rCxt);
         if ( pDPCollection )
             pDPCollection->UpdateReference( eUpdateRefMode, aRange, nDx, nDy, nDz );
         UpdateChartRef( eUpdateRefMode, nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, nDx, nDy, nDz );
diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index 8b73c472e403..4d93eca06538 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -602,7 +602,7 @@ bool ScDocument::GetSelectionFunction( ScSubTotalFunc eFunc,
 
     ScMarkData aMark(rMark);
     aMark.MarkToMulti();
-    if (!aMark.IsMultiMarked() && !aMark.IsCellMarked(rCursor.Col(), rCursor.Row(), false))
+    if (!aMark.IsMultiMarked() && !aMark.IsCellMarked(rCursor.Col(), rCursor.Row()))
         aMark.SetMarkArea(rCursor);
 
     SCTAB nMax = static_cast<SCTAB>(maTabs.size());
diff --git a/sc/source/core/data/documen7.cxx b/sc/source/core/data/documen7.cxx
index c60619e74f24..7d0315a9ff5e 100644
--- a/sc/source/core/data/documen7.cxx
+++ b/sc/source/core/data/documen7.cxx
@@ -452,7 +452,7 @@ void ScDocument::CalcFormulaTree( bool bOnlyForced, bool bProgressBar, bool bSet
 
         bool bProgress = !bOnlyForced && nFormulaCodeInTree && bProgressBar;
         if ( bProgress )
-            ScProgress::CreateInterpretProgress( this, true );
+            ScProgress::CreateInterpretProgress( this );
 
         pCell = pFormulaTree;
         ScFormulaCell* pLastNoGood = 0;
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 5c094ad03009..85be6564af7b 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -484,7 +484,7 @@ public:
         // the calls.
 
         mrDoc.EnableIdle(false);
-        mpStylePool->SetSearchMask(SFX_STYLE_FAMILY_PAGE, SFXSTYLEBIT_ALL);
+        mpStylePool->SetSearchMask(SFX_STYLE_FAMILY_PAGE);
     }
 
     ~IdleCalcTextWidthScope()
@@ -857,7 +857,7 @@ void ScDocument::UpdateExternalRefLinks(vcl::Window* pWin)
         // #i101960# set document modified, as in TrackTimeHdl for DDE links
         if (!pShell->IsModified())
         {
-            pShell->SetModified( true );
+            pShell->SetModified();
             SfxBindings* pBindings = GetViewBindings();
             if (pBindings)
             {
@@ -1249,7 +1249,7 @@ void ScDocument::TransliterateText( const ScMarkData& rMultiMark, sal_Int32 nTyp
                         SfxItemSet* pFontSet = GetPreviewFont( nCol, nRow, nTab );
                         pPattern->FillEditItemSet( pDefaults, pFontSet );
                     }
-                    pEngine->SetDefaults( pDefaults,  true );
+                    pEngine->SetDefaults( pDefaults );
                     if (aCell.meType == CELLTYPE_STRING)
                         pEngine->SetText(aCell.mpString->getString());
                     else if (aCell.mpEditText)
@@ -1272,7 +1272,7 @@ void ScDocument::TransliterateText( const ScMarkData& rMultiMark, sal_Int32 nTyp
                         {
                             // remove defaults (paragraph attributes) before creating text object
                             SfxItemSet* pEmpty = new SfxItemSet( pEngine->GetEmptyItemSet() );
-                            pEngine->SetDefaults( pEmpty, true );
+                            pEngine->SetDefaults( pEmpty );
 
                             // The cell will take ownership of the text object instance.
                             SetEditText(ScAddress(nCol,nRow,nTab), pEngine->CreateTextObject());
diff --git a/sc/source/core/data/documen9.cxx b/sc/source/core/data/documen9.cxx
index 18d483c1e0ab..790db1f9f39d 100644
--- a/sc/source/core/data/documen9.cxx
+++ b/sc/source/core/data/documen9.cxx
@@ -504,8 +504,7 @@ bool ScDocument::IsPrintEmpty( SCTAB nTab, SCCOL nStartCol, SCROW nStartRow,
         // might create and assign a printer.
         ScDocument* pThis = const_cast<ScDocument*>(this);
 
-        pThis->ExtendMerge( 0,nStartRow, nExtendCol,nTmpRow, nTab,
-                            false );      // no Refresh, incl. Attrs
+        pThis->ExtendMerge( 0,nStartRow, nExtendCol,nTmpRow, nTab );      // no Refresh, incl. Attrs
 
         OutputDevice* pDev = pThis->GetPrinter();
         pDev->SetMapMode( MAP_PIXEL );              // Important for GetNeededSize
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index febf0df43f88..7943fa5e1619 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -4125,7 +4125,7 @@ void ScDocument::UpdateAllRowHeights( sc::RowHeightContext& rCxt, const ScMarkDa
         if ( maTabs[nTab] && ( !pTabMark || pTabMark->GetTableSelect(nTab) ) )
         {
             maTabs[nTab]->SetOptimalHeightOnly(rCxt, 0, MAXROW, &aProgress, nProgressStart);
-            maTabs[nTab]->SetDrawPageSize(true, true);
+            maTabs[nTab]->SetDrawPageSize(true);
             nProgressStart += maTabs[nTab]->GetWeightedCount();
         }
 }
@@ -5415,7 +5415,7 @@ bool ScDocument::ExtendTotalMerge( ScRange& rRange ) const
     bool bRet = false;
     ScRange aExt = rRange;
     // ExtendMerge() is non-const, but called withouth refresh.
-    if (const_cast<ScDocument*>(this)->ExtendMerge( aExt, false))
+    if (const_cast<ScDocument*>(this)->ExtendMerge( aExt ))
     {
         if ( aExt.aEnd.Row() > rRange.aEnd.Row() )
         {
diff --git a/sc/source/core/data/documentimport.cxx b/sc/source/core/data/documentimport.cxx
index 419c36674170..642bbc2df3d4 100644
--- a/sc/source/core/data/documentimport.cxx
+++ b/sc/source/core/data/documentimport.cxx
@@ -309,7 +309,7 @@ void ScDocumentImport::setMatrixCells(
 
     // Matrix formulas currently need re-calculation on import.
     pCell->SetMatColsRows(
-        rRange.aEnd.Col()-rRange.aStart.Col()+1, rRange.aEnd.Row()-rRange.aStart.Row()+1, true);
+        rRange.aEnd.Col()-rRange.aStart.Col()+1, rRange.aEnd.Row()-rRange.aStart.Row()+1);
 
     // Set the reference cells.
     ScSingleRefData aRefData;
diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index 009c60dcd24f..db4ccd294fe2 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -1251,7 +1251,7 @@ OUString ScDPObject::GetDimName( long nDim, bool& rIsDataLayout, sal_Int32* pFla
 
                 if (pFlags)
                     *pFlags = ScUnoHelpFunctions::GetLongProperty( xDimProp,
-                                OUString(SC_UNO_DP_FLAGS), 0 );
+                                OUString(SC_UNO_DP_FLAGS) );
             }
         }
     }
@@ -2353,7 +2353,7 @@ bool ScDPObject::FillLabelDataForDimension(
         GetMembers(nDim, GetUsedHierarchy(nDim), rLabelData.maMembers);
         lcl_FillLabelData(rLabelData, xDimProp);
         rLabelData.mnFlags = ScUnoHelpFunctions::GetLongProperty(
-            xDimProp, OUString(SC_UNO_DP_FLAGS), 0);
+            xDimProp, OUString(SC_UNO_DP_FLAGS) );
     }
     return true;
 }
diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx
index 450c5bb7393d..a2c13f824568 100644
--- a/sc/source/core/data/dpoutput.cxx
+++ b/sc/source/core/data/dpoutput.cxx
@@ -263,7 +263,7 @@ void ScDPOutputImpl::OutputBlockFrame ( SCCOL nStartCol, SCROW nStartRow, SCCOL
     aBoxInfo.SetValid(SvxBoxInfoItemValidFlags::VERT,false );
     if ( bHori )
     {
-        aBoxInfo.SetValid(SvxBoxInfoItemValidFlags::HORI,true);
+        aBoxInfo.SetValid(SvxBoxInfoItemValidFlags::HORI);
         aBoxInfo.SetLine( &aLine, SvxBoxInfoItemLine::HORI );
     }
     else
@@ -491,7 +491,7 @@ uno::Sequence<sheet::MemberResult> getVisiblePageMembersAsResults( const uno::Re
         if (aCaption.isEmpty())
             aCaption = rName;
 
-        bool bVisible = ScUnoHelpFunctions::GetBoolProperty(xMemPS, SC_UNO_DP_ISVISIBLE, false);
+        bool bVisible = ScUnoHelpFunctions::GetBoolProperty(xMemPS, SC_UNO_DP_ISVISIBLE);
 
         if (bVisible)
             aRes.push_back(sheet::MemberResult(rName, aCaption, 0));
@@ -563,7 +563,7 @@ ScDPOutput::ScDPOutput( ScDocument* pD, const uno::Reference<sheet::XDimensionsS
                 bool bHasHiddenMember = ScUnoHelpFunctions::GetBoolProperty(
                     xDimProp, OUString(SC_UNO_DP_HAS_HIDDEN_MEMBER));
                 sal_Int32 nNumFmt = ScUnoHelpFunctions::GetLongProperty(
-                    xDimProp, SC_UNO_DP_NUMBERFO, 0);
+                    xDimProp, SC_UNO_DP_NUMBERFO);
 
                 if ( eDimOrient != sheet::DataPilotFieldOrientation_HIDDEN )
                 {
diff --git a/sc/source/core/data/dptabres.cxx b/sc/source/core/data/dptabres.cxx
index 146bbf400d06..cda6832aeed6 100644
--- a/sc/source/core/data/dptabres.cxx
+++ b/sc/source/core/data/dptabres.cxx
@@ -1051,7 +1051,7 @@ void ScDPResultMember::InitFrom( const vector<ScDPDimension*>& ppDim, const vect
     if ( bInitChild )
     {
         pChildDimension = new ScDPResultDimension( pResultData );
-        pChildDimension->InitFrom(ppDim, ppLev, nPos, rInitState, true);
+        pChildDimension->InitFrom(ppDim, ppLev, nPos, rInitState);
     }
 }
 
diff --git a/sc/source/core/data/drwlayer.cxx b/sc/source/core/data/drwlayer.cxx
index 032637c90a79..dc7576ce81aa 100644
--- a/sc/source/core/data/drwlayer.cxx
+++ b/sc/source/core/data/drwlayer.cxx
@@ -267,7 +267,7 @@ ScDrawLayer::ScDrawLayer( ScDocument* pDocument, const OUString& rName ) :
     }
     SetPropertyList( static_cast<XPropertyList *> (pXCol.get()) );
 
-    SetSwapGraphics(true);
+    SetSwapGraphics();
 
     SetScaleUnit(MAP_100TH_MM);
     SfxItemPool& rPool = GetItemPool();
@@ -556,7 +556,7 @@ void ScDrawLayer::MoveCells( SCTAB nTab, SCCOL nCol1,SCROW nRow1, SCCOL nCol2,SC
                     pData->maStart.PutInOrder( pData->maEnd );
 
                 // Update also an untransformed anchor thats what we stored ( and still do ) to xml
-                ScDrawObjData* pNoRotatedAnchor = GetNonRotatedObjData( pObj, false );
+                ScDrawObjData* pNoRotatedAnchor = GetNonRotatedObjData( pObj );
                 if ( pNoRotatedAnchor )
                 {
                     pNoRotatedAnchor->maStart = pData->maStart;
diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index e02c3cc7252a..c90ab3edf8b0 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -3172,7 +3172,7 @@ bool ScFormulaCell::UpdateReferenceOnCopy(
 
     if (bCompile)
     {
-        CompileTokenArray(false); // no Listening
+        CompileTokenArray(); // no Listening
         bNeedDirty = true;
     }
 
diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index 874905972d84..61e2f649bbd3 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -690,7 +690,7 @@ ScFunctionMgr::~ScFunctionMgr()
 const ScFuncDesc* ScFunctionMgr::Get( sal_uInt16 nFIndex ) const
 {
     const ScFuncDesc* pDesc;
-    for (pDesc = First(0); pDesc; pDesc = Next())
+    for (pDesc = First(); pDesc; pDesc = Next())
         if (pDesc->nFIndex == nFIndex)
             break;
     return pDesc;
diff --git a/sc/source/core/data/markarr.cxx b/sc/source/core/data/markarr.cxx
index 6a83437216fc..baa9aab5cc3e 100644
--- a/sc/source/core/data/markarr.cxx
+++ b/sc/source/core/data/markarr.cxx
@@ -108,7 +108,7 @@ void ScMarkArray::SetMarkArea( SCROW nStartRow, SCROW nEndRow, bool bMarked )
         else
         {
             if (!pData)
-                Reset(false);   // create pData for further processing - could use special case handling!
+                Reset();   // create pData for further processing - could use special case handling!
 
             SCSIZE nNeeded = nCount + 2;
             if ( nLimit < nNeeded )
@@ -309,7 +309,7 @@ void ScMarkArray::CopyMarksTo( ScMarkArray& rDestMarkArray ) const
 SCsROW ScMarkArray::GetNextMarked( SCsROW nRow, bool bUp ) const
 {
     if (!pData)
-        const_cast<ScMarkArray*>(this)->Reset(false);   // create pData for further processing
+        const_cast<ScMarkArray*>(this)->Reset();   // create pData for further processing
 
     SCsROW nRet = nRow;
     if (ValidRow(nRow))
@@ -335,7 +335,7 @@ SCsROW ScMarkArray::GetNextMarked( SCsROW nRow, bool bUp ) const
 SCROW ScMarkArray::GetMarkEnd( SCROW nRow, bool bUp ) const
 {
     if (!pData)
-        const_cast<ScMarkArray*>(this)->Reset(false);   // create pData for further processing
+        const_cast<ScMarkArray*>(this)->Reset();   // create pData for further processing
 
     SCROW nRet;
     SCSIZE nIndex;
diff --git a/sc/source/core/data/markdata.cxx b/sc/source/core/data/markdata.cxx
index 28c18d7e5ce4..ab333db5bc02 100644
--- a/sc/source/core/data/markdata.cxx
+++ b/sc/source/core/data/markdata.cxx
@@ -131,7 +131,7 @@ void ScMarkData::SetMultiMarkArea( const ScRange& rRange, bool bMark )
         if ( bMarked && !bMarkIsNeg )
         {
             bMarked = false;
-            SetMultiMarkArea( aMarkRange, true );
+            SetMultiMarkArea( aMarkRange );
         }
     }
 
@@ -363,7 +363,7 @@ void ScMarkData::MarkFromRangeList( const ScRangeList& rList, bool bReset )
         for (size_t i=0; i < nCount; i++)
         {
             const ScRange& rRange = *rList[ i ];
-            SetMultiMarkArea( rRange, true );
+            SetMultiMarkArea( rRange );
             SelectTable( rRange.aStart.Tab(), true );
         }
     }
diff --git a/sc/source/core/data/simpleformulacalc.cxx b/sc/source/core/data/simpleformulacalc.cxx
index a931551b8142..885d4030ae7a 100644
--- a/sc/source/core/data/simpleformulacalc.cxx
+++ b/sc/source/core/data/simpleformulacalc.cxx
@@ -53,7 +53,7 @@ void ScSimpleFormulaCalculator::Calculate()
         ScCompiler aComp(mpDoc, maAddr);
         aComp.SetGrammar(maGram);
         OUStringBuffer aStr;
-        aComp.CreateStringFromToken(aStr, aInt.GetResultToken().get(), false);
+        aComp.CreateStringFromToken(aStr, aInt.GetResultToken().get());
 
         bIsMatrix = true;
 
diff --git a/sc/source/core/data/stlpool.cxx b/sc/source/core/data/stlpool.cxx
index 996a35a0ee13..d175cc75c9ab 100644
--- a/sc/source/core/data/stlpool.cxx
+++ b/sc/source/core/data/stlpool.cxx
@@ -373,11 +373,11 @@ void ScStyleSheetPool::CreateStandardStyles()
     aBoxItem.SetLine( &aBorderLine, SvxBoxItemLine::LEFT );
     aBoxItem.SetLine( &aBorderLine, SvxBoxItemLine::RIGHT );
     aBoxItem.SetDistance( 10 ); // 0.2mm
-    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::TOP, true );
-    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::BOTTOM, true );
-    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::LEFT, true );
-    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::RIGHT, true );
-    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true );
+    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::TOP );
+    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::BOTTOM );
+    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::LEFT );
+    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::RIGHT );
+    aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE );
     aBoxInfoItem.SetTable( false );
     aBoxInfoItem.SetDist ( true );
 
diff --git a/sc/source/core/data/stlsheet.cxx b/sc/source/core/data/stlsheet.cxx
index be060c284ad6..58be8f528e93 100644
--- a/sc/source/core/data/stlsheet.cxx
+++ b/sc/source/core/data/stlsheet.cxx
@@ -184,7 +184,7 @@ SfxItemSet& ScStyleSheet::GetItemSet()
 
                         aBoxInfoItem.SetTable( false );
                         aBoxInfoItem.SetDist( true );
-                        aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE, true );
+                        aBoxInfoItem.SetValid( SvxBoxInfoItemValidFlags::DISTANCE );
 
                         aPageItem.SetLandscape( false );
 
diff --git a/sc/source/core/data/tabprotection.cxx b/sc/source/core/data/tabprotection.cxx
index 1c20c2630190..8dffb4ebf57d 100644
--- a/sc/source/core/data/tabprotection.cxx
+++ b/sc/source/core/data/tabprotection.cxx
@@ -135,7 +135,7 @@ Sequence<sal_Int8> ScTableProtectionImpl::hashPassword(const OUString& aPassText
     switch (eHash)
     {
         case PASSHASH_XL:
-            aHash = ::comphelper::DocPasswordHelper::GetXLHashAsSequence( aPassText, RTL_TEXTENCODING_UTF8 );
+            aHash = ::comphelper::DocPasswordHelper::GetXLHashAsSequence( aPassText );
         break;
         case PASSHASH_SHA1:
             SvPasswordHelper::GetHashPassword(aHash, aPassText);