loplugin: defaultparams

Change-Id: I0d4b901b6678f3344ed62018d871e1630195aef0

10 files changed, 27 insertions, 32 deletions

diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index ed03cce25350..caf568785535 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -250,7 +250,7 @@ public:
     }
     virtual void GenDeclRef( std::stringstream& ss ) const SAL_OVERRIDE
     {
-        ss << GenSlidingWindowDeclRef(false);
+        ss << GenSlidingWindowDeclRef();
     }
     virtual void GenSlidingWindowDecl( std::stringstream& ss ) const SAL_OVERRIDE
     {
@@ -1801,8 +1801,8 @@ public:
         ss << ") {\n\t";
         ss << "int gid0 = get_global_id(0), i = 0;\n\t";
         ss << "double tmp = ";
-        ss << Gen2(vSubArguments[0]->GenSlidingWindowDeclRef(false),
-            vSubArguments[1]->GenSlidingWindowDeclRef(false)) << ";\n\t";
+        ss << Gen2(vSubArguments[0]->GenSlidingWindowDeclRef(),
+            vSubArguments[1]->GenSlidingWindowDeclRef()) << ";\n\t";
         ss << "return tmp;\n}";
     }
     virtual bool takeString() const SAL_OVERRIDE { return true; }
@@ -3770,7 +3770,7 @@ void DynamicKernel::CodeGen()
     decl << "(__global double *result, ";
     DK->GenSlidingWindowDecl(decl);
     decl << ") {\n\tint gid0 = get_global_id(0);\n\tresult[gid0] = " <<
-        DK->GenSlidingWindowDeclRef(false) << ";\n}\n";
+        DK->GenSlidingWindowDeclRef() << ";\n}\n";
     mFullProgramSrc = decl.str();
 #ifdef SAL_DETAIL_ENABLE_LOG_INFO
     std::stringstream area;
diff --git a/sc/source/core/opencl/opbase.cxx b/sc/source/core/opencl/opbase.cxx
index f1d7b21203cd..a8f2f9985333 100644
--- a/sc/source/core/opencl/opbase.cxx
+++ b/sc/source/core/opencl/opbase.cxx
@@ -250,7 +250,7 @@ void CheckVariables::CheckSubArgumentIsNan( std::stringstream& ss,
         ss << pTmpDVR2->GetArrayLength();
         ss << " ||";
         ss << "isNan(";
-        ss << vSubArguments[i]->GenSlidingWindowDeclRef(false);
+        ss << vSubArguments[i]->GenSlidingWindowDeclRef();
         ss << "))\n";
         ss << "        tmp";
         ss << i;
@@ -258,7 +258,7 @@ void CheckVariables::CheckSubArgumentIsNan( std::stringstream& ss,
         ss << "        tmp";
         ss << i;
         ss << "=";
-        ss << vSubArguments[i]->GenSlidingWindowDeclRef(false);
+        ss << vSubArguments[i]->GenSlidingWindowDeclRef();
         ss << ";\n";
     }
     if (vSubArguments[i]->GetFormulaToken()->GetType() == formula::svDouble ||
diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx
index fc89f9e055c4..b8785caecbda 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -3494,7 +3494,7 @@ void ScChangeTrack::UpdateReference( ScChangeAction** ppFirstAction,
                                 {
                                     pActDel->SetCutOffInsert(
                                         static_cast<ScChangeActionIns*>(p), 1 );
-                                    p->GetBigRange().aStart.IncCol( 1 );
+                                    p->GetBigRange().aStart.IncCol();
                                 }
                                 else if ( aDelRange.In( p->GetBigRange().aEnd ) )
                                 {
@@ -3511,7 +3511,7 @@ void ScChangeTrack::UpdateReference( ScChangeAction** ppFirstAction,
                                 {
                                     pActDel->SetCutOffInsert(
                                         static_cast<ScChangeActionIns*>(p), 1 );
-                                    p->GetBigRange().aStart.IncRow( 1 );
+                                    p->GetBigRange().aStart.IncRow();
                                 }
                                 else if ( aDelRange.In( p->GetBigRange().aEnd ) )
                                 {
@@ -3528,7 +3528,7 @@ void ScChangeTrack::UpdateReference( ScChangeAction** ppFirstAction,
                                 {
                                     pActDel->SetCutOffInsert(
                                         static_cast<ScChangeActionIns*>(p), 1 );
-                                    p->GetBigRange().aStart.IncTab( 1 );
+                                    p->GetBigRange().aStart.IncTab();
                                 }
                                 else if ( aDelRange.In( p->GetBigRange().aEnd ) )
                                 {
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 7c2e6aabd2ec..1adfabacd557 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2521,7 +2521,7 @@ Label_MaskStateMachine:
             {   // ?!?
                 SetError( nErr = errIllegalChar );
                 nSrcPos = aFormula.getLength();
-                aSymbol.truncate(0);
+                aSymbol.truncate();
             }
             else
             {
diff --git a/sc/source/core/tool/formulagroup.cxx b/sc/source/core/tool/formulagroup.cxx
index dfa368909f7b..f196b165c025 100644
--- a/sc/source/core/tool/formulagroup.cxx
+++ b/sc/source/core/tool/formulagroup.cxx
@@ -478,7 +478,7 @@ FormulaGroupInterpreter *FormulaGroupInterpreter::getStatic()
 #if HAVE_FEATURE_OPENCL
         const ScCalcConfig& rConfig = ScInterpreter::GetGlobalConfig();
         if (officecfg::Office::Common::Misc::UseOpenCL::get())
-            switchOpenCLDevice(rConfig.maOpenCLDevice, rConfig.mbOpenCLAutoSelect, false);
+            switchOpenCLDevice(rConfig.maOpenCLDevice, rConfig.mbOpenCLAutoSelect);
 #endif
         static bool bAllowSoftwareInterpreter = (getenv("SC_ALLOW_BROKEN_SOFTWARE_INTERPRETER") != NULL);
 
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index f95d5ebbc024..ce59e26a8cee 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -5475,7 +5475,7 @@ double ScInterpreter::IterateParametersIfs( ScIterFuncIfs eFunc )
 
                 // result matrix is filled with boolean values.
                 std::vector<double> aResValues;
-                pResultMatrix->GetDoubleArray(aResValues, true);
+                pResultMatrix->GetDoubleArray(aResValues);
                 if (aResArray.size() != aResValues.size())
                 {
                     SetError( errIllegalParameter);
@@ -7773,8 +7773,7 @@ void ScInterpreter::ScCurrency()
                                                    ScGlobal::eLnge,
                                                    true,        // mit Tausenderpunkt
                                                    false,       // nicht rot
-                                                  (sal_uInt16) fDec,// Nachkommastellen
-                                                   1);          // 1 Vorkommanull
+                                                  (sal_uInt16) fDec);// Nachkommastellen
             if (!pFormatter->GetPreviewString(sFormatString,
                                               fVal,
                                               aStr,
@@ -7861,8 +7860,7 @@ void ScInterpreter::ScFixed()
                                                ScGlobal::eLnge,
                                                bThousand,   // mit Tausenderpunkt
                                                false,       // nicht rot
-                                               (sal_uInt16) fDec,// Nachkommastellen
-                                               1);          // 1 Vorkommanull
+                                               (sal_uInt16) fDec);// Nachkommastellen
         if (!pFormatter->GetPreviewString(sFormatString,
                                                   fVal,
                                                   aStr,
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 8548f8e0744e..70c52bcee45d 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -1248,7 +1248,7 @@ ScDBRangeBase* ScInterpreter::PopDBDoubleRef()
             SCCOL nCol1, nCol2;
             SCROW nRow1, nRow2;
             SCTAB nTab1, nTab2;
-            PopDoubleRef(nCol1, nRow1, nTab1, nCol2, nRow2, nTab2, false);
+            PopDoubleRef(nCol1, nRow1, nTab1, nCol2, nRow2, nTab2);
             if (nGlobalError)
                 break;
             return new ScDBInternalRange(pDok,
@@ -4033,9 +4033,9 @@ StackVar ScInterpreter::Interpret()
                 case ocGetDiffDate      : ScGetDiffDate();              break;
                 case ocGetDiffDate360   : ScGetDiffDate360();           break;
                 case ocGetDateDif       : ScGetDateDif();               break;
-                case ocMin              : ScMin( false );               break;
+                case ocMin              : ScMin()       ;               break;
                 case ocMinA             : ScMin( true );                break;
-                case ocMax              : ScMax( false );               break;
+                case ocMax              : ScMax();                      break;
                 case ocMaxA             : ScMax( true );                break;
                 case ocSum              : ScSum();                      break;
                 case ocProduct          : ScProduct();                  break;
@@ -4043,21 +4043,21 @@ StackVar ScInterpreter::Interpret()
                 case ocIRR              : ScIRR();                      break;
                 case ocMIRR             : ScMIRR();                     break;
                 case ocISPMT            : ScISPMT();                    break;
-                case ocAverage          : ScAverage( false );           break;
+                case ocAverage          : ScAverage()       ;           break;
                 case ocAverageA         : ScAverage( true );            break;
                 case ocCount            : ScCount();                    break;
                 case ocCount2           : ScCount2();                   break;
                 case ocVar              :
-                case ocVarS             : ScVar( false );               break;
+                case ocVarS             : ScVar();                      break;
                 case ocVarA             : ScVar( true );                break;
                 case ocVarP             :
-                case ocVarP_MS          : ScVarP( false );              break;
+                case ocVarP_MS          : ScVarP();                     break;
                 case ocVarPA            : ScVarP( true );               break;
                 case ocStDev            :
-                case ocStDevS           : ScStDev( false );             break;
+                case ocStDevS           : ScStDev();                    break;
                 case ocStDevA           : ScStDev( true );              break;
                 case ocStDevP           :
-                case ocStDevP_MS        : ScStDevP( false );            break;
+                case ocStDevP_MS        : ScStDevP();                   break;
                 case ocStDevPA          : ScStDevP( true );             break;
                 case ocPV               : ScPV();                       break;
                 case ocSYD              : ScSYD();                      break;
diff --git a/sc/source/core/tool/rangelst.cxx b/sc/source/core/tool/rangelst.cxx
index 90a01ffacc1a..d4bc70e12dfa 100644
--- a/sc/source/core/tool/rangelst.cxx
+++ b/sc/source/core/tool/rangelst.cxx
@@ -1003,7 +1003,7 @@ void ScRangeList::DeleteArea( SCCOL nCol1, SCROW nRow1, SCTAB nTab1,
             continue;
     }
     for(vector<ScRange>::iterator itr = aNewRanges.begin(); itr != aNewRanges.end(); ++itr)
-        Join( *itr, false);
+        Join( *itr);
 }
 
 const ScRange* ScRangeList::Find( const ScAddress& rAdr ) const
diff --git a/sc/source/core/tool/rangeutl.cxx b/sc/source/core/tool/rangeutl.cxx
index fe8b5c089bc7..7c5f13d6f843 100644
--- a/sc/source/core/tool/rangeutl.cxx
+++ b/sc/source/core/tool/rangeutl.cxx
@@ -812,7 +812,6 @@ void ScRangeStringConverter::GetStringFromXMLRangeString( OUString& rString, con
     FormulaGrammar::AddressConvention eConv = pDoc->GetAddressConvention();
     const sal_Unicode cSep = ' ';
     const sal_Unicode cSepNew = ScCompiler::GetNativeSymbolChar(ocSep);
-    const sal_Unicode cQuote = '\'';
 
     OUStringBuffer aRetStr;
     sal_Int32 nOffset = 0;
@@ -821,11 +820,11 @@ void ScRangeStringConverter::GetStringFromXMLRangeString( OUString& rString, con
     while (nOffset >= 0)
     {
         OUString aToken;
-        GetTokenByOffset(aToken, rXMLRange, nOffset, cSep, cQuote);
+        GetTokenByOffset(aToken, rXMLRange, nOffset, cSep);
         if (nOffset < 0)
             break;
 
-        sal_Int32 nSepPos = IndexOf(aToken, ':', 0, cQuote);
+        sal_Int32 nSepPos = IndexOf(aToken, ':', 0);
         if (nSepPos >= 0)
         {
             // Cell range
@@ -840,7 +839,7 @@ void ScRangeStringConverter::GetStringFromXMLRangeString( OUString& rString, con
             if (nEndCellDotPos <= 0)
             {
                 // initialize buffer with table name...
-                sal_Int32 nDotPos = IndexOf(aBeginCell, '.', 0, cQuote);
+                sal_Int32 nDotPos = IndexOf(aBeginCell, '.', 0);
                 OUStringBuffer aBuf = aBeginCell.copy(0, nDotPos);
 
                 if (nEndCellDotPos == 0)
diff --git a/sc/source/core/tool/reftokenhelper.cxx b/sc/source/core/tool/reftokenhelper.cxx
index 04070f29225f..4c7371a35343 100644
--- a/sc/source/core/tool/reftokenhelper.cxx
+++ b/sc/source/core/tool/reftokenhelper.cxx
@@ -37,8 +37,6 @@ void ScRefTokenHelper::compileRangeRepresentation(
     vector<ScTokenRef>& rRefTokens, const OUString& rRangeStr, ScDocument* pDoc,
     const sal_Unicode cSep, FormulaGrammar::Grammar eGrammar, bool bOnly3DRef)
 {
-    const sal_Unicode cQuote = '\'';
-
     // #i107275# ignore parentheses
     OUString aRangeStr = rRangeStr;
     while( (aRangeStr.getLength() >= 2) && (aRangeStr[ 0 ] == '(') && (aRangeStr[ aRangeStr.getLength() - 1 ] == ')') )
@@ -49,7 +47,7 @@ void ScRefTokenHelper::compileRangeRepresentation(
     while (nOffset >= 0 && !bFailure)
     {
         OUString aToken;
-        ScRangeStringConverter::GetTokenByOffset(aToken, aRangeStr, nOffset, cSep, cQuote);
+        ScRangeStringConverter::GetTokenByOffset(aToken, aRangeStr, nOffset, cSep);
         if (nOffset < 0)
             break;