diff options
| author | Tor Lillqvist <tml@iki.fi> | 2012-03-02 11:03:21 +0200 |
|---|---|---|
| committer | Tor Lillqvist <tml@iki.fi> | 2012-03-02 12:09:21 +0200 |
| commit | aa8e8c6bed0824d4840ed35a676dd570264fc543 (patch) | |
| tree | a6585a2a515d7704fed31826c0d9e85d5be00131 /sc | |
| parent | 802616ed2df9ca7159dd7acff7aeba4f1fc610fa (diff) | |
WaE: expression result unused
Ifdef out a couple of weird leftover lines that effectively do
nothing. The code was changed to be like this in 2004. Could some
Calc expert have a look please and clean up? Also, if the intent
really is that bEmbed is always false, a couple of lines below it is
pointless to check if it is true anyway.
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/core/data/fillinfo.cxx | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx index ff5db74f8a42..63c453e7c937 100644 --- a/sc/source/core/data/fillinfo.cxx +++ b/sc/source/core/data/fillinfo.cxx @@ -513,13 +513,16 @@ void ScDocument::FillInfo( ScTableInfo& rTabInfo, SCCOL nX1, SCROW nY1, SCCOL nX // nWidth wird nicht mehr einzeln gesetzt bool bEmbed = false; //bIsEmbedded && +#if 0 // Huh? Is this intentional or accidental? Clang warns + // "expression result unused", so ifdef out these lines. The + // code has been like this since 2004. nTab >= aEmbedRange.aStart.Tab() && nTab <= aEmbedRange.aEnd.Tab() && nX >= aEmbedRange.aStart.Col() && nX <= aEmbedRange.aEnd.Col() && nCurRow >= aEmbedRange.aStart.Row() && nCurRow <= aEmbedRange.aEnd.Row(); - +#endif if (bScenario) { pInfo->pBackground = ScGlobal::GetButtonBrushItem(); |