diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2014-04-01 13:15:38 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2014-04-01 13:15:38 +0100 |
| commit | dc9dcb7063539921aa19d258904eaeca476aabe8 (patch) | |
| tree | a72c793e896248b9a794fd7b389cc2a761ba7974 /sc | |
| parent | 33b8636ced08abcb48c2424709db21e7a8fc27bf (diff) | |
coverity#704241 Logically dead code
Change-Id: Iabcc4cc9f68306eb0b0dadb7c9b8a27907ec6953
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/filter/oox/drawingmanager.cxx | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/sc/source/filter/oox/drawingmanager.cxx b/sc/source/filter/oox/drawingmanager.cxx index 7fe44081385c..4644d934c786 100644 --- a/sc/source/filter/oox/drawingmanager.cxx +++ b/sc/source/filter/oox/drawingmanager.cxx @@ -266,21 +266,21 @@ void BiffDrawingObjectBase::convertLineProperties( ShapePropertyMap& rPropMap, c // line ends bool bLineStart = false; - bool bLineEnd = false; + bool bArrow = false; bool bFilled = false; switch( extractValue< sal_uInt8 >( nArrows, 0, 4 ) ) { - case BIFF_OBJ_ARROW_OPEN: bLineStart = false; bLineEnd = true; bFilled = false; break; - case BIFF_OBJ_ARROW_OPENBOTH: bLineStart = true; bLineEnd = true; bFilled = false; break; - case BIFF_OBJ_ARROW_FILLED: bLineStart = false; bLineEnd = true; bFilled = true; break; - case BIFF_OBJ_ARROW_FILLEDBOTH: bLineStart = true; bLineEnd = true; bFilled = true; break; + case BIFF_OBJ_ARROW_OPEN: bLineStart = false; bArrow = true; bFilled = false; break; + case BIFF_OBJ_ARROW_OPENBOTH: bLineStart = true; bArrow = true; bFilled = false; break; + case BIFF_OBJ_ARROW_FILLED: bLineStart = false; bArrow = true; bFilled = true; break; + case BIFF_OBJ_ARROW_FILLEDBOTH: bLineStart = true; bArrow = true; bFilled = true; break; } - if( bLineStart || bLineEnd ) + if (bArrow) { // arrow type (open or closed) sal_Int32 nArrowType = bFilled ? XML_triangle : XML_arrow; + aLineProps.maEndArrow.moArrowType = nArrowType; aLineProps.maStartArrow.moArrowType = bLineStart ? nArrowType : XML_none; - aLineProps.maEndArrow.moArrowType = bLineEnd ? nArrowType : XML_none; // arrow width sal_Int32 nArrowWidth = XML_med; |