diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-05-11 17:09:13 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-05-11 17:09:13 +0200 |
| commit | 01f787a21a9dd0116545fbaa13d0a073db5b5d74 (patch) | |
| tree | 62a0065ed2170174a79ccf05ef81943d4e665fe6 /sc | |
| parent | 6356b3374788cc9e90e23dd17cc3ff536ac7fed8 (diff) | |
Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???"
Would be great if people knowing about the respective code areas could look into
these, and either change them into plain "SAL_FALLTHROUGH;" or "break;".
Change-Id: I6bd5e04bbb84452bea57d10946522b456c2ad5f0
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/drawfunc/fuins2.cxx | 1 | ||||
| -rw-r--r-- | sc/source/ui/vba/vbacondition.cxx | 1 | ||||
| -rw-r--r-- | sc/source/ui/vba/vbarange.cxx | 1 |
3 files changed, 3 insertions, 0 deletions
diff --git a/sc/source/ui/drawfunc/fuins2.cxx b/sc/source/ui/drawfunc/fuins2.cxx index 0c596e7db598..6fa3ead43578 100644 --- a/sc/source/ui/drawfunc/fuins2.cxx +++ b/sc/source/ui/drawfunc/fuins2.cxx @@ -237,6 +237,7 @@ FuInsertOLE::FuInsertOLE(ScTabViewShell* pViewSh, vcl::Window* pWin, ScDrawView* aServerLst.FillInsertObjects(); aServerLst.Remove( ScDocShell::Factory().GetClassId() ); // Starcalc nicht anzeigen //TODO/LATER: currently no inserting of ClassId into SfxRequest! + SAL_FALLTHROUGH; //TODO ??? case SID_INSERT_FLOATINGFRAME : { SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); diff --git a/sc/source/ui/vba/vbacondition.cxx b/sc/source/ui/vba/vbacondition.cxx index c3a10695262b..68a5c7d7622a 100644 --- a/sc/source/ui/vba/vbacondition.cxx +++ b/sc/source/ui/vba/vbacondition.cxx @@ -144,6 +144,7 @@ ScVbaCondition< Ifc... >::Operator(bool _bIncludeFormulaValue) throw ( script::B retvalue = ISFORMULA; break; } + SAL_FALLTHROUGH; //TODO ??? case sheet::ConditionOperator_NONE: default: DebugHelper::basicexception(ERRCODE_BASIC_METHOD_FAILED, "Operator not supported"); diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx index f13449c5ffdb..95f1d2b4d0b4 100644 --- a/sc/source/ui/vba/vbarange.cxx +++ b/sc/source/ui/vba/vbarange.cxx @@ -5460,6 +5460,7 @@ ScVbaRange::SpecialCellsImpl( sal_Int32 nType, const uno::Any& _oValue) throw ( } case excel::XlCellType::xlCellTypeLastCell: xRange = Cells( uno::makeAny( getCount() ), uno::Any() ); + SAL_FALLTHROUGH; //TODO ??? case excel::XlCellType::xlCellTypeVisible: xLocSheetCellRanges = xQuery->queryVisibleCells(); break; |