new loplugin: externalandnotdefined

Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2

12 files changed, 20 insertions, 18 deletions

diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 8ea270aa2ce3..b4d12b618248 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -98,6 +98,7 @@
 #include "documentlinkmgr.hxx"
 #include "interpre.hxx"
 #include <tokenstringcontext.hxx>
+#include "docsh.hxx"
 
 using namespace com::sun::star;
 
@@ -924,8 +925,6 @@ bool ScDocument::CopyTab( SCTAB nOldPos, SCTAB nNewPos, const ScMarkData* pOnlyM
     return bValid;
 }
 
-void VBA_InsertModule( ScDocument& rDoc, SCTAB nTab, const OUString& sModuleName, const OUString& sModuleSource );
-
 sal_uLong ScDocument::TransferTab( ScDocument* pSrcDoc, SCTAB nSrcPos,
                                 SCTAB nDestPos, bool bInsertNew,
                                 bool bResultsOnly )
diff --git a/sc/source/filter/rtf/eeimpars.cxx b/sc/source/filter/rtf/eeimpars.cxx
index 48e82e69edf5..821281d90180 100644
--- a/sc/source/filter/rtf/eeimpars.cxx
+++ b/sc/source/filter/rtf/eeimpars.cxx
@@ -52,14 +52,12 @@
 #include "progress.hxx"
 #include "stringutil.hxx"
 #include <rowheightcontext.hxx>
+#include "fuinsert.hxx"
 
 #include "globstr.hrc"
 
 #include <boost/scoped_ptr.hpp>
 
-// in fuins1.cxx
-extern void ScLimitSizeOnDrawPage( Size& rSize, Point& rPos, const Size& rPage );
-
 ScEEImport::ScEEImport( ScDocument* pDocP, const ScRange& rRange ) :
     maRange( rRange ),
     mpDoc( pDocP ),
diff --git a/sc/source/ui/docshell/docsh5.cxx b/sc/source/ui/docshell/docsh5.cxx
index 7d0698119dda..a46e4266d416 100644
--- a/sc/source/ui/docshell/docsh5.cxx
+++ b/sc/source/ui/docshell/docsh5.cxx
@@ -54,9 +54,6 @@
 #include <rowheightcontext.hxx>
 #include <refupdatecontext.hxx>
 
-// defined in docfunc.cxx
-void VBA_InsertModule( ScDocument& rDoc, SCTAB nTab, const OUString& sModuleName, const OUString& sModuleSource );
-
 using com::sun::star::script::XLibraryContainer;
 using com::sun::star::script::vba::XVBACompatibility;
 using com::sun::star::container::XNameContainer;
diff --git a/sc/source/ui/drawfunc/drawsh2.cxx b/sc/source/ui/drawfunc/drawsh2.cxx
index 311c1f129865..54a6ee8ddea5 100644
--- a/sc/source/ui/drawfunc/drawsh2.cxx
+++ b/sc/source/ui/drawfunc/drawsh2.cxx
@@ -45,14 +45,13 @@
 #include "document.hxx"
 #include "drwlayer.hxx"
 #include "userdat.hxx"
+#include "drtxtob.hxx"
 #include <gridwin.hxx>
 #include <svx/svdoole2.hxx>
 #include <svx/svdocapt.hxx>
 
 #include <boost/bind.hpp>
 
-sal_uInt16 ScGetFontWorkId();       // in drtxtob
-
 using namespace com::sun::star;
 
 ScDrawShell::ScDrawShell( ScViewData* pData ) :
diff --git a/sc/source/ui/drawfunc/drawsh5.cxx b/sc/source/ui/drawfunc/drawsh5.cxx
index 77058fa448c3..4cac58cfe32b 100644
--- a/sc/source/ui/drawfunc/drawsh5.cxx
+++ b/sc/source/ui/drawfunc/drawsh5.cxx
@@ -55,6 +55,7 @@
 #include "drwlayer.hxx"
 #include "userdat.hxx"
 #include "postit.hxx"
+#include "drtxtob.hxx"
 #include <boost/scoped_ptr.hpp>
 
 #include "sc.hrc"
@@ -239,8 +240,6 @@ void ScDrawShell::ExecuteHLink( SfxRequest& rReq )
     }
 }
 
-sal_uInt16 ScGetFontWorkId();
-
 //          Funktionen auf Drawing-Objekten
 
 void ScDrawShell::ExecDrawFunc( SfxRequest& rReq )
diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx
index e603841e5b33..5dc4d06a5d5e 100644
--- a/sc/source/ui/inc/docfunc.hxx
+++ b/sc/source/ui/inc/docfunc.hxx
@@ -231,6 +231,8 @@ public:
     virtual ~ScDocFuncDirect() {}
 };
 
+void VBA_DeleteModule( ScDocShell& rDocSh, const OUString& sModuleName );
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/docsh.hxx b/sc/source/ui/inc/docsh.hxx
index 36731fedb73c..46bd07ebc8f4 100644
--- a/sc/source/ui/inc/docsh.hxx
+++ b/sc/source/ui/inc/docsh.hxx
@@ -506,6 +506,8 @@ namespace HelperNotifyChanges
     }
 };
 
+void VBA_InsertModule( ScDocument& rDoc, SCTAB nTab, const OUString& sModuleName, const OUString& sModuleSource );
+
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/fuinsert.hxx b/sc/source/ui/inc/fuinsert.hxx
index a93dd0495dea..6d30688b12f6 100644
--- a/sc/source/ui/inc/fuinsert.hxx
+++ b/sc/source/ui/inc/fuinsert.hxx
@@ -21,6 +21,7 @@
 #define INCLUDED_SC_SOURCE_UI_INC_FUINSERT_HXX
 
 #include "fupoor.hxx"
+#include "scdllapi.h"
 
 class FuInsertGraphic : public FuPoor
 {
@@ -74,6 +75,8 @@ class FuInsertMedia : public FuPoor
     virtual void Deactivate() SAL_OVERRIDE;
 };
 
+void SC_DLLPUBLIC ScLimitSizeOnDrawPage( Size& rSize, Point& rPos, const Size& rPage );
+
 #endif      // _SD_FUINSERT_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/vba/vbapagesetup.cxx b/sc/source/ui/vba/vbapagesetup.cxx
index 6f9d7ee8812a..d6717563809d 100644
--- a/sc/source/ui/vba/vbapagesetup.cxx
+++ b/sc/source/ui/vba/vbapagesetup.cxx
@@ -21,6 +21,7 @@
 #include "convuno.hxx"
 #include "rangelst.hxx"
 #include "excelvbahelper.hxx"
+#include "vbarange.hxx"
 #include <com/sun/star/sheet/XPrintAreas.hpp>
 #include <com/sun/star/sheet/XHeaderFooterContent.hpp>
 #include <com/sun/star/text/XText.hpp>
@@ -40,8 +41,6 @@ using namespace ::ooo::vba;
 #define ZOOM_IN 10
 #define ZOOM_MAX 400
 
-bool getScRangeListForAddress( const OUString& sName, ScDocShell* pDocSh, ScRange& refRange, ScRangeList& aCellRanges, formula::FormulaGrammar::AddressConvention aConv = formula::FormulaGrammar::CONV_XL_A1 ) throw ( uno::RuntimeException );
-
 ScVbaPageSetup::ScVbaPageSetup(const uno::Reference< XHelperInterface >& xParent,
                 const uno::Reference< uno::XComponentContext >& xContext,
                 const uno::Reference< sheet::XSpreadsheet >& xSheet,
diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx
index 0908823b865d..b5ddb21761ac 100644
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -1162,7 +1162,7 @@ ScVbaRange::getCellRangesForAddress( sal_uInt16& rResFlags, const OUString& sAdd
     return false;
 }
 
-bool getScRangeListForAddress( const OUString& sName, ScDocShell* pDocSh, ScRange& refRange, ScRangeList& aCellRanges, formula::FormulaGrammar::AddressConvention aConv = formula::FormulaGrammar::CONV_XL_A1 ) throw ( uno::RuntimeException )
+bool getScRangeListForAddress( const OUString& sName, ScDocShell* pDocSh, ScRange& refRange, ScRangeList& aCellRanges, formula::FormulaGrammar::AddressConvention aConv ) throw ( uno::RuntimeException )
 {
     // see if there is a match with a named range
     uno::Reference< beans::XPropertySet > xProps( pDocSh->GetModel(), uno::UNO_QUERY_THROW );
diff --git a/sc/source/ui/vba/vbarange.hxx b/sc/source/ui/vba/vbarange.hxx
index 5c1227609a34..32d13900b287 100644
--- a/sc/source/ui/vba/vbarange.hxx
+++ b/sc/source/ui/vba/vbarange.hxx
@@ -50,6 +50,7 @@ class ScCellRangeObj;
 class ScDocShell;
 class ScDocument;
 class ScRangeList;
+class ScRange;
 
 typedef ScVbaFormat< ov::excel::XRange > ScVbaRange_BASE;
 
@@ -297,6 +298,12 @@ public:
     virtual OUString getServiceImplName() SAL_OVERRIDE;
     virtual css::uno::Sequence<OUString> getServiceNames() SAL_OVERRIDE;
 };
+
+bool getScRangeListForAddress( const OUString& sName, ScDocShell* pDocSh, ScRange& refRange,
+                               ScRangeList& aCellRanges,
+                               formula::FormulaGrammar::AddressConvention aConv = formula::FormulaGrammar::CONV_XL_A1 )
+    throw ( css::uno::RuntimeException );
+
 #endif // INCLUDED_SC_SOURCE_UI_VBA_VBARANGE_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index 4bfb03835ebc..eb868acb17b1 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -95,9 +95,6 @@ using ::editeng::SvxBorderLine;
 using ::std::vector;
 using ::std::auto_ptr;
 
-// helper func defined in docfunc.cxx
-void VBA_DeleteModule( ScDocShell& rDocSh, const OUString& sModuleName );
-
 // STATIC DATA ---------------------------------------------------------------
 
 bool ScViewFunc::AdjustBlockHeight( bool bPaint, ScMarkData* pMarkData )