summaryrefslogtreecommitdiff
path: root/sc
diff options
context:
space:
mode:
authorEike Rathke <erack@redhat.com>2014-12-09 14:45:45 +0100
committerEike Rathke <erack@redhat.com>2014-12-09 14:54:44 +0100
commit3397cb614205c6954915c88005276ba38fbae5ce (patch)
tree535e7cd53e16559f4f3b4ed2c39b3d3d1a298870 /sc
parent6b5481c0260343800518192918ddf932ee5ae527 (diff)
add a comment about side effects and whether we want them or not
Change-Id: I9cebe8f7979fd0b502fb23e7048b24a5b9ceb5d4
Diffstat (limited to 'sc')
-rw-r--r--sc/source/core/data/document.cxx4
1 files changed, 4 insertions, 0 deletions
diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 248cc9da9229..311f7b7e47c1 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -3630,6 +3630,10 @@ void ScDocument::SetDirty( const ScRange& rRange, bool bIncludeEmptyCells )
if (maTabs[i]) maTabs[i]->SetDirty( rRange,
(bIncludeEmptyCells ? ScColumn::BROADCAST_BROADCASTERS : ScColumn::BROADCAST_DATA_POSITIONS));
+ /* TODO: this now also notifies conditional formatting and does an UNO
+ * broadcast, which wasn't done here before. Is that an actually
+ * desired side effect, or should we come up with a method that
+ * doesn't? */
if (bIncludeEmptyCells)
BroadcastCells( rRange, SC_HINT_DATACHANGED, false);
}