diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-06-14 10:41:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-06-14 11:37:35 +0200 |
commit | 8303e7ed668fbcbd0ba75bd9dd259f03073ffd46 (patch) | |
tree | bfcbb0f58c0fd8cbd5c03d93fc5b1d4ab3ef817b /sc | |
parent | a64692944a0a22feeef4a943d45137b25494cf64 (diff) |
loplugin:unusedfields improvements
tighten up the only calling write-only methods part of the analysis
Change-Id: I5bc6fdf0ce51940653317e8a48c5241705c90d4c
Reviewed-on: https://gerrit.libreoffice.org/74022
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc')
-rw-r--r-- | sc/source/filter/excel/frmbase.cxx | 8 | ||||
-rw-r--r-- | sc/source/filter/inc/formel.hxx | 4 | ||||
-rw-r--r-- | sc/source/filter/qpro/qproform.cxx | 2 | ||||
-rw-r--r-- | sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx | 1 | ||||
-rw-r--r-- | sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx | 3 | ||||
-rw-r--r-- | sc/source/ui/inc/tabvwsh.hxx | 1 | ||||
-rw-r--r-- | sc/source/ui/view/tabvwsh4.cxx | 2 |
7 files changed, 5 insertions, 16 deletions
diff --git a/sc/source/filter/excel/frmbase.cxx b/sc/source/filter/excel/frmbase.cxx index 9fbd5489487f..35bba553997e 100644 --- a/sc/source/filter/excel/frmbase.cxx +++ b/sc/source/filter/excel/frmbase.cxx @@ -148,12 +148,10 @@ const ScRange* ScRangeListTabs::Next () return &(*maItrCur); } -ConverterBase::ConverterBase( svl::SharedStringPool& rSPool, sal_uInt16 nNewBuffer ) : +ConverterBase::ConverterBase( svl::SharedStringPool& rSPool ) : aPool(rSPool), aEingPos( 0, 0, 0 ) { - OSL_ENSURE( nNewBuffer > 0, "ConverterBase::ConverterBase - nNewBuffer == 0!" ); - pBuffer.reset( new sal_Char[ nNewBuffer ] ); } ConverterBase::~ConverterBase() @@ -167,7 +165,7 @@ void ConverterBase::Reset() } ExcelConverterBase::ExcelConverterBase( svl::SharedStringPool& rSPool ) : - ConverterBase(rSPool, 512) + ConverterBase(rSPool) { } @@ -188,7 +186,7 @@ void ExcelConverterBase::Reset() } LotusConverterBase::LotusConverterBase( SvStream &rStr, svl::SharedStringPool& rSPool ) : - ConverterBase(rSPool, 128), + ConverterBase(rSPool), aIn( rStr ), nBytesLeft( 0 ) { diff --git a/sc/source/filter/inc/formel.hxx b/sc/source/filter/inc/formel.hxx index bda80896809e..3dea5ea572cd 100644 --- a/sc/source/filter/inc/formel.hxx +++ b/sc/source/filter/inc/formel.hxx @@ -79,10 +79,8 @@ protected: TokenPool aPool; // user token + predefined token TokenStack aStack; ScAddress aEingPos; - std::unique_ptr<sal_Char[]> - pBuffer; // universal buffer - ConverterBase( svl::SharedStringPool& rSPool, sal_uInt16 nNewBuffer ); + ConverterBase( svl::SharedStringPool& rSPool ); virtual ~ConverterBase(); void Reset(); diff --git a/sc/source/filter/qpro/qproform.cxx b/sc/source/filter/qpro/qproform.cxx index bd1ea7fc092a..e549c0356917 100644 --- a/sc/source/filter/qpro/qproform.cxx +++ b/sc/source/filter/qpro/qproform.cxx @@ -62,7 +62,7 @@ void QProToSc::ReadSRD( ScSingleRefData& rSRD, sal_Int8 nPage, sal_Int8 nCol, sa } QProToSc::QProToSc( SvStream& rStream, svl::SharedStringPool& rSPool, const ScAddress& rRefPos ) : - ConverterBase(rSPool, 128), + ConverterBase(rSPool), maIn( rStream ) { aEingPos = rRefPos; diff --git a/sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx b/sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx index 51e45769ce4c..4502e7ec699f 100644 --- a/sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx +++ b/sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx @@ -45,7 +45,6 @@ ScChangeTrackingExportHelper::ScChangeTrackingExportHelper(ScXMLExport& rTempExp pEditTextObj(nullptr) { pChangeTrack = rExport.GetDocument() ? rExport.GetDocument()->GetChangeTrack() : nullptr; - pDependings.reset( new ScChangeActionMap ); } ScChangeTrackingExportHelper::~ScChangeTrackingExportHelper() diff --git a/sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx b/sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx index fb5ccaf6bb24..9ca715360cf1 100644 --- a/sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx +++ b/sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx @@ -35,15 +35,12 @@ class ScChangeActionDel; class ScBigRange; class ScEditEngineTextObj; -typedef std::map<sal_uLong, ScChangeAction*> ScChangeActionMap; - class ScChangeTrackingExportHelper { ScXMLExport& rExport; ScChangeTrack* pChangeTrack; ScEditEngineTextObj* pEditTextObj; - std::unique_ptr<ScChangeActionMap> pDependings; css::uno::Reference<css::text::XText> xText; static OUString GetChangeID(const sal_uInt32 nActionNumber); diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx index 7d51dbc5c7fa..3aa575aaa0da 100644 --- a/sc/source/ui/inc/tabvwsh.hxx +++ b/sc/source/ui/inc/tabvwsh.hxx @@ -122,7 +122,6 @@ private: Point aWinPos; ScTabViewTarget aTarget; - std::unique_ptr<ScArea> pPivotSource; std::unique_ptr<ScDPObject> pDialogDPObject; std::unique_ptr<ScNavigatorSettings> pNavSettings; diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx index 46259a8f12a3..b1a24d27df93 100644 --- a/sc/source/ui/view/tabvwsh4.cxx +++ b/sc/source/ui/view/tabvwsh4.cxx @@ -1449,7 +1449,6 @@ void ScTabViewShell::Construct( TriState nForceDesignMode ) SetWindow( GetActiveWin() ); pCurFrameLine.reset( new ::editeng::SvxBorderLine(&aColBlack, 20, SvxBorderLineStyle::SOLID) ); - pPivotSource.reset( new ScArea ); StartListening(*GetViewData().GetDocShell(), DuplicateHandling::Prevent); StartListening(*GetViewFrame(), DuplicateHandling::Prevent); StartListening(*pSfxApp, DuplicateHandling::Prevent); // #i62045# #i62046# application is needed for Calc's own hints @@ -1778,7 +1777,6 @@ ScTabViewShell::~ScTabViewShell() pAuditingShell.reset(); pCurFrameLine.reset(); mpInputHandler.reset(); - pPivotSource.reset(); pDialogDPObject.reset(); pNavSettings.reset(); |