diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 08:37:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 11:20:07 +0200 |
| commit | c0cc59adca23580864a2e5cdadf66212246cbfcc (patch) | |
| tree | 57413c8efb3ca4a59f3699592353da1c575e345d /sc | |
| parent | 4bf2052e9dbdfcd32a749747c918f2d714010633 (diff) | |
loplugin:singlevalfields improvement
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr
Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/ui/sidebar/CellLineStyleValueSet.cxx | 7 | ||||
| -rw-r--r-- | sc/source/ui/sidebar/CellLineStyleValueSet.hxx | 2 |
2 files changed, 0 insertions, 9 deletions
diff --git a/sc/source/ui/sidebar/CellLineStyleValueSet.cxx b/sc/source/ui/sidebar/CellLineStyleValueSet.cxx index 3123a60b3541..0fdf65f1f636 100644 --- a/sc/source/ui/sidebar/CellLineStyleValueSet.cxx +++ b/sc/source/ui/sidebar/CellLineStyleValueSet.cxx @@ -25,7 +25,6 @@ namespace sc { namespace sidebar { CellLineStyleValueSet::CellLineStyleValueSet(vcl::Window* pParent) : ValueSet(pParent, WB_TABSTOP) - , pVDev(nullptr) , nSelItem(0) { SetColCount(); @@ -37,12 +36,6 @@ CellLineStyleValueSet::~CellLineStyleValueSet() disposeOnce(); } -void CellLineStyleValueSet::dispose() -{ - pVDev.disposeAndClear(); - ValueSet::dispose(); -} - Size CellLineStyleValueSet::GetOptimalSize() const { return LogicToPixel(Size(80, 12 * 9), MapMode(MapUnit::MapAppFont)); diff --git a/sc/source/ui/sidebar/CellLineStyleValueSet.hxx b/sc/source/ui/sidebar/CellLineStyleValueSet.hxx index edc3c8a15ab1..b01a9e1464b1 100644 --- a/sc/source/ui/sidebar/CellLineStyleValueSet.hxx +++ b/sc/source/ui/sidebar/CellLineStyleValueSet.hxx @@ -29,13 +29,11 @@ namespace sc { namespace sidebar { class CellLineStyleValueSet : public ValueSet { private: - VclPtr<VirtualDevice> pVDev; sal_uInt16 nSelItem; OUString maStrUnit[CELL_LINE_STYLE_ENTRIES]; public: explicit CellLineStyleValueSet(vcl::Window* pParent); virtual ~CellLineStyleValueSet() override; - virtual void dispose() override; void SetUnit(const OUString* str); void SetSelItem(sal_uInt16 nSel); |