diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-13 09:55:51 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-08-15 08:37:15 +0200 |
| commit | d5f9675c2dba0c2e8993078946ee669e1d61b086 (patch) | |
| tree | 7149756d02926b64c4ead0ab77703dc5274f5e52 /sc | |
| parent | 619a6fc90d9682d859e43e5297d32a0f98738c0f (diff) | |
loplugin:returnconstant in ScDetectiveFunc
Change-Id: Id6eef7772b32a93d43d0417c5b6e24d9189c4e73
Reviewed-on: https://gerrit.libreoffice.org/58955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/inc/detfunc.hxx | 4 | ||||
| -rw-r--r-- | sc/source/core/tool/detfunc.cxx | 22 |
2 files changed, 13 insertions, 13 deletions
diff --git a/sc/inc/detfunc.hxx b/sc/inc/detfunc.hxx index a91871560445..e0afe1ce8eb0 100644 --- a/sc/inc/detfunc.hxx +++ b/sc/inc/detfunc.hxx @@ -80,12 +80,12 @@ class SC_DLLPUBLIC ScDetectiveFunc bool HasError( const ScRange& rRange, ScAddress& rErrPos ); /// called from DrawEntry/DrawAlienEntry and InsertObject - bool InsertArrow( SCCOL nCol, SCROW nRow, + void InsertArrow( SCCOL nCol, SCROW nRow, SCCOL nRefStartCol, SCROW nRefStartRow, SCCOL nRefEndCol, SCROW nRefEndRow, bool bFromOtherTab, bool bRed, ScDetectiveData& rData ); - bool InsertToOtherTab( SCCOL nStartCol, SCROW nStartRow, + void InsertToOtherTab( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW nEndRow, bool bRed, ScDetectiveData& rData ); diff --git a/sc/source/core/tool/detfunc.cxx b/sc/source/core/tool/detfunc.cxx index a356ee396c09..c45e0e4a13ab 100644 --- a/sc/source/core/tool/detfunc.cxx +++ b/sc/source/core/tool/detfunc.cxx @@ -438,7 +438,7 @@ bool ScDetectiveFunc::IsNonAlienArrow( const SdrObject* pObject ) // InsertXXX: called from DrawEntry/DrawAlienEntry and InsertObject -bool ScDetectiveFunc::InsertArrow( SCCOL nCol, SCROW nRow, +void ScDetectiveFunc::InsertArrow( SCCOL nCol, SCROW nRow, SCCOL nRefStartCol, SCROW nRefStartRow, SCCOL nRefEndCol, SCROW nRefEndRow, bool bFromOtherTab, bool bRed, @@ -517,10 +517,9 @@ bool ScDetectiveFunc::InsertArrow( SCCOL nCol, SCROW nRow, pData->meType = ScDrawObjData::DetectiveArrow; Modified(); - return true; } -bool ScDetectiveFunc::InsertToOtherTab( SCCOL nStartCol, SCROW nStartRow, +void ScDetectiveFunc::InsertToOtherTab( SCCOL nStartCol, SCROW nStartRow, SCCOL nEndCol, SCROW nEndRow, bool bRed, ScDetectiveData& rData ) { @@ -583,7 +582,6 @@ bool ScDetectiveFunc::InsertToOtherTab( SCCOL nStartCol, SCROW nStartRow, pData->maEnd.SetInvalid(); Modified(); - return true; } // DrawEntry: formula from this spreadsheet, @@ -604,10 +602,11 @@ bool ScDetectiveFunc::DrawEntry( SCCOL nCol, SCROW nRow, bool bError = HasError( rRef, aErrorPos ); bool bAlien = ( rRef.aEnd.Tab() < nTab || rRef.aStart.Tab() > nTab ); - return InsertArrow( nCol, nRow, - rRef.aStart.Col(), rRef.aStart.Row(), - rRef.aEnd.Col(), rRef.aEnd.Row(), - bAlien, bError, rData ); + InsertArrow( nCol, nRow, + rRef.aStart.Col(), rRef.aStart.Row(), + rRef.aEnd.Col(), rRef.aEnd.Row(), + bAlien, bError, rData ); + return true; } bool ScDetectiveFunc::DrawAlienEntry( const ScRange& rRef, @@ -619,9 +618,10 @@ bool ScDetectiveFunc::DrawAlienEntry( const ScRange& rRef, ScAddress aErrorPos; bool bError = HasError( rRef, aErrorPos ); - return InsertToOtherTab( rRef.aStart.Col(), rRef.aStart.Row(), - rRef.aEnd.Col(), rRef.aEnd.Row(), - bError, rData ); + InsertToOtherTab( rRef.aStart.Col(), rRef.aStart.Row(), + rRef.aEnd.Col(), rRef.aEnd.Row(), + bError, rData ); + return true; } void ScDetectiveFunc::DrawCircle( SCCOL nCol, SCROW nRow, ScDetectiveData& rData ) |