summaryrefslogtreecommitdiff
path: root/scaddins
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2017-12-08 17:52:56 +0300
committerMike Kaganski <mike.kaganski@collabora.com>2017-12-11 11:58:24 +0100
commit0f9a596aa853b4f2beeff25c131246a7b31492a4 (patch)
tree1145ce12578a21c151510dee03a5aefae9844276 /scaddins
parent12efb01e38f94992ce746d20d40410229c431225 (diff)
tdf#114333: consider trleft for 1st cell width on import; don't...
... recalculate cell widths by factor pagewidth/tablewidth on export This makes the import and export symmetrical. Unit test included. Some existing unit tests were updated: - testTdf97035: the previous width of B1 cell (3571 twips) was not stable enough on round-trip. Old code saved table with wrong width, and incidentally that made it to output correct width of the cell. New code outputs table width correctly, and drops unneeded cell width adjustment on export, so the rounding error on initial import makes output cell width wrong. We have a cumbersome arithmetics to import cell widths from RTF: 1. In DomainMapperTableManager::sprm (case NS_ooxml::LN_CT_TblGridBase_gridCol) we do convertTwipToMM100 on initial sizes in twips; 2. Then, in DomainMapperTableManager::endOfRowAction, we do rtl::math::round((fGridWidth * 10000) / nFullWidthRelative) on the mm100 sizes (the 10000 is UNO_TABLE_COLUMN_SUM from unotbl.cxx, which allows to measure cell widths in 100ths of percent of table's width instead of absolute sizes) 3. Last, in SwTable::NewSetTabCols, we do lcl_MulDiv64<long>(nNewPos, rParm.nNewWish, nNewWidth) where rParm.nNewWish is table's width in twips (again), and nNewWidth is 10000. So, the three permutations give us twips back, but rounding errors may make result differ from initial value (as in case of cell width 1927 twips and table width 15527 twips, which results in 1926). The unstable width that resulted in roundtrip error was changed by 1. The changed unit test file is checked to still correctly test tdf#97035 - testFdo55525: previously, the testdoc was imported with wrong width (too narrow); that caused rounding error on cell width calculation. Current tested value is more correct. Change-Id: I69112521c35b316ed6df11d5e4ff7336534164bd Reviewed-on: https://gerrit.libreoffice.org/46094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'scaddins')
0 files changed, 0 insertions, 0 deletions
w/unoshap3.cxx?h=cp-6.0-14&id=9fa75f677a7b48a2177fe11cca0d00f5a2deb7da'>loplugin:mergeclasses merge E3dScene with E3dPolySceneNoel Grandin Change-Id: I70f28fb4c87ad8c0e0ad46f4ce04914b6536d6b9 Reviewed-on: https://gerrit.libreoffice.org/36376 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> 2017-02-19Typos: mainly translation remnants of Objekt instead of objectJulien Nabet Change-Id: I84c488a4a0fa96f85158d34035a16aa5e10c7c21 Reviewed-on: https://gerrit.libreoffice.org/34418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Fakabbir Amin (Aeimi) <fakabbir@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> 2017-02-06Add missing #includesStephan Bergmann ...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067 2017-01-26Remove dynamic exception specificationsStephan Bergmann ...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> 2017-01-14coverity#1398585 Uncaught exceptionCaolán McNamara and coverity#1398587 Uncaught exception coverity#1398588 Uncaught exception coverity#1398589 Uncaught exception coverity#1398590 Uncaught exception coverity#1398592 Uncaught exception Change-Id: I603fc492df9215e0d67419640afc3d6a2af28c10 2016-11-18includes should be at the top of the fileNoel Grandin not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> 2016-08-23convert SdrIterMode to scoped enumNoel Grandin Change-Id: Iaa4631039e6b96627d8e547f21136f107e157d8a 2016-07-15Improve loplugin:unnecessaryoverrideStephan Bergmann <sberg> thorsten, remember what that "TODO" in SvxAccessibleTextPropertySet::getSupportedServiceNames was to be about exactly, in a909acb7009acadffa53e74ea05ddb88803490f1 ? <thorsten> sberg: that's a nonsense, prolly copy'n'pasted, or a 'please review me' <sberg> thorsten, OK, thanks (that override will eventually go away with loplugin:unnecessaryoverride, and the TODO comment be lost) Change-Id: Iba964c61768459aac4067bbd4e1f7d4f78f6adac Reviewed-on: https://gerrit.libreoffice.org/27232 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> 2016-06-12convert more DBG_ASSERT(false to SAL_WARNNoel Grandin Change-Id: Ie52f28f28c67a91c4d3d4517d5c6a466890c7a55 Reviewed-on: https://gerrit.libreoffice.org/26195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> 2016-05-04use Any constructor instead of temporariesNoel Grandin Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a 2016-04-27-Werror,-WvarargsStephan Bergmann "passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just replace the variadic function with one taking an initializer list Change-Id: Ied3dfe835dcebef48cf35374ec4d8835f98e6779 2016-04-18Avoid reserved identifier (_CreateSdrObject -> CreateSdrObject_)Stephan Bergmann Change-Id: Iee63999e4953a083783cb5c9811640150616472d 2016-02-09Remove excess newlinesChris Sherlock A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> 2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann Change-Id: I71682f28c6a54d33da6b0c971f34d0a705ff04f5 2015-10-31com::sun::star->css in svxNoel Grandin Change-Id: If2c11fa548c5ebef2297d2491edd837b54e3707c Reviewed-on: https://gerrit.libreoffice.org/19690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> 2015-10-01tdf#94559: third step to remove rtti.hxxOliver Specht replaced use of PTR_CAST, IS_TYPE, ISA in oox, reportdesign, svl, svtools, svx, tools Change-Id: I1f85ff92267a0668eba625fa61b4f07feb8f3d4e Reviewed-on: https://gerrit.libreoffice.org/19002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de> 2015-04-01Replace remaining getCppuType et al with cppu::UnoTypeStephan Bergmann Change-Id: I4791f064f223487ce57e68f8e0b1e3d74e66e868 2015-02-12fdo#39468 translated german commentsDaniel Sikeler also translated some error messages Change-Id: I22ef6b6cc01ba310d1ca694c7fcbf0d968a2fdf8 Reviewed-on: https://gerrit.libreoffice.org/14432 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> 2014-11-07coverity#1251176 Uncaught exceptionCaolán McNamara Change-Id: Ibeedfcb59e3a249c066a9c0f5dd3fcced9beed90 2014-10-20loplugin: cstylecastNoel Grandin Change-Id: I2cb764db97469654f977de63e273874d43745bf8 2014-10-06loplugin: cstylecastNoel Grandin Change-Id: Id2b5b2510fb13f77592d7a0455f34ccd8a20c2d7 2014-09-01Consistency around SfxUInt32Item in svx/svx3ditems.hxxStephan Bergmann ...similar to what has been done for svx/sdtmfitm.hxx in 68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem." Change-Id: I3193eab34a34c051002adeedd8b368e26f55f7a3 2014-08-19svx: Cleanup ASCII art and useless commentsChris Laplante Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71 Reviewed-on: https://gerrit.libreoffice.org/11011 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> 2014-08-16Consistently use size_t and SAL_MAX_SIZEMatteo Casalin Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec 2014-06-17coverity#1209942 Uncaught exceptionCaolán McNamara Change-Id: Ice7a4802605fbe59dfb24a27408106756a3494ba 2014-05-27coverity#1209949 Uncaught exceptionCaolán McNamara Change-Id: I968c5cd5929e2587588f0e0547352acdc19e456a 2014-05-23coverity#1209950 Uncaught exceptionCaolán McNamara Change-Id: I92da2ae224bab6d4781463c096a35ecaec6fecc8 2014-05-20Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part18Julien Nabet Change-Id: Ibf958dbfbf7cdbe6ad31d390138be8d4d468c225 2014-05-06Move headers included only in svx itself from include/svx to svx/incTor Lillqvist Change-Id: Ib735e6566981232fec8b13c81a2de11a6b21dfe7 2014-04-30coverity#1210119 Uncaught exceptionCaolán McNamara Change-Id: Ibbf45bb58a0e5c4bea1b3432bee104c8d5aea3f2 2014-04-30coverity#1210120 Uncaught exceptionCaolán McNamara Change-Id: I08645981a8d4d54fb6eb90489739204c4e34f883 2014-04-30coverity#1210121 Uncaught exceptionCaolán McNamara Change-Id: Ib64ba845f2f59b7db95f43acd14c45a139c17899 2014-04-15svx: sal_Bool->boolNoel Grandin Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e 2014-03-10svx: simplify deprecated XTypeProvider.getImplementationIdStephan Bergmann Change-Id: I520563a98c1285fed97174d2aaedfdd042ca699f 2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3 2014-02-23Remove unneccessary commentsAlexander Wilms Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> 2014-01-28bool improvementsStephan Bergmann Change-Id: Ic32faa81bfbb66a9d8632fb3db187e33c31188ed 2013-04-17sal_Bool to boolTakeshi Abe Change-Id: Id2ba5cf09227945fd97ef6f7e63cb40fa6488886 2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09