summaryrefslogtreecommitdiff
path: root/schema
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2017-12-24 00:28:30 +0300
committerMiklos Vajna <vmiklos@collabora.co.uk>2018-01-09 09:41:32 +0100
commitf73df3fa98258fb5208a1295c0ae5c56d3c0b315 (patch)
tree104dbeac7914c65fdac278e567fd8c72218c4d65 /schema
parent8fb6d980868bc08b1eef4c95bd820131c2b03640 (diff)
tdf#114663: consider left/right page numbers when not printing blanks
Commit 3c1a343f6936f1dcefdf79a677f8c26ce29676e6 made it possible to use document pages' sequential number (unaffected by automatically inserted blank pages) in Pages input box when not printing blank pages. But the implementation didn't take into account the case when only left/right pages were printed. In this case, it treated the unprinted right/left pages same way as automatic blanks, i.e., excluded they from page numbering, so that e.g. when user entered 10-20 (when selected even pages), actually printed 11 pages from tenth even page (#20 in original document) till twenteeth even page (#40). Expected result (familiar from other applications, and worked before the commit) is to print 6 pages with even numbers, that are in the pages range 10-20 of original document (10,12,14,16,18,20). Now we consistently use StringRangeEnumerator::getRangesFromString after converting user input with page numbers conditionally referring either physical pages, or pages without blanks, to equivalent range string referring physical pages. This preprocessing of range string also ensures correct enumerating later (when StringRangeEnumerator is created based on this string, e.g., for processing of PostIts). Change-Id: I2381699bc4c37841bf9ce789cdad03141dd72255 Reviewed-on: https://gerrit.libreoffice.org/47030 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 230d3d6602e80fad0ceb700da35fc0c1db28f110) Reviewed-on: https://gerrit.libreoffice.org/47053 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Diffstat (limited to 'schema')
0 files changed, 0 insertions, 0 deletions