summaryrefslogtreecommitdiff
path: root/scp2
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2022-05-05 20:18:06 +0200
committerMiklos Vajna <vmiklos@collabora.com>2022-07-01 15:16:21 +0200
commit9f7587debb684688ddb29a90a172e9a3067d2ba1 (patch)
treeeca0f7fcdbb6abaa3e9cfed9c4267e732be2a025 /scp2
parentff0eb613d8379e68eaf1754273b314afd28e0b00 (diff)
tdf#148929 sd theme: limit PPTX import for shape fill effects to lum mod/off
Regression from 30735bdb5a0a81619000fdd24b2d0fbf45687f01 (sd theme: add PPTX import for shape fill color effects, 2022-04-27), the bugdoc's A2 cell lost its tinting (its background color is no longer lighter than A1) after saving back to PPTX + import again. The code assumed that in case a fill color has effects, it can only be luminance offset or modulation, since that's what the PowerPoint UI generates when setting a fill color explicitly. This did not take the table style case into account, which uses tinting to make a color lighter. Fix the problem by not importing the theme index / effects if tinting is used -- the current doc model is limited to theme index + lum mod/off with effects. This limitation can be removed while text color / fill color effects are not limited to lum mod/off, but also support tinting/shading. (cherry picked from commit f932b00f3a72dd802a6e50af84c3dc55072a22a0) Change-Id: I382cc0067518cc262e261a462999170cb7db261b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136731 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'scp2')
0 files changed, 0 insertions, 0 deletions