scripting: replace StringBuffer with StringBuilder method

In JDK 1.3, StringBuffer makes the String concatenations faster.

public String concat(String s1, String s2) {
StringBuffer sb = new StringBuffer();
sb.append(s1);
sb.append(s2);
return sb.toString();
}

JDK 1.5 comes with StringBuilder (which is faster than StringBuffer) and the method:

public String concat(String s1, String s2) {
return s1 + s2;
}

is translated to:

public String concat(String s1, String s2) {
return new StringBuilder().append(s1).append(s2).toString();
}

Change-Id: I2924fcdf23d7ffbb567d9e924d02edcab4d21be6
NOTE: StringBuffer is synchronized, StringBuilder is not.
Reviewed-on: https://gerrit.libreoffice.org/11436
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

2 files changed, 2 insertions, 6 deletions

diff --git a/scripting/java/org/openoffice/idesupport/SVersionRCFile.java b/scripting/java/org/openoffice/idesupport/SVersionRCFile.java
index 883b28f00aee..a258983da7dd 100644
--- a/scripting/java/org/openoffice/idesupport/SVersionRCFile.java
+++ b/scripting/java/org/openoffice/idesupport/SVersionRCFile.java
@@ -160,7 +160,7 @@ public class SVersionRCFile {
         if (System.getProperty("os.name").startsWith("Windows"))
             path = path.replace(File.separatorChar, '/');
 
-        StringBuffer buf = new StringBuffer(FILE_URL_PREFIX);
+        StringBuilder buf = new StringBuilder(FILE_URL_PREFIX);
         buf.append(path);
 
         if (f.isDirectory())
diff --git a/scripting/java/org/openoffice/idesupport/filter/ExceptParcelFilter.java b/scripting/java/org/openoffice/idesupport/filter/ExceptParcelFilter.java
index 36bee314c47d..792c9d42a26d 100644
--- a/scripting/java/org/openoffice/idesupport/filter/ExceptParcelFilter.java
+++ b/scripting/java/org/openoffice/idesupport/filter/ExceptParcelFilter.java
@@ -42,10 +42,6 @@ public class ExceptParcelFilter implements FileFilter {
 
     @Override
     public String toString() {
-        StringBuffer buf = new StringBuffer(DESCRIPTION + ": ");
-
-        buf.append("<" + ExceptParcelFilter.parcelName + ">");
-
-        return buf.toString();
+        return DESCRIPTION + ": " + "<" + ExceptParcelFilter.parcelName + ">";
     }
 }