remove unnecessary "if (!empty()" checks before loops

found with
git grep -n -A4 'if.*!.*empty' | grep -B3 -P
'(\bfor)|(\bwhile)|(\bdo)'

Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334
Reviewed-on: https://gerrit.libreoffice.org/64169
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 9 insertions, 12 deletions

diff --git a/scripting/source/provider/BrowseNodeFactoryImpl.cxx b/scripting/source/provider/BrowseNodeFactoryImpl.cxx
index b27ac817329f..a0ff04cf2e1f 100644
--- a/scripting/source/provider/BrowseNodeFactoryImpl.cxx
+++ b/scripting/source/provider/BrowseNodeFactoryImpl.cxx
@@ -123,23 +123,20 @@ public:
     virtual sal_Bool SAL_CALL
     hasChildNodes() override
     {
-        if ( !m_Nodes.empty() )
+        for (Reference<XBrowseNode> & xNode : m_Nodes)
         {
-            for (Reference<XBrowseNode> & xNode : m_Nodes)
+            try
             {
-                try
-                {
-                    if ( xNode->hasChildNodes() )
-                    {
-                        return true;
-                    }
-                }
-                catch ( Exception& )
+                if ( xNode->hasChildNodes() )
                 {
-                    // some form of exception getting child nodes so move
-                    // on to the next one
+                    return true;
                 }
             }
+            catch ( Exception& )
+            {
+                // some form of exception getting child nodes so move
+                // on to the next one
+            }
         }
 
         return false;