summaryrefslogtreecommitdiff
path: root/scripting/workben
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2014-08-13 10:19:51 +0200
committerNoel Grandin <noel@peralex.com>2014-08-20 10:35:53 +0200
commit60f152caeee38579433a31dd3a98e91dc3d23ff6 (patch)
tree15ba69f938e09bb173ca7de2e1b21b62e740ea40 /scripting/workben
parent2922a967a1da5f9c0a07b5390906307d0ae6fe48 (diff)
java: avoid unnecessary comparisons in boolean expressions
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
Diffstat (limited to 'scripting/workben')
-rw-r--r--scripting/workben/installer/IdeUpdater.java2
-rw-r--r--scripting/workben/installer/IdeVersion.java4
-rw-r--r--scripting/workben/installer/InstUtil.java2
-rw-r--r--scripting/workben/installer/Version.java4
-rw-r--r--scripting/workben/installer/ZipData.java2
5 files changed, 7 insertions, 7 deletions
diff --git a/scripting/workben/installer/IdeUpdater.java b/scripting/workben/installer/IdeUpdater.java
index fe7b700d237d..b35b519abbe3 100644
--- a/scripting/workben/installer/IdeUpdater.java
+++ b/scripting/workben/installer/IdeUpdater.java
@@ -44,7 +44,7 @@ public class IdeUpdater extends Thread {
public IdeUpdater(String installPath, JLabel statusLabel, JProgressBar pBar) {
- if (installPath.endsWith(File.separator) == false)
+ if (!installPath.endsWith(File.separator))
installPath += File.separator;
File netbeansLauncher = new File( installPath + "bin" );
diff --git a/scripting/workben/installer/IdeVersion.java b/scripting/workben/installer/IdeVersion.java
index 65b18f61338f..b75d5b38a04e 100644
--- a/scripting/workben/installer/IdeVersion.java
+++ b/scripting/workben/installer/IdeVersion.java
@@ -155,7 +155,7 @@ public class IdeVersion extends javax.swing.JPanel implements ActionListener, Ta
int len = tableModel.data.size();
for (int i = 0; i < len; i++) {
ArrayList<?> list = tableModel.data.get(i);
- if (((Boolean)list.get(0)).booleanValue() == true)
+ if (((Boolean)list.get(0)).booleanValue())
InstallWizard.storeLocation((String)list.get(2));
}
}
@@ -319,7 +319,7 @@ class MyTableModelIDE extends AbstractTableModel {
Iterator iter = data.iterator();
while (iter.hasNext()) {
ArrayList<?> row = (ArrayList<?>)iter.next();
- if (((Boolean)row.get(0)).booleanValue() == true) {
+ if (((Boolean)row.get(0)).booleanValue()) {
return true;
}
}
diff --git a/scripting/workben/installer/InstUtil.java b/scripting/workben/installer/InstUtil.java
index 703871dd67c7..d9bab179344f 100644
--- a/scripting/workben/installer/InstUtil.java
+++ b/scripting/workben/installer/InstUtil.java
@@ -67,7 +67,7 @@ public class InstUtil {
boolean result = false;
result = checkForSupportedVersion( getNetbeansLocation(), versions );
- if (result == false)
+ if (!result)
System.out.println("No supported version of NetBeans found.");
return result;
}
diff --git a/scripting/workben/installer/Version.java b/scripting/workben/installer/Version.java
index 37bc7dde043c..4d125dee8fe6 100644
--- a/scripting/workben/installer/Version.java
+++ b/scripting/workben/installer/Version.java
@@ -215,7 +215,7 @@ public class Version extends javax.swing.JPanel implements ActionListener, Table
int len = tableModel.data.size();
for (int i = 0; i < len; i++) {
ArrayList<?> list = tableModel.data.get(i);
- if (((Boolean)list.get(0)).booleanValue() == true)
+ if (((Boolean)list.get(0)).booleanValue())
InstallWizard.storeLocation((String)list.get(2));
}
}
@@ -334,7 +334,7 @@ class MyTableModel extends AbstractTableModel {
Iterator iter = data.iterator();
while (iter.hasNext()) {
ArrayList<?> row = (ArrayList<?>)iter.next();
- if (((Boolean)row.get(0)).booleanValue() == true) {
+ if (((Boolean)row.get(0)).booleanValue()) {
return true;
}
}
diff --git a/scripting/workben/installer/ZipData.java b/scripting/workben/installer/ZipData.java
index abdf8a6641c2..466f87a6e863 100644
--- a/scripting/workben/installer/ZipData.java
+++ b/scripting/workben/installer/ZipData.java
@@ -56,7 +56,7 @@ public class ZipData {
System.out.println("Unzipping " + entry + " to " + destination);
- if (entry.startsWith("/") == false)
+ if (!entry.startsWith("/"))
entry = "/" + entry;
in = this.getClass().getResourceAsStream(entry);