diff options
| author | Noel Grandin <noel@peralex.com> | 2016-04-12 16:39:03 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-18 07:37:31 +0000 |
| commit | 789055bc2acb4c71483fd60ea258d158bd5aec10 (patch) | |
| tree | 7849de841a71f667a30b2a971ad0c3d406110396 /scripting | |
| parent | 150ac9cf05ed9da6a2af5bc3f820280fd853e519 (diff) | |
clang-tidy performance-unnecessary-copy-initialization
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'scripting')
| -rw-r--r-- | scripting/source/dlgprov/dlgevtatt.cxx | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/scripting/source/dlgprov/dlgevtatt.cxx b/scripting/source/dlgprov/dlgevtatt.cxx index dd2d18f92e7c..b0a51fe1047c 100644 --- a/scripting/source/dlgprov/dlgevtatt.cxx +++ b/scripting/source/dlgprov/dlgevtatt.cxx @@ -624,17 +624,16 @@ namespace dlgprov if( pResMgr ) { OUString aRes( ResId(STR_ERRUNOEVENTBINDUNG, *pResMgr) ); - OUString aQuoteChar( "\"" ); + OUString aQuoteChar( "\"" ); - OUString aOURes = aRes; - sal_Int32 nIndex = aOURes.indexOf( '%' ); + sal_Int32 nIndex = aRes.indexOf( '%' ); OUString aOUFinal; - aOUFinal += aOURes.copy( 0, nIndex ); + aOUFinal += aRes.copy( 0, nIndex ); aOUFinal += aQuoteChar; aOUFinal += aMethodName; aOUFinal += aQuoteChar; - aOUFinal += aOURes.copy( nIndex + 2 ); + aOUFinal += aRes.copy( nIndex + 2 ); ScopedVclPtrInstance<MessageDialog>::Create(nullptr, aOUFinal)->Execute(); } |